[ https://issues.apache.org/jira/browse/HIVE-21729?focusedWorklogId=242248&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-242248 ]
ASF GitHub Bot logged work on HIVE-21729: ----------------------------------------- Author: ASF GitHub Bot Created on: 15/May/19 05:28 Start Date: 15/May/19 05:28 Worklog Time Spent: 10m Work Description: ShubhamChaurasia commented on pull request #627: HIVE-21729: Arrow serializer sometimes shifts timestamp by one second URL: https://github.com/apache/hive/pull/627 ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 242248) Time Spent: 10m Remaining Estimate: 0h > Arrow serializer sometimes shifts timestamp by one second > --------------------------------------------------------- > > Key: HIVE-21729 > URL: https://issues.apache.org/jira/browse/HIVE-21729 > Project: Hive > Issue Type: Bug > Components: Serializers/Deserializers > Affects Versions: 3.1.1 > Reporter: Shubham Chaurasia > Assignee: Shubham Chaurasia > Priority: Major > Labels: pull-request-available > Time Spent: 10m > Remaining Estimate: 0h > > This happens due to > [secondInMicros|https://github.com/apache/hive/blob/rel/release-3.1.1/ql/src/java/org/apache/hadoop/hive/ql/io/arrow/Serializer.java#L445] > are calculated like > {code} > final long secondInMicros = (secondInMillis - secondInMillis % > MILLIS_PER_SECOND) * MICROS_PER_MILLIS; > {code} > Instead this should be calculated like(by taking nanos from > timestampColumnVector itself) > {code} > final long nanos = timestampColumnVector.getNanos(j); > final long secondInMicros = (secondInMillis - nanos / NS_PER_MILLIS) * > MICROS_PER_MILLIS; > {code} -- This message was sent by Atlassian JIRA (v7.6.3#76005)