[ https://issues.apache.org/jira/browse/HIVE-16184?focusedWorklogId=240912&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-240912 ]
ASF GitHub Bot logged work on HIVE-16184: ----------------------------------------- Author: ASF GitHub Bot Created on: 13/May/19 07:13 Start Date: 13/May/19 07:13 Worklog Time Spent: 10m Work Description: macalinao commented on pull request #157: [HIVE-16184] Thrift cleanup URL: https://github.com/apache/hive/pull/157 ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 240912) Time Spent: 10m Remaining Estimate: 0h > Remove use of optionals in union; declare TProgressUpdateResp before its usage > ------------------------------------------------------------------------------ > > Key: HIVE-16184 > URL: https://issues.apache.org/jira/browse/HIVE-16184 > Project: Hive > Issue Type: Bug > Components: Thrift API > Reporter: Ian Macalinao > Assignee: Ian Macalinao > Priority: Minor > Labels: pull-request-available > Attachments: HIVE-16184.patch > > Time Spent: 10m > Remaining Estimate: 0h > > A Scala Thrift generator (https://github.com/twitter/scrooge) does not like > the Thrift file. I have removed some bad Thrift practices (i.e. optionals in > union, dependent types declared after their usage) and replaced them with > things that work in Scrooge. > See https://github.com/apache/hive/pull/157 -- This message was sent by Atlassian JIRA (v7.6.3#76005)