[
https://issues.apache.org/jira/browse/HIVE-21671?focusedWorklogId=238719&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-238719
]
ASF GitHub Bot logged work on HIVE-21671:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 07/May/19 19:01
Start Date: 07/May/19 19:01
Worklog Time Spent: 10m
Work Description: sankarh commented on pull request #615: HIVE-21671:
Replicate Streaming ingestion with transactional batch size as 1.
URL: https://github.com/apache/hive/pull/615#discussion_r281785653
##########
File path: streaming/src/java/org/apache/hive/streaming/TransactionBatch.java
##########
@@ -285,6 +285,18 @@ private void commitImpl(Set<String> partitions, String
key, String value)
DataOperationType.INSERT);
}
}
+
+ // If it is the last transaction in the batch, then close the files and
add write events.
+ // We need to close the writer as file checksum can't be obtained on the
opened file.
+ if (currentTxnIndex + 1 >= txnToWriteIds.size()) {
+ // TODO: Replication doesn't work if txn batch size > 1 and the last
txn is aborted as write events
+ // are ignored by abort txn event.
+ recordWriter.close();
+
+ // Add write notification events if it is enabled.
+ conn.addWriteNotificationEvents();
Review comment:
Yes, it is already called before commit. Otherwise test wouldn't pass.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 238719)
Time Spent: 2h (was: 1h 50m)
> Replicate Streaming ingestion with transactional batch size as 1.
> -----------------------------------------------------------------
>
> Key: HIVE-21671
> URL: https://issues.apache.org/jira/browse/HIVE-21671
> Project: Hive
> Issue Type: Sub-task
> Components: repl, Streaming, Transactions
> Affects Versions: 4.0.0
> Reporter: Sankar Hariappan
> Assignee: Sankar Hariappan
> Priority: Major
> Labels: DR, pull-request-available, replication
> Attachments: HIVE-21671.01.patch
>
> Time Spent: 2h
> Remaining Estimate: 0h
>
> Replication streaming ingest HiveStreamingConnection on ACID tables with
> transaction batch size as 1.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
