[
https://issues.apache.org/jira/browse/HIVE-21661?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16829209#comment-16829209
]
Laszlo Bodor edited comment on HIVE-21661 at 4/29/19 12:33 PM:
---------------------------------------------------------------
[~bpusztahazi]: I like the idea and the implementation as well, only one note:
could you please refactor the new functionality to a new class (syntax checker
or stuff)? However, QTestUtil is already a big monster, let's try not to fatten
it further (e.g. lots of new processor imports introduced by the patch which
QTestUtil shouldn't be aware of IMO)
was (Author: abstractdog):
[~bpusztahazi]: I like the idea and the implementation as well, only one note:
could you please refactor the new functionality to a new class (syntax checker
or stuff)? However, QTestUtil is already a big monster, let's try not to fatten
it further (e.g. lots of new processor imports which QTestUtils shouldn't be
aware of)
> Add option to check q file syntax before execution
> --------------------------------------------------
>
> Key: HIVE-21661
> URL: https://issues.apache.org/jira/browse/HIVE-21661
> Project: Hive
> Issue Type: Improvement
> Components: Testing Infrastructure
> Reporter: Bruno Pusztahazi
> Assignee: Bruno Pusztahazi
> Priority: Major
> Attachments: HIVE-21661.1.patch
>
>
> Currently q file tests are executed line-by-line. This could lead to
> problems, e.g. when a q file has some long running queries and the last line
> contains a syntax error. In this case everything before the wrong line will
> be executed first, which could take a lot of time and only then will the test
> fail due to the syntax error.
> I propose a simple syntax checker that will check the q file for errors
> before executing any statements. This check can will be turned off by default
> and can be enabled with the following option:
> {code:java}
> -Dtest.check.syntax=true{code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
