[ https://issues.apache.org/jira/browse/HIVE-21395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16801219#comment-16801219 ]
Hive QA commented on HIVE-21395: -------------------------------- Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12963661/HIVE-21395.1.patch {color:red}ERROR:{color} -1 due to no test(s) being added or modified. {color:red}ERROR:{color} -1 due to 8 failed/errored test(s), 15803 tests executed *Failed tests:* {noformat} TestDataSourceProviderFactory - did not produce a TEST-*.xml file (likely timed out) (batchId=230) TestObjectStore - did not produce a TEST-*.xml file (likely timed out) (batchId=230) TestPartitionProjectionEvaluator - did not produce a TEST-*.xml file (likely timed out) (batchId=230) org.apache.hive.jdbc.TestTriggersTezSessionPoolManager.testTriggerCustomCreatedDynamicPartitions (batchId=263) org.apache.hive.jdbc.TestTriggersTezSessionPoolManager.testTriggerCustomCreatedDynamicPartitionsUnionAll (batchId=263) org.apache.hive.jdbc.TestTriggersTezSessionPoolManager.testTriggerCustomNonExistent (batchId=263) org.apache.hive.jdbc.TestTriggersTezSessionPoolManager.testTriggerHighShuffleBytes (batchId=263) org.apache.hive.jdbc.TestTriggersTezSessionPoolManager.testTriggerSlowQueryExecutionTime (batchId=263) {noformat} Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/16676/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/16676/console Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-16676/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.YetusPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase Tests exited with: TestsFailedException: 8 tests failed {noformat} This message is automatically generated. ATTACHMENT ID: 12963661 - PreCommit-HIVE-Build > Refactor HiveSemiJoinRule > ------------------------- > > Key: HIVE-21395 > URL: https://issues.apache.org/jira/browse/HIVE-21395 > Project: Hive > Issue Type: Improvement > Components: Query Planning > Affects Versions: 4.0.0 > Reporter: Vineet Garg > Assignee: Vineet Garg > Priority: Major > Attachments: HIVE-21395.1.patch > > > Following refactoring needs to be done: > * Update the rule matching pattern to avoid using HepVertex > * HIVE-21338 adds logic to determine if rel plan will produce at most one > row. Use this in HiveSemiJoinRule -- This message was sent by Atlassian JIRA (v7.6.3#76005)