[ https://issues.apache.org/jira/browse/HIVE-21204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16800156#comment-16800156 ]
Hive QA commented on HIVE-21204: -------------------------------- Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12963556/HIVE-21204.5.patch {color:green}SUCCESS:{color} +1 due to 1 test(s) being added or modified. {color:red}ERROR:{color} -1 due to 3 failed/errored test(s), 15802 tests executed *Failed tests:* {noformat} TestDataSourceProviderFactory - did not produce a TEST-*.xml file (likely timed out) (batchId=230) TestObjectStore - did not produce a TEST-*.xml file (likely timed out) (batchId=230) TestPartitionProjectionEvaluator - did not produce a TEST-*.xml file (likely timed out) (batchId=230) {noformat} Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/16662/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/16662/console Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-16662/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.YetusPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase Tests exited with: TestsFailedException: 3 tests failed {noformat} This message is automatically generated. ATTACHMENT ID: 12963556 - PreCommit-HIVE-Build > Instrumentation for read/write locks in LLAP > -------------------------------------------- > > Key: HIVE-21204 > URL: https://issues.apache.org/jira/browse/HIVE-21204 > Project: Hive > Issue Type: Improvement > Components: llap > Reporter: Oliver Draese > Assignee: Oliver Draese > Priority: Major > Attachments: HIVE-21204.4.patch, HIVE-21204.5.patch > > > LLAP has several R/W locks for serialization of updates to query tracker, > file data, .... > Instrumentation is added to monitor the > * total amount of R/W locks within a particular category > * average + max wait/suspension time to get the R/W lock > A category includes all lock instances for particular areas (i.e. category is > FileData and all R/W locks that are used in FileData instances are accounted > within the one category). > The monitoring/accounting is done via Hadoop Metrics 2, making them > accessible via JMX. In addition, a new "locking" GET endpoint is added to the > LLAP daemon's REST interface. It produces output like the following example: > { > {{ "statsCollection": "enabled",}} > {{ "lockStats": [}} > {{ {}}{{ "type": "R/W Lock Stats",}} > {{ "label": "FileData",}} > {{ "totalLockWaitTimeMillis": 0,}} > {{ "readLock": {}} > {{ "count": 0,}} > {{ "avgWaitTimeNanos": 0,}} > {{ "maxWaitTimeNanos": 0}} > {{ },}} > {{ "writeLock": {}} > {{ "count": 0,}} > {{ "avgWaitTimeNanos": 0,}} > {{ "maxWaitTimeNanos": 0}} > } > {{ },}} > {{ { "}}{{type": "R/W Lock Stats",}} > {{ "label": "QueryTracker",}} > {{ "totalLockWaitTimeMillis": 0,}} > {{ "readLock": {}} > {{ "count": 0,}} > {{ "avgWaitTimeNanos": 0,}} > {{ "maxWaitTimeNanos": 0}} > {{ },}} > {{ "writeLock": {}} > {{ "count": 0,}} > {{ "avgWaitTimeNanos": 0,}} > {{ "maxWaitTimeNanos": 0}} > } > {{ } }}{{]}} > {{}}} > To avoid the overhead of lock instrumentation, lock metrics collection is > disabled by default and can be enabled via the following configuration > parameter: > {{hive.llap.lockmetrics.collect = true}} > > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)