[ https://issues.apache.org/jira/browse/HIVE-20580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16792400#comment-16792400 ]
Hive QA commented on HIVE-20580: -------------------------------- Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12962384/HIVE-20580.6.patch {color:green}SUCCESS:{color} +1 due to 2 test(s) being added or modified. {color:green}SUCCESS:{color} +1 due to 15828 tests passed Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/16499/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/16499/console Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-16499/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.YetusPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase {noformat} This message is automatically generated. ATTACHMENT ID: 12962384 - PreCommit-HIVE-Build > OrcInputFormat.isOriginal() should not rely on hive.acid.key.index > ------------------------------------------------------------------ > > Key: HIVE-20580 > URL: https://issues.apache.org/jira/browse/HIVE-20580 > Project: Hive > Issue Type: Improvement > Components: Transactions > Affects Versions: 3.1.0 > Reporter: Eugene Koifman > Assignee: Peter Vary > Priority: Major > Attachments: HIVE-20580.2.patch, HIVE-20580.3.patch, > HIVE-20580.4.patch, HIVE-20580.5.patch, HIVE-20580.6.patch, HIVE-20580.patch > > > {{org.apache.hadoop.hive.ql.io.orc.OrcInputFormat.isOriginal()}} is checking > for presence of {{hive.acid.key.index}} in the footer. This is only created > when the file is written by {{OrcRecordUpdater}}. It should instead check > for presence of Acid metadata columns so that a file can be produced by > something other than {{OrcRecordUpater}}. > Also, {{hive.acid.key.index}} counts number of different type of events which > is not really useful for Acid V2 (as of Hive 3) since each file only has 1 > type of event. -- This message was sent by Atlassian JIRA (v7.6.3#76005)