[ https://issues.apache.org/jira/browse/HIVE-15406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16791760#comment-16791760 ]
Zoltan Haindrich commented on HIVE-15406: ----------------------------------------- I think the latest patch might contain undrelated changes; or is there a reason to make it "Hive and closely related projects" ? If there is no pressure; VisibleForTesting should be enough - and I think it's a little bit out of scope in this ticket. In the reviewboard request: if you add the "hive" group - then the review request is also sent to the dev list. {code} - @VisibleForTesting + /** + * Returns the Query ID if it is running. + * This method is a public API for usage outside of Hive, although it is not part of the + * interface java.sql.Statement. + * @return Valid query ID if it is running else returns NULL. + * @throws SQLException If any internal failures. + */ + @LimitedPrivate(value={"Hive and closely related projects."}) public String getQueryId() throws SQLException { {code} > Consider vectorizing the new 'trunc' function > --------------------------------------------- > > Key: HIVE-15406 > URL: https://issues.apache.org/jira/browse/HIVE-15406 > Project: Hive > Issue Type: Bug > Components: Vectorization > Affects Versions: 4.0.0 > Reporter: Matt McCline > Assignee: Laszlo Bodor > Priority: Critical > Attachments: HIVE-15406.01.patch, HIVE-15406.02.patch, > HIVE-15406.03.patch, HIVE-15406.04.patch > > > Rounding function 'trunc' added by HIVE-14582. -- This message was sent by Atlassian JIRA (v7.6.3#76005)