[
https://issues.apache.org/jira/browse/HIVE-21401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16788479#comment-16788479
]
Hive QA commented on HIVE-21401:
--------------------------------
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 1m
27s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 7m
26s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m
10s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
24s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 4m
22s{color} | {color:blue} ql in master has 2258 extant Findbugs warnings.
{color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
43s{color} | {color:blue} hcatalog/core in master has 29 extant Findbugs
warnings. {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
54s{color} | {color:blue} itests/util in master has 48 extant Findbugs
warnings. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
44s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
30s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 2m
36s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m
9s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 2m
9s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m
55s{color} | {color:red} ql: The patch generated 21 new + 1602 unchanged - 115
fixed = 1623 total (was 1717) {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m
15s{color} | {color:red} hcatalog/core: The patch generated 3 new + 44
unchanged - 4 fixed = 47 total (was 48) {color} |
| {color:red}-1{color} | {color:red} whitespace {color} | {color:red} 0m
0s{color} | {color:red} The patch has 5 line(s) that end in whitespace. Use git
apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply
{color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 4m
37s{color} | {color:red} ql generated 4 new + 2256 unchanged - 2 fixed = 2260
total (was 2258) {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 0m
50s{color} | {color:red} hcatalog/core generated 1 new + 28 unchanged - 1 fixed
= 29 total (was 29) {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
44s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
17s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 36m 37s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| FindBugs | module:ql |
| | org.apache.hadoop.hive.ql.ddl.DDLOperation.writeToFile(String, String)
may fail to close stream At DDLOperation.java:close stream At
DDLOperation.java:[line 183] |
| | org.apache.hadoop.hive.ql.ddl.DDLOperation.propertiesToString(Map, List)
makes inefficient use of keySet iterator instead of entrySet iterator At
DDLOperation.java:of keySet iterator instead of entrySet iterator At
DDLOperation.java:[line 168] |
| | Class org.apache.hadoop.hive.ql.plan.DropPartitionDesc defines
non-transient non-serializable instance field partSpecs In
DropPartitionDesc.java:instance field partSpecs In DropPartitionDesc.java |
| | Class org.apache.hadoop.hive.ql.plan.DropPartitionDesc defines
non-transient non-serializable instance field replicationSpec In
DropPartitionDesc.java:instance field replicationSpec In
DropPartitionDesc.java |
| FindBugs | module:hcatalog/core |
| | Redundant nullcheck of desc, which is known to be non-null in
org.apache.hive.hcatalog.cli.SemanticAnalysis.CreateTableHook.postAnalyze(HiveSemanticAnalyzerHookContext,
List) Redundant null check at CreateTableHook.java:is known to be non-null in
org.apache.hive.hcatalog.cli.SemanticAnalysis.CreateTableHook.postAnalyze(HiveSemanticAnalyzerHookContext,
List) Redundant null check at CreateTableHook.java:[line 176] |
\\
\\
|| Subsystem || Report/Notes ||
| Optional Tests | asflicense javac javadoc findbugs checkstyle compile |
| uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian
3.16.36-1+deb8u1 (2016-09-03) x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/data/hiveptest/working/yetus_PreCommit-HIVE-Build-16423/dev-support/hive-personality.sh
|
| git revision | master / e7f7fe3 |
| Default Java | 1.8.0_111 |
| findbugs | v3.0.0 |
| checkstyle |
http://104.198.109.242/logs//PreCommit-HIVE-Build-16423/yetus/diff-checkstyle-ql.txt
|
| checkstyle |
http://104.198.109.242/logs//PreCommit-HIVE-Build-16423/yetus/diff-checkstyle-hcatalog_core.txt
|
| whitespace |
http://104.198.109.242/logs//PreCommit-HIVE-Build-16423/yetus/whitespace-eol.txt
|
| findbugs |
http://104.198.109.242/logs//PreCommit-HIVE-Build-16423/yetus/new-findbugs-ql.html
|
| findbugs |
http://104.198.109.242/logs//PreCommit-HIVE-Build-16423/yetus/new-findbugs-hcatalog_core.html
|
| modules | C: ql hcatalog/core itests/util U: . |
| Console output |
http://104.198.109.242/logs//PreCommit-HIVE-Build-16423/yetus.txt |
| Powered by | Apache Yetus http://yetus.apache.org |
This message was automatically generated.
> Break up DDLTask - extract Table related operations
> ---------------------------------------------------
>
> Key: HIVE-21401
> URL: https://issues.apache.org/jira/browse/HIVE-21401
> Project: Hive
> Issue Type: Sub-task
> Components: Hive
> Affects Versions: 3.1.1
> Reporter: Miklos Gergely
> Assignee: Miklos Gergely
> Priority: Major
> Fix For: 4.0.0
>
> Attachments: HIVE-21401.01.patch, HIVE-21401.02.patch,
> HIVE-21401.03.patch, HIVE-21401.04.patch, HIVE-21401.05.patch
>
>
> DDLTask is a huge class, more than 5000 lines long. The related DDLWork is
> also a huge class, which has a field for each DDL operation it supports. The
> goal is to refactor these in order to have everything cut into more
> handleable classes under the package org.apache.hadoop.hive.ql.exec.ddl:
> * have a separate class for each operation
> * have a package for each operation group (database ddl, table ddl, etc), so
> the amount of classes under a package is more manageable
> * make all the requests (DDLDesc subclasses) immutable
> * DDLTask should be agnostic to the actual operations
> * right now let's ignore the issue of having some operations handled by
> DDLTask which are not actual DDL operations (lock, unlock, desc...)
> In the interim time when there are two DDLTask and DDLWork classes in the
> code base the new ones in the new package are called DDLTask2 and DDLWork2
> thus avoiding the usage of fully qualified class names where both the old and
> the new classes are in use.
> Step #2: extract all the table related operations from the old DDLTask except
> alter table, and move them under the new package. Also create the new
> internal framework.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
