[
https://issues.apache.org/jira/browse/HIVE-21368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16787503#comment-16787503
]
Teddy Choi edited comment on HIVE-21368 at 3/8/19 3:57 AM:
-----------------------------------------------------------
I found a commit that reverts HIVE-20315. [According to
Matt|https://issues.apache.org/jira/browse/HIVE-20315?focusedCommentId=16592355&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-16592355],
"Removed DECIMAL_64 conversion avoidance changes for GROUP BY / JOIN since
they caused external test failures". It may take more than few simple changes.
was (Author: teddy.choi):
I found a commit that reverts HIVE-20315. [According to
Matt|https://issues.apache.org/jira/browse/HIVE-20315?focusedCommentId=16592355&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-16592355],
the DECIMAL_64 to DECIMAL conversion was on purpose since they caused external
test failures. It may be related with more tests and take more than few simple
changes.
> Vectorization: Unnecessary Decimal64 -> HiveDecimal conversion
> --------------------------------------------------------------
>
> Key: HIVE-21368
> URL: https://issues.apache.org/jira/browse/HIVE-21368
> Project: Hive
> Issue Type: Bug
> Reporter: Gopal V
> Assignee: Teddy Choi
> Priority: Major
>
> Joins projecting Decimal64 have a suspicious cast in the inner loop
> {code}
> ConvertDecimal64ToDecimal(col 14:decimal(7,2)/DECIMAL_64) -> 24:decimal(7,2)'
> {code}
> {code}
> create temporary table foo(x int , y decimal(7,2));
> create temporary table bar(x int , y decimal(7,2));
> set hive.explain.user=false;
> explain vectorization detail select sum(foo.y) from foo, bar where foo.x =
> bar.x;
> {code}
> {code}
> ' Map Join Operator'
> ' condition map:'
> ' Inner Join 0 to 1'
> ' keys:'
> ' 0 _col0 (type: int)'
> ' 1 _col0 (type: int)'
> ' Map Join Vectorization:'
> ' bigTableKeyColumnNums: [0]'
> ' bigTableRetainedColumnNums: [3]'
> ' bigTableValueColumnNums: [3]'
> ' bigTableValueExpressions:
> ConvertDecimal64ToDecimal(col 1:decimal(7,2)/DECIMAL_64) -> 3:decimal(7,2)'
> ' className: VectorMapJoinInnerBigOnlyLongOperator'
> ' native: true'
> ' nativeConditionsMet:
> hive.mapjoin.optimized.hashtable IS true,
> hive.vectorized.execution.mapjoin.native.enabled IS true,
> hive.execution.engine tez IN [tez, spark] IS true, One MapJoin Condition IS
> true, No nullsafe IS true, Small table vectorizes IS true, Fast Hash Table
> and No Hybrid Hash Join IS true'
> ' projectedOutputColumnNums: [3]'
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
