[
https://issues.apache.org/jira/browse/HIVE-21286?focusedWorklogId=208449&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-208449
]
ASF GitHub Bot logged work on HIVE-21286:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 06/Mar/19 06:13
Start Date: 06/Mar/19 06:13
Worklog Time Spent: 10m
Work Description: ashutosh-bapat commented on pull request #551:
HIVE-21286: Hive should support clean-up of previously bootstrapped tables when
retry from different dump.
URL: https://github.com/apache/hive/pull/551#discussion_r262800301
##########
File path:
itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/parse/TestReplicationScenariosExternalTables.java
##########
@@ -573,23 +577,32 @@ public void
retryBootstrapExternalTablesFromDifferentDump() throws Throwable {
.run("create table t5 as select * from t4")
.dump(primaryDbName,
tupleBootstrapWithoutExternal.lastReplicationId, dumpWithClause);
- // Verify if bootstrapping with same dump is idempotent and return same
result
- for (int i = 0; i < 2; i++) {
- replica.load(replicatedDbName,
tupleIncWithExternalBootstrap.dumpLocation, loadWithClause)
- .status(replicatedDbName)
- .verifyResult(tupleIncWithExternalBootstrap.lastReplicationId)
- .run("use " + replicatedDbName)
- .run("show tables like 't1'")
- .verifyFailure(new String[]{"t1"})
- .run("select place from t2 where country = 'us'")
- .verifyResult("austin")
- .run("select id from t4")
- .verifyResult("10")
- .run("select id from t5")
- .verifyResult("10");
+ // Fail setting ckpt property for table t4 but success for t2.
+ BehaviourInjection<CallerArguments, Boolean> callerVerifier
+ = new BehaviourInjection<CallerArguments, Boolean>() {
+ @Nullable
+ @Override
+ public Boolean apply(@Nullable CallerArguments args) {
+ if (args.tblName.equalsIgnoreCase("t4") &&
args.dbName.equalsIgnoreCase(replicatedDbName)) {
+ injectionPathCalled = true;
+ LOG.warn("Verifier - DB : " + args.dbName + " TABLE : " +
args.tblName);
+ return false;
+ }
+ return true;
+ }
+ };
+
+ // Fail repl load before the ckpt property is set for t4 and after it is
set for t2.
+ // In the retry, these half baked tables should be dropped and bootstrap
should ve successful.
Review comment:
"should ve" - typo, should be "should be"
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 208449)
> Hive should support clean-up of previously bootstrapped tables when retry
> from different dump.
> ----------------------------------------------------------------------------------------------
>
> Key: HIVE-21286
> URL: https://issues.apache.org/jira/browse/HIVE-21286
> Project: Hive
> Issue Type: Bug
> Components: repl
> Affects Versions: 4.0.0
> Reporter: Sankar Hariappan
> Assignee: Sankar Hariappan
> Priority: Major
> Labels: DR, Replication, pull-request-available
> Attachments: HIVE-21286.01.patch, HIVE-21286.02.patch
>
> Time Spent: 4h 50m
> Remaining Estimate: 0h
>
> If external tables are enabled for replication on an existing repl policy,
> then bootstrapping of external tables are combined with incremental dump.
> If incremental bootstrap load fails with non-retryable error for which user
> will have to manually drop all the external tables before trying with another
> bootstrap dump. For full bootstrap, to retry with different dump, we
> suggested user to drop the DB but in this case they need to manually drop all
> the external tables which is not so user friendly. So, need to handle it in
> Hive side as follows.
> REPL LOAD takes additional config (passed by user in WITH clause) that says,
> drop all the tables which are bootstrapped from previous dump.
> hive.repl.clean.tables.from.bootstrap=<previous_bootstrap_dump_dir>
> Hive will use this config only if the current dump is bootstrap dump or
> combined bootstrap in incremental dump.
> Caution to be taken by user that this config should not be passed if previous
> REPL LOAD (with bootstrap) was successful or any successful incremental
> dump+load happened after "previous_bootstrap_dump_dir".
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
