[ https://issues.apache.org/jira/browse/HIVE-21376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16783826#comment-16783826 ]
Hive QA commented on HIVE-21376: -------------------------------- Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12961024/HIVE-21376.patch {color:green}SUCCESS:{color} +1 due to 1 test(s) being added or modified. {color:red}ERROR:{color} -1 due to 18 failed/errored test(s), 15819 tests executed *Failed tests:* {noformat} org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[orc_merge12] (batchId=68) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[orc_ppd_char] (batchId=11) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[vector_binary_join_groupby] (batchId=88) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[vector_data_types] (batchId=83) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[vector_decimal_expressions] (batchId=57) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[llap_uncompressed] (batchId=175) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[orc_llap] (batchId=171) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[orc_ppd_date] (batchId=171) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[orc_ppd_decimal] (batchId=160) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[orc_ppd_timestamp] (batchId=181) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[orc_ppd_varchar] (batchId=178) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[vector_binary_join_groupby] (batchId=181) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[vector_data_types] (batchId=180) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[vector_decimal_expressions] (batchId=174) org.apache.hadoop.hive.cli.TestMiniTezCliDriver.testCliDriver[orc_merge12] (batchId=110) org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[vector_data_types] (batchId=146) org.apache.hive.jdbc.TestJdbcWithMiniLlapArrow.testComplexQuery (batchId=263) org.apache.hive.jdbc.TestJdbcWithMiniLlapArrow.testKillQuery (batchId=263) {noformat} Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/16329/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/16329/console Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-16329/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.YetusPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase Tests exited with: TestsFailedException: 18 tests failed {noformat} This message is automatically generated. ATTACHMENT ID: 12961024 - PreCommit-HIVE-Build > Incompatible change in Hive bucket computation > ---------------------------------------------- > > Key: HIVE-21376 > URL: https://issues.apache.org/jira/browse/HIVE-21376 > Project: Hive > Issue Type: Bug > Affects Versions: 3.1.0 > Reporter: David Phillips > Assignee: Jesus Camacho Rodriguez > Priority: Major > Attachments: HIVE-21376.patch > > > HIVE-20007 seems to have inadvertently changed the bucket hash code > computation via {{ObjectInspectorUtils.getBucketHashCodeOld()}} for the > {{DATE}} and {{TIMESTAMP}} data type2. > {{DATE}} was previously computed using {{DateWritable}}, which uses > {{daysSinceEpoch}} as the hash code. It is now computed using > {{DateWritableV2}}, which uses the hash code of {{java.time.LocalDate}} > (which is not days since epoch). > {{TIMESTAMP}} was previous computed using {{TimestampWritable}} and now uses > {{TimestampWritableV2}}. They ostensibly use the same hash code computation, > but there are two important differences: > # {{TimestampWritable}} rounds the number of milliseconds into the seconds > portion of the computation, but {{TimestampWritableV2}} does not. > # {{TimestampWritable}} gets the epoch time from {{java.sql.Timestamp}}, > which returns it relative to the JVM time zone, not UTC. > {{TimestampWritableV2}} uses a {{LocalDateTime}} relative to UTC. > I was unable to get Hive 3.1 running in order to verify if this actually > causes data to be read or written incorrectly (there may be code above this > library method which makes things work correctly). However, if my > understanding is correct, this means Hive 3.1 is both forwards and backwards > incompatible with bucketed tables using either of these data types. It also > indicates that Hive needs tests to verify that the hash code does not change > between releases. -- This message was sent by Atlassian JIRA (v7.6.3#76005)