[
https://issues.apache.org/jira/browse/HIVE-21313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16776314#comment-16776314
]
Hive QA commented on HIVE-21313:
--------------------------------
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12959947/HIVE-21313.patch
{color:red}ERROR:{color} -1 due to no test(s) being added or modified.
{color:red}ERROR:{color} -1 due to 99 failed/errored test(s), 15811 tests
executed
*Failed tests:*
{noformat}
org.apache.hadoop.hive.cli.TestAccumuloCliDriver.testCliDriver[accumulo_queries]
(batchId=267)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[allcolref_in_udf]
(batchId=57)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[auto_join11] (batchId=10)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[auto_join12] (batchId=26)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[auto_join13] (batchId=87)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[auto_join15] (batchId=17)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[auto_join20] (batchId=96)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[auto_join22] (batchId=61)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[auto_join26] (batchId=15)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[auto_join29] (batchId=59)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[auto_join31] (batchId=48)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[auto_join_stats2]
(batchId=94)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[ba_table_udfs]
(batchId=26)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[cbo_udf_max] (batchId=2)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[correlationoptimizer7]
(batchId=23)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[join30] (batchId=84)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[join40] (batchId=58)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[lateral_view_outer]
(batchId=46)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[mapjoin47] (batchId=64)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[mapjoin_filter_on_outerjoin]
(batchId=66)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[mapjoin_memcheck]
(batchId=45)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[mapjoin_subquery]
(batchId=55)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[mapjoin_test_outer]
(batchId=1)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[masking_10] (batchId=46)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[masking_12] (batchId=1)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[masking_13] (batchId=80)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[masking_1] (batchId=91)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[masking_1_newdb]
(batchId=12)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[masking_2] (batchId=94)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[masking_5] (batchId=31)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[masking_6] (batchId=28)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[masking_7] (batchId=47)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[masking_8] (batchId=8)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[masking_disablecbo_1]
(batchId=55)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[masking_disablecbo_2]
(batchId=48)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[masking_mv] (batchId=88)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[skewjoin_mapjoin5]
(batchId=68)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[skewjoin_mapjoin6]
(batchId=65)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[skewjoin_mapjoin8]
(batchId=41)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[skewjoinopt10]
(batchId=22)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[udf_max] (batchId=52)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[udf_min] (batchId=44)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[udf_sentences]
(batchId=42)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[union_pos_alias]
(batchId=57)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[union_remove_12]
(batchId=47)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[union_remove_13]
(batchId=94)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[union_remove_14]
(batchId=14)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[vector_binary_join_groupby]
(batchId=88)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[vector_case_when_2]
(batchId=58)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[vector_varchar_mapjoin1]
(batchId=27)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[vectorized_math_funcs]
(batchId=22)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[vectorized_parquet_types]
(batchId=72)
org.apache.hadoop.hive.cli.TestCompareCliDriver.testCliDriver[vectorized_math_funcs]
(batchId=271)
org.apache.hadoop.hive.cli.TestHBaseCliDriver.testCliDriver[hbase_custom_key2]
(batchId=104)
org.apache.hadoop.hive.cli.TestHBaseCliDriver.testCliDriver[hbase_custom_key3]
(batchId=103)
org.apache.hadoop.hive.cli.TestHBaseCliDriver.testCliDriver[hbase_queries]
(batchId=105)
org.apache.hadoop.hive.cli.TestHBaseCliDriver.testCliDriver[hbase_timestamp]
(batchId=106)
org.apache.hadoop.hive.cli.TestMiniLlapCliDriver.testCliDriver[parquet_types_vectorization]
(batchId=153)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[lateral_view]
(batchId=181)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[lvj_mapjoin]
(batchId=164)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[mapjoin_emit_interval]
(batchId=167)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[unionDistinct_3]
(batchId=172)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[vector_case_when_2]
(batchId=174)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[vector_case_when_conversion]
(batchId=159)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[vector_fullouter_mapjoin_1_optimized_passthru]
(batchId=181)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[vector_leftsemi_mapjoin]
(batchId=161)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[vector_orc_merge_incompat_schema]
(batchId=179)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[vector_udf_adaptor_1]
(batchId=183)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[vectorized_join46]
(batchId=171)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[vectorized_math_funcs]
(batchId=164)
org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[auto_join12]
(batchId=122)
org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[auto_join20]
(batchId=152)
org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[auto_join29]
(batchId=136)
org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[auto_join30]
(batchId=125)
org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[auto_join3]
(batchId=149)
org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[join26]
(batchId=120)
org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[join28]
(batchId=150)
org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[join32_lessSize]
(batchId=114)
org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[join_map_ppr]
(batchId=146)
org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[mapjoin_filter_on_outerjoin]
(batchId=139)
org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[mapjoin_subquery]
(batchId=134)
org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[mapjoin_test_outer]
(batchId=111)
org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[skewjoinopt10]
(batchId=120)
org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[udf_max]
(batchId=133)
org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[udf_min]
(batchId=130)
org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[union21]
(batchId=111)
org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[vectorized_math_funcs]
(batchId=120)
org.apache.hadoop.hive.ql.exec.vector.expressions.TestVectorCastStatement.testBigInt
(batchId=316)
org.apache.hadoop.hive.ql.exec.vector.expressions.TestVectorCastStatement.testBoolean
(batchId=316)
org.apache.hadoop.hive.ql.exec.vector.expressions.TestVectorCastStatement.testChar
(batchId=316)
org.apache.hadoop.hive.ql.exec.vector.expressions.TestVectorCastStatement.testInt
(batchId=316)
org.apache.hadoop.hive.ql.exec.vector.expressions.TestVectorCastStatement.testSmallInt
(batchId=316)
org.apache.hadoop.hive.ql.exec.vector.expressions.TestVectorCastStatement.testString
(batchId=316)
org.apache.hadoop.hive.ql.exec.vector.expressions.TestVectorCastStatement.testTinyInt
(batchId=316)
org.apache.hadoop.hive.ql.exec.vector.expressions.TestVectorCastStatement.testVarchar
(batchId=316)
org.apache.hadoop.hive.ql.exec.vector.expressions.TestVectorCoalesceElt.testCoalesce
(batchId=313)
org.apache.hadoop.hive.ql.exec.vector.expressions.TestVectorCoalesceElt.testElt
(batchId=313)
org.apache.hadoop.hive.ql.exec.vector.expressions.TestVectorIfStatement.testBinary
(batchId=313)
org.apache.hadoop.hive.ql.exec.vector.expressions.TestVectorIfStatement.testString
(batchId=313)
{noformat}
Test results:
https://builds.apache.org/job/PreCommit-HIVE-Build/16222/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/16222/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-16222/
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.YetusPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 99 tests failed
{noformat}
This message is automatically generated.
ATTACHMENT ID: 12959947 - PreCommit-HIVE-Build
> Use faster function to point to instead of copy immutable byte arrays
> ---------------------------------------------------------------------
>
> Key: HIVE-21313
> URL: https://issues.apache.org/jira/browse/HIVE-21313
> Project: Hive
> Issue Type: Improvement
> Affects Versions: All Versions
> Reporter: ZhangXin
> Assignee: ZhangXin
> Priority: Minor
> Labels: pull-request-available
> Fix For: All Versions
>
> Attachments: HIVE-21313.patch, HIVE-21313.patch
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> In file ql/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorAssignRow.java
> We may find code like this:
> ```
> Text text = (Text) convertTargetWritable;
> if (text == null)
> { text = new Text(); }
> text.set(string);
> ((BytesColumnVector) columnVector).setVal(
> batchIndex, text.getBytes(), 0, text.getLength());
> ```
>
> Using `setVal` method can copy the bytes array generated by
> `text.getBytes()`. This is totally unnecessary at all. Since the bytes array
> is immutable, we can just use `setRef` method to point to the specific byte
> array, which will also lower the memory usage.
>
> Pull request on Github: https://github.com/apache/hive/pull/548
>
>
>
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
