[ https://issues.apache.org/jira/browse/HIVE-21303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16774644#comment-16774644 ]
Hive QA commented on HIVE-21303: -------------------------------- Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12959666/HIVE-21303.1.patch {color:red}ERROR:{color} -1 due to no test(s) being added or modified. {color:red}ERROR:{color} -1 due to 1 failed/errored test(s), 15780 tests executed *Failed tests:* {noformat} TestMiniLlapLocalCliDriver - did not produce a TEST-*.xml file (likely timed out) (batchId=171) [authorization_view_8.q,load_dyn_part5.q,vector_groupby_grouping_sets5.q,vector_complex_join.q,orc_llap.q,vectorization_7.q,cbo_gby.q,bucket_num_reducers_acid2.q,auto_sortmerge_join_1.q,results_cache_empty_result.q,lineage3.q,materialized_view_rewrite_empty.q,q93_with_constraints.q,vector_struct_in.q,bucketmapjoin3.q,vectorization_16.q,current_date_timestamp.q,orc_ppd_schema_evol_2a.q,partition_ctas.q,vector_windowing_multipartitioning.q,vectorized_join46.q,orc_ppd_date.q,create_merge_compressed.q,vector_outer_join1.q,dynpart_sort_optimization_acid.q,vectorization_not.q,having.q,vectorization_input_format_excludes.q,leftsemijoin.q,special_character_in_tabnames_1.q] {noformat} Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/16191/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/16191/console Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-16191/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.YetusPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase Tests exited with: TestsFailedException: 1 tests failed {noformat} This message is automatically generated. ATTACHMENT ID: 12959666 - PreCommit-HIVE-Build > Update TextRecordReader > ----------------------- > > Key: HIVE-21303 > URL: https://issues.apache.org/jira/browse/HIVE-21303 > Project: Hive > Issue Type: Improvement > Components: Query Processor > Affects Versions: 4.0.0, 3.2.0 > Reporter: BELUGA BEHR > Assignee: BELUGA BEHR > Priority: Major > Attachments: HIVE-21303.1.patch > > > Remove use of Deprecated > {{org.apache.hadoop.mapred.LineRecordReader.LineReader}} > For every call to {{next}}, the code dives into the configuration map to see > if this feature is enabled. Just look it up once and cache the value. > {code:java} > public int next(Writable row) throws IOException { > ... > if (HiveConf.getBoolVar(conf, HiveConf.ConfVars.HIVESCRIPTESCAPE)) { > return HiveUtils.unescapeText((Text) row); > } > return bytesConsumed; > } > {code} > Other clean up. -- This message was sent by Atlassian JIRA (v7.6.3#76005)