[ https://issues.apache.org/jira/browse/HIVE-21295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16772614#comment-16772614 ]
Hive QA commented on HIVE-21295: -------------------------------- | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | || || || || {color:brown} master Compile Tests {color} || | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 1m 51s{color} | {color:blue} Maven dependency ordering for branch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 7m 1s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 20s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 49s{color} | {color:green} master passed {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 3m 58s{color} | {color:blue} ql in master has 2262 extant Findbugs warnings. {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m 23s{color} | {color:blue} jdbc-handler in master has 12 extant Findbugs warnings. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 7s{color} | {color:green} master passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 28s{color} | {color:blue} Maven dependency ordering for patch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m 40s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 14s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m 14s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 49s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 4m 28s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 10s{color} | {color:green} the patch passed {color} | || || || || {color:brown} Other Tests {color} || | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 13s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 27m 11s{color} | {color:black} {color} | \\ \\ || Subsystem || Report/Notes || | Optional Tests | asflicense javac javadoc findbugs checkstyle compile | | uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 3.16.36-1+deb8u1 (2016-09-03) x86_64 GNU/Linux | | Build tool | maven | | Personality | /data/hiveptest/working/yetus_PreCommit-HIVE-Build-16155/dev-support/hive-personality.sh | | git revision | master / 104fa19 | | Default Java | 1.8.0_111 | | findbugs | v3.0.0 | | modules | C: ql jdbc-handler U: . | | Console output | http://104.198.109.242/logs//PreCommit-HIVE-Build-16155/yetus.txt | | Powered by | Apache Yetus http://yetus.apache.org | This message was automatically generated. > StorageHandler shall convert date to string using Hive convention > ----------------------------------------------------------------- > > Key: HIVE-21295 > URL: https://issues.apache.org/jira/browse/HIVE-21295 > Project: Hive > Issue Type: Improvement > Reporter: Daniel Dai > Assignee: Daniel Dai > Priority: Major > Attachments: HIVE-21295.1.patch > > > If we have date datatype in mysql, string datatype defined in hive, > JdbcStorageHandler will translate the date to string with the format > yyyy-MM-dd HH:mm:ss. However, Hive convention is yyyy-MM-dd, we shall follow > Hive convention. Eg: > mysql: CREATE TABLE test ("datekey" DATE); > hive: CREATE TABLE test (datekey string) STORED BY > 'org.apache.hive.storage.jdbc.JdbcStorageHandler' TBLPROPERTIES > (......"hive.sql.table" = "test"......); > Then in hive, do: select datekey from test; > We get: 1999-03-24 00:00:00 > But should be: 1999-03-24 -- This message was sent by Atlassian JIRA (v7.6.3#76005)