[ https://issues.apache.org/jira/browse/HIVE-21152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16772455#comment-16772455 ]
Hive QA commented on HIVE-21152: -------------------------------- Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12959295/HIVE-21152.01.patch {color:green}SUCCESS:{color} +1 due to 1 test(s) being added or modified. {color:red}ERROR:{color} -1 due to 174 failed/errored test(s), 15797 tests executed *Failed tests:* {noformat} org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[count_dist_rewrite] (batchId=78) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[decimal_udf] (batchId=10) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[deleteAnalyze] (batchId=33) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[explode_null] (batchId=29) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[fold_case] (batchId=16) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[groupby13] (batchId=34) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[groupby3_map] (batchId=73) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[groupby3_map_multi_distinct] (batchId=34) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[groupby3_noskew] (batchId=87) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[groupby3_noskew_multi_distinct] (batchId=67) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[groupby_grouping_sets_grouping] (batchId=4) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[infer_join_preds] (batchId=26) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[innerjoin1] (batchId=26) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[join_cond_pushdown_unqual5] (batchId=72) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[list_bucket_dml_6] (batchId=34) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[list_bucket_dml_7] (batchId=60) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[list_bucket_dml_8] (batchId=79) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[parquet_vectorization_0] (batchId=18) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[parquet_vectorization_12] (batchId=25) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[parquet_vectorization_14] (batchId=42) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[parquet_vectorization_15] (batchId=94) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[parquet_vectorization_16] (batchId=88) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[parquet_vectorization_1] (batchId=12) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[parquet_vectorization_3] (batchId=83) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[parquet_vectorization_9] (batchId=32) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[parquet_write_correct_definition_levels] (batchId=44) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[semijoin5] (batchId=17) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[udaf_percentile_approx_23] (batchId=37) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[udf6] (batchId=57) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[union_offcbo] (batchId=49) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[unionall_unbalancedppd] (batchId=3) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[vector_between_columns] (batchId=75) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[vector_case_when_1] (batchId=92) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[vector_case_when_2] (batchId=58) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[vector_coalesce] (batchId=12) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[vector_coalesce_2] (batchId=77) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[vector_coalesce_3] (batchId=62) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[vector_coalesce_4] (batchId=8) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[vector_decimal_aggregate] (batchId=19) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[vectorization_12] (batchId=11) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[vectorization_14] (batchId=16) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[vectorization_15] (batchId=70) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[vectorization_16] (batchId=46) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[vectorization_1] (batchId=63) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[vectorization_3] (batchId=83) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[vectorization_9] (batchId=1) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[vectorized_case] (batchId=62) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[vectorized_timestamp] (batchId=84) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[vectorized_timestamp_funcs] (batchId=33) org.apache.hadoop.hive.cli.TestMiniLlapCliDriver.testCliDriver[multi_count_distinct_null] (batchId=158) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[count_dist_rewrite] (batchId=178) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[kryo] (batchId=170) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[materialized_view_create_rewrite_4] (batchId=163) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[q93_with_constraints] (batchId=171) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[subquery_in] (batchId=176) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[subquery_notin] (batchId=178) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[subquery_scalar] (batchId=170) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[subquery_select] (batchId=170) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[vector_between_columns] (batchId=178) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[vector_case_when_1] (batchId=182) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[vector_case_when_2] (batchId=174) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[vector_coalesce] (batchId=161) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[vector_coalesce_2] (batchId=178) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[vector_coalesce_3] (batchId=175) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[vector_coalesce_4] (batchId=160) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[vector_decimal_aggregate] (batchId=163) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[vector_decimal_udf] (batchId=184) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[vector_groupby_grouping_sets_grouping] (batchId=160) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[vector_reuse_scratchcols] (batchId=169) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[vectorization_0] (batchId=182) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[vectorization_12] (batchId=161) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[vectorization_14] (batchId=162) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[vectorization_15] (batchId=176) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[vectorization_16] (batchId=171) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[vectorization_1] (batchId=175) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[vectorization_3] (batchId=180) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[vectorization_9] (batchId=159) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[vectorization_short_regress] (batchId=172) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[vectorized_case] (batchId=175) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[vectorized_timestamp] (batchId=180) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[vectorized_timestamp_funcs] (batchId=167) org.apache.hadoop.hive.cli.TestMiniSparkOnYarnCliDriver.testCliDriver[dynamic_rdd_cache] (batchId=191) org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[groupby3_map] (batchId=142) org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[groupby3_map_multi_distinct] (batchId=126) org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[groupby3_noskew] (batchId=148) org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[groupby3_noskew_multi_distinct] (batchId=139) org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[parquet_vectorization_0] (batchId=118) org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[parquet_vectorization_12] (batchId=122) org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[parquet_vectorization_14] (batchId=128) org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[parquet_vectorization_15] (batchId=151) org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[parquet_vectorization_16] (batchId=149) org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[parquet_vectorization_1] (batchId=115) org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[parquet_vectorization_3] (batchId=147) org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[parquet_vectorization_9] (batchId=125) org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[subquery_in] (batchId=140) org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[subquery_notin] (batchId=143) org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[subquery_scalar] (batchId=129) org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[subquery_select] (batchId=129) org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[vector_decimal_aggregate] (batchId=119) org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[vectorization_0] (batchId=149) org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[vectorization_12] (batchId=115) org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[vectorization_14] (batchId=117) org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[vectorization_15] (batchId=140) org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[vectorization_16] (batchId=130) org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[vectorization_1] (batchId=138) org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[vectorization_3] (batchId=147) org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[vectorization_9] (batchId=111) org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[vectorization_short_regress] (batchId=134) org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[vectorized_case] (batchId=137) org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[vectorized_timestamp_funcs] (batchId=125) org.apache.hadoop.hive.cli.TestSparkPerfCliDriver.testCliDriver[query11] (batchId=277) org.apache.hadoop.hive.cli.TestSparkPerfCliDriver.testCliDriver[query17] (batchId=277) org.apache.hadoop.hive.cli.TestSparkPerfCliDriver.testCliDriver[query21] (batchId=277) org.apache.hadoop.hive.cli.TestSparkPerfCliDriver.testCliDriver[query2] (batchId=277) org.apache.hadoop.hive.cli.TestSparkPerfCliDriver.testCliDriver[query31] (batchId=277) org.apache.hadoop.hive.cli.TestSparkPerfCliDriver.testCliDriver[query34] (batchId=277) org.apache.hadoop.hive.cli.TestSparkPerfCliDriver.testCliDriver[query36] (batchId=277) org.apache.hadoop.hive.cli.TestSparkPerfCliDriver.testCliDriver[query39] (batchId=277) org.apache.hadoop.hive.cli.TestSparkPerfCliDriver.testCliDriver[query40] (batchId=277) org.apache.hadoop.hive.cli.TestSparkPerfCliDriver.testCliDriver[query43] (batchId=277) org.apache.hadoop.hive.cli.TestSparkPerfCliDriver.testCliDriver[query47] (batchId=277) org.apache.hadoop.hive.cli.TestSparkPerfCliDriver.testCliDriver[query49] (batchId=277) org.apache.hadoop.hive.cli.TestSparkPerfCliDriver.testCliDriver[query4] (batchId=277) org.apache.hadoop.hive.cli.TestSparkPerfCliDriver.testCliDriver[query50] (batchId=277) org.apache.hadoop.hive.cli.TestSparkPerfCliDriver.testCliDriver[query51] (batchId=277) org.apache.hadoop.hive.cli.TestSparkPerfCliDriver.testCliDriver[query53] (batchId=277) org.apache.hadoop.hive.cli.TestSparkPerfCliDriver.testCliDriver[query57] (batchId=277) org.apache.hadoop.hive.cli.TestSparkPerfCliDriver.testCliDriver[query59] (batchId=277) org.apache.hadoop.hive.cli.TestSparkPerfCliDriver.testCliDriver[query63] (batchId=277) org.apache.hadoop.hive.cli.TestSparkPerfCliDriver.testCliDriver[query66] (batchId=277) org.apache.hadoop.hive.cli.TestSparkPerfCliDriver.testCliDriver[query67] (batchId=277) org.apache.hadoop.hive.cli.TestSparkPerfCliDriver.testCliDriver[query70] (batchId=277) org.apache.hadoop.hive.cli.TestSparkPerfCliDriver.testCliDriver[query72] (batchId=277) org.apache.hadoop.hive.cli.TestSparkPerfCliDriver.testCliDriver[query73] (batchId=277) org.apache.hadoop.hive.cli.TestSparkPerfCliDriver.testCliDriver[query74] (batchId=277) org.apache.hadoop.hive.cli.TestSparkPerfCliDriver.testCliDriver[query75] (batchId=277) org.apache.hadoop.hive.cli.TestSparkPerfCliDriver.testCliDriver[query77] (batchId=277) org.apache.hadoop.hive.cli.TestSparkPerfCliDriver.testCliDriver[query78] (batchId=277) org.apache.hadoop.hive.cli.TestSparkPerfCliDriver.testCliDriver[query80] (batchId=277) org.apache.hadoop.hive.cli.TestSparkPerfCliDriver.testCliDriver[query86] (batchId=277) org.apache.hadoop.hive.cli.TestSparkPerfCliDriver.testCliDriver[query89] (batchId=277) org.apache.hadoop.hive.cli.TestSparkPerfCliDriver.testCliDriver[query93] (batchId=277) org.apache.hadoop.hive.cli.TestSparkPerfCliDriver.testCliDriver[query97] (batchId=277) org.apache.hadoop.hive.cli.TestSparkPerfCliDriver.testCliDriver[query99] (batchId=277) org.apache.hadoop.hive.cli.TestSparkPerfCliDriver.testCliDriver[query9] (batchId=277) org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[query11] (batchId=275) org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[query21] (batchId=275) org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[query31] (batchId=275) org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[query34] (batchId=275) org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[query39] (batchId=275) org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[query47] (batchId=275) org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[query4] (batchId=275) org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[query53] (batchId=275) org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[query57] (batchId=275) org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[query63] (batchId=275) org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[query73] (batchId=275) org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[query74] (batchId=275) org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[query78] (batchId=275) org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[query89] (batchId=275) org.apache.hadoop.hive.cli.TestTezPerfConstraintsCliDriver.testCliDriver[query11] (batchId=275) org.apache.hadoop.hive.cli.TestTezPerfConstraintsCliDriver.testCliDriver[query21] (batchId=275) org.apache.hadoop.hive.cli.TestTezPerfConstraintsCliDriver.testCliDriver[query31] (batchId=275) org.apache.hadoop.hive.cli.TestTezPerfConstraintsCliDriver.testCliDriver[query34] (batchId=275) org.apache.hadoop.hive.cli.TestTezPerfConstraintsCliDriver.testCliDriver[query39] (batchId=275) org.apache.hadoop.hive.cli.TestTezPerfConstraintsCliDriver.testCliDriver[query47] (batchId=275) org.apache.hadoop.hive.cli.TestTezPerfConstraintsCliDriver.testCliDriver[query4] (batchId=275) org.apache.hadoop.hive.cli.TestTezPerfConstraintsCliDriver.testCliDriver[query53] (batchId=275) org.apache.hadoop.hive.cli.TestTezPerfConstraintsCliDriver.testCliDriver[query57] (batchId=275) org.apache.hadoop.hive.cli.TestTezPerfConstraintsCliDriver.testCliDriver[query63] (batchId=275) org.apache.hadoop.hive.cli.TestTezPerfConstraintsCliDriver.testCliDriver[query73] (batchId=275) org.apache.hadoop.hive.cli.TestTezPerfConstraintsCliDriver.testCliDriver[query74] (batchId=275) org.apache.hadoop.hive.cli.TestTezPerfConstraintsCliDriver.testCliDriver[query78] (batchId=275) org.apache.hadoop.hive.cli.TestTezPerfConstraintsCliDriver.testCliDriver[query89] (batchId=275) org.apache.hadoop.hive.ql.lockmgr.TestDbTxnManager2.testLocksInSubquery (batchId=326) {noformat} Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/16148/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/16148/console Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-16148/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.YetusPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase Tests exited with: TestsFailedException: 174 tests failed {noformat} This message is automatically generated. ATTACHMENT ID: 12959295 - PreCommit-HIVE-Build > Rewrite if expression to case and recognize simple case as an if > ---------------------------------------------------------------- > > Key: HIVE-21152 > URL: https://issues.apache.org/jira/browse/HIVE-21152 > Project: Hive > Issue Type: Improvement > Components: CBO > Reporter: Zoltan Haindrich > Assignee: Zoltan Haindrich > Priority: Major > Attachments: HIVE-21152.01.patch > > > * {{IF}} is not part of the sql standard; however given its special form its > simpler - and currently in Hive it also has vectorized support > * people writing standard sql may write: {{CASE WHEN member=1 THEN attr+1 > else attr+2 END}} which is essentially an if. > The idea is to rewrite IFs to CASEs for the cbo; and recognize simple > "CASE"-s as IFs to get vectorization on them if possible -- This message was sent by Atlassian JIRA (v7.6.3#76005)