[ https://issues.apache.org/jira/browse/HIVE-21240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16767920#comment-16767920 ]
Hive QA commented on HIVE-21240: -------------------------------- Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12958661/HIVE-21240.5.patch {color:green}SUCCESS:{color} +1 due to 2 test(s) being added or modified. {color:red}ERROR:{color} -1 due to 49 failed/errored test(s), 15805 tests executed *Failed tests:* {noformat} org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[json_serde1] (batchId=37) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[json_serde2] (batchId=22) org.apache.hadoop.hive.cli.TestMiniHiveKafkaCliDriver.testCliDriver[kafka_storage_handler] (batchId=275) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[schema_evol_orc_acid_part_update] (batchId=178) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[schema_evol_orc_acid_part_update_llap_io] (batchId=181) org.apache.hive.hcatalog.data.TestJsonSerDe.testRW (batchId=215) org.apache.hive.hcatalog.data.TestJsonSerDe.testRobustRead (batchId=215) org.apache.hive.hcatalog.mapreduce.TestHCatDynamicPartitioned.testHCatDynamicPartitionedTableMultipleTask[6] (batchId=211) org.apache.hive.hcatalog.mapreduce.TestHCatDynamicPartitioned.testHCatDynamicPartitionedTable[6] (batchId=211) org.apache.hive.hcatalog.mapreduce.TestHCatExternalDynamicPartitioned.testHCatDynamicPartitionedTableMultipleTask[6] (batchId=213) org.apache.hive.hcatalog.mapreduce.TestHCatExternalDynamicPartitioned.testHCatDynamicPartitionedTable[6] (batchId=213) org.apache.hive.hcatalog.mapreduce.TestHCatExternalDynamicPartitioned.testHCatExternalDynamicCustomLocation[6] (batchId=213) org.apache.hive.hcatalog.mapreduce.TestHCatExternalNonPartitioned.testHCatNonPartitionedTable[6] (batchId=214) org.apache.hive.hcatalog.mapreduce.TestHCatExternalPartitioned.testHCatPartitionedTable[6] (batchId=210) org.apache.hive.hcatalog.mapreduce.TestHCatMutableDynamicPartitioned.testHCatDynamicPartitionedTableMultipleTask[6] (batchId=208) org.apache.hive.hcatalog.mapreduce.TestHCatMutableDynamicPartitioned.testHCatDynamicPartitionedTable[6] (batchId=208) org.apache.hive.hcatalog.mapreduce.TestHCatMutableNonPartitioned.testHCatNonPartitionedTable[6] (batchId=214) org.apache.hive.hcatalog.mapreduce.TestHCatMutablePartitioned.testHCatPartitionedTable[6] (batchId=212) org.apache.hive.hcatalog.mapreduce.TestHCatNonPartitioned.testHCatNonPartitionedTable[6] (batchId=209) org.apache.hive.hcatalog.mapreduce.TestHCatPartitioned.testHCatPartitionedTable[6] (batchId=209) org.apache.hive.hcatalog.pig.TestHCatLoaderComplexSchema.testMapWithComplexData[6] (batchId=207) org.apache.hive.hcatalog.pig.TestHCatLoaderComplexSchema.testSyntheticComplexSchema[6] (batchId=207) org.apache.hive.hcatalog.pig.TestHCatLoaderComplexSchema.testTupleInBagInTupleInBag[6] (batchId=207) org.apache.hive.hcatalog.pig.TestHCatStorer.testBagNStruct[6] (batchId=206) org.apache.hive.hcatalog.pig.TestHCatStorer.testDateCharTypes[6] (batchId=206) org.apache.hive.hcatalog.pig.TestHCatStorer.testDynamicPartitioningMultiPartColsInDataNoSpec[6] (batchId=206) org.apache.hive.hcatalog.pig.TestHCatStorer.testDynamicPartitioningMultiPartColsInDataPartialSpec[6] (batchId=206) org.apache.hive.hcatalog.pig.TestHCatStorer.testMultiPartColsInData[6] (batchId=206) org.apache.hive.hcatalog.pig.TestHCatStorer.testPartColsInData[6] (batchId=206) org.apache.hive.hcatalog.pig.TestHCatStorer.testStoreFuncAllSimpleTypes[6] (batchId=206) org.apache.hive.hcatalog.pig.TestHCatStorer.testStoreFuncSimple[6] (batchId=206) org.apache.hive.hcatalog.pig.TestHCatStorer.testStoreInPartiitonedTbl[6] (batchId=206) org.apache.hive.hcatalog.pig.TestHCatStorer.testStoreMultiTables[6] (batchId=206) org.apache.hive.hcatalog.pig.TestHCatStorer.testStoreWithNoCtorArgs[6] (batchId=206) org.apache.hive.hcatalog.pig.TestHCatStorer.testStoreWithNoSchema[6] (batchId=206) org.apache.hive.hcatalog.pig.TestHCatStorer.testWriteChar[6] (batchId=206) org.apache.hive.hcatalog.pig.TestHCatStorer.testWriteDate2[6] (batchId=206) org.apache.hive.hcatalog.pig.TestHCatStorer.testWriteDate3[6] (batchId=206) org.apache.hive.hcatalog.pig.TestHCatStorer.testWriteDate[6] (batchId=206) org.apache.hive.hcatalog.pig.TestHCatStorer.testWriteDecimalXY[6] (batchId=206) org.apache.hive.hcatalog.pig.TestHCatStorer.testWriteDecimalX[6] (batchId=206) org.apache.hive.hcatalog.pig.TestHCatStorer.testWriteDecimal[6] (batchId=206) org.apache.hive.hcatalog.pig.TestHCatStorer.testWriteSmallint[6] (batchId=206) org.apache.hive.hcatalog.pig.TestHCatStorer.testWriteTimestamp[6] (batchId=206) org.apache.hive.hcatalog.pig.TestHCatStorer.testWriteTinyint[6] (batchId=206) org.apache.hive.hcatalog.pig.TestHCatStorer.testWriteVarchar[6] (batchId=206) org.apache.hive.hcatalog.pig.TestHCatStorerMulti.testStoreBasicTable[6] (batchId=207) org.apache.hive.hcatalog.pig.TestHCatStorerMulti.testStorePartitionedTable[6] (batchId=207) org.apache.hive.hcatalog.pig.TestHCatStorerMulti.testStoreTableMulti[6] (batchId=207) {noformat} Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/16067/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/16067/console Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-16067/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.YetusPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase Tests exited with: TestsFailedException: 49 tests failed {noformat} This message is automatically generated. ATTACHMENT ID: 12958661 - PreCommit-HIVE-Build > JSON SerDe Deserialize Re-Write > ------------------------------- > > Key: HIVE-21240 > URL: https://issues.apache.org/jira/browse/HIVE-21240 > Project: Hive > Issue Type: Improvement > Components: Serializers/Deserializers > Affects Versions: 4.0.0, 3.1.1 > Reporter: BELUGA BEHR > Assignee: BELUGA BEHR > Priority: Major > Labels: pull-request-available > Fix For: 4.0.0 > > Attachments: HIVE-21240.1.patch, HIVE-21240.1.patch, > HIVE-21240.2.patch, HIVE-21240.3.patch, HIVE-21240.4.patch, HIVE-21240.5.patch > > Time Spent: 10m > Remaining Estimate: 0h > > The JSON SerDe has a few issues, I will link them to this JIRA. > * Use Jackson Tree parser instead of manually parsing > * Added support for base-64 encoded data (the expected format when using JSON) > * Added support to skip blank lines (returns all columns as null values) > * Current JSON parser accepts, but does not apply, custom timestamp formats > in most cases > * Added some unit tests > * Added cache for column-name to column-index searches, currently O\(n\) for > each row processed, for each column in the row -- This message was sent by Atlassian JIRA (v7.6.3#76005)