[ https://issues.apache.org/jira/browse/HIVE-21246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16766352#comment-16766352 ]
Hive QA commented on HIVE-21246: -------------------------------- Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12958394/HIVE-21246.1.patch {color:red}ERROR:{color} -1 due to no test(s) being added or modified. {color:red}ERROR:{color} -1 due to 2 failed/errored test(s), 15783 tests executed *Failed tests:* {noformat} org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[timestamptz_2] (batchId=86) org.apache.hive.service.cli.thrift.TestThriftCLIServiceWithHttp.org.apache.hive.service.cli.thrift.TestThriftCLIServiceWithHttp (batchId=259) {noformat} Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/16037/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/16037/console Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-16037/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.YetusPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase Tests exited with: TestsFailedException: 2 tests failed {noformat} This message is automatically generated. ATTACHMENT ID: 12958394 - PreCommit-HIVE-Build > Un-bury DelimitedJSONSerDe from PlanUtils.java > ---------------------------------------------- > > Key: HIVE-21246 > URL: https://issues.apache.org/jira/browse/HIVE-21246 > Project: Hive > Issue Type: Improvement > Reporter: BELUGA BEHR > Assignee: BELUGA BEHR > Priority: Minor > Attachments: HIVE-21246.1.patch, HIVE-21246.1.patch > > > Ultimately, I'd like to get rid of > {{org.apache.hadoop.hive.serde2.DelimitedJSONSerDe}}, but for now, trying to > make it easier to get rid of later. It's currently buried in > {{PlanUtils.java}}. > A SerDe and a boolean flag gets passed into these methods. If the flag is > set to true, the specified SerDe is overwritten and assigned to > {{DelimitedJSONSerDe}}. This is not documented anywhere and it's a weird > thing to do, just pass in the required SerDe from the start instead of > sending the wrong SerDe and a flag to overwrite it. -- This message was sent by Atlassian JIRA (v7.6.3#76005)