[ https://issues.apache.org/jira/browse/HIVE-21149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16749884#comment-16749884 ]
Hive QA commented on HIVE-21149: -------------------------------- Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12955934/HIVE-21149.02.patch {color:red}ERROR:{color} -1 due to build exiting with an error Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/15753/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/15753/console Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-15753/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Tests exited with: NonZeroExitCodeException Command 'bash /data/hiveptest/working/scratch/source-prep.sh' failed with exit status 1 and output '+ date '+%Y-%m-%d %T.%3N' 2019-01-23 12:14:24.391 + [[ -n /usr/lib/jvm/java-8-openjdk-amd64 ]] + export JAVA_HOME=/usr/lib/jvm/java-8-openjdk-amd64 + JAVA_HOME=/usr/lib/jvm/java-8-openjdk-amd64 + export PATH=/usr/lib/jvm/java-8-openjdk-amd64/bin/:/usr/local/bin:/usr/bin:/bin:/usr/local/games:/usr/games + PATH=/usr/lib/jvm/java-8-openjdk-amd64/bin/:/usr/local/bin:/usr/bin:/bin:/usr/local/games:/usr/games + export 'ANT_OPTS=-Xmx1g -XX:MaxPermSize=256m ' + ANT_OPTS='-Xmx1g -XX:MaxPermSize=256m ' + export 'MAVEN_OPTS=-Xmx1g ' + MAVEN_OPTS='-Xmx1g ' + cd /data/hiveptest/working/ + tee /data/hiveptest/logs/PreCommit-HIVE-Build-15753/source-prep.txt + [[ false == \t\r\u\e ]] + mkdir -p maven ivy + [[ git = \s\v\n ]] + [[ git = \g\i\t ]] + [[ -z master ]] + [[ -d apache-github-source-source ]] + [[ ! -d apache-github-source-source/.git ]] + [[ ! -d apache-github-source-source ]] + date '+%Y-%m-%d %T.%3N' 2019-01-23 12:14:24.394 + cd apache-github-source-source + git fetch origin + git reset --hard HEAD HEAD is now at 2ffca04 HIVE-21078: Replicate column and table level statistics for unpartitioned Hive tables (Ashutosh Bapat, reviewed by Sankar Hariappan) + git clean -f -d Removing standalone-metastore/metastore-server/src/gen/ + git checkout master Already on 'master' Your branch is up-to-date with 'origin/master'. + git reset --hard origin/master HEAD is now at 2ffca04 HIVE-21078: Replicate column and table level statistics for unpartitioned Hive tables (Ashutosh Bapat, reviewed by Sankar Hariappan) + git merge --ff-only origin/master Already up-to-date. + date '+%Y-%m-%d %T.%3N' 2019-01-23 12:14:25.508 + rm -rf ../yetus_PreCommit-HIVE-Build-15753 + mkdir ../yetus_PreCommit-HIVE-Build-15753 + git gc + cp -R . ../yetus_PreCommit-HIVE-Build-15753 + mkdir /data/hiveptest/logs/PreCommit-HIVE-Build-15753/yetus + patchCommandPath=/data/hiveptest/working/scratch/smart-apply-patch.sh + patchFilePath=/data/hiveptest/working/scratch/build.patch + [[ -f /data/hiveptest/working/scratch/build.patch ]] + chmod +x /data/hiveptest/working/scratch/smart-apply-patch.sh + /data/hiveptest/working/scratch/smart-apply-patch.sh /data/hiveptest/working/scratch/build.patch error: a/bin/ext/llap.sh: does not exist in index error: a/llap-server/src/java/org/apache/hadoop/hive/llap/cli/LlapOptionsProcessor.java: does not exist in index error: a/llap-server/src/java/org/apache/hadoop/hive/llap/cli/LlapServiceDriver.java: does not exist in index error: a/llap-server/src/java/org/apache/hadoop/hive/llap/cli/LlapSliderUtils.java: does not exist in index error: patch failed: llap-server/src/java/org/apache/hadoop/hive/llap/cli/LlapServiceDriver.java:1 error: llap-server/src/java/org/apache/hadoop/hive/llap/cli/LlapServiceDriver.java: patch does not apply error: ext/llap.sh: does not exist in index error: src/java/org/apache/hadoop/hive/llap/cli/LlapOptionsProcessor.java: does not exist in index error: src/java/org/apache/hadoop/hive/llap/cli/LlapServiceDriver.java: does not exist in index error: src/java/org/apache/hadoop/hive/llap/cli/LlapSliderUtils.java: does not exist in index The patch does not appear to apply with p0, p1, or p2 + result=1 + '[' 1 -ne 0 ']' + rm -rf yetus_PreCommit-HIVE-Build-15753 + exit 1 ' {noformat} This message is automatically generated. ATTACHMENT ID: 12955934 - PreCommit-HIVE-Build > Refactor LlapServiceDriver > -------------------------- > > Key: HIVE-21149 > URL: https://issues.apache.org/jira/browse/HIVE-21149 > Project: Hive > Issue Type: Improvement > Components: Hive > Affects Versions: 3.1.2 > Reporter: Miklos Gergely > Assignee: Miklos Gergely > Priority: Major > Fix For: 3.1.2 > > Attachments: HIVE-21149.01.patch, HIVE-21149.02.patch > > > LlapServiceDriver is one monolith class doing several things, needs to be > refactor in order to make it clearer how it works. -- This message was sent by Atlassian JIRA (v7.6.3#76005)