[
https://issues.apache.org/jira/browse/HIVE-20255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16736963#comment-16736963
]
Peter Vary commented on HIVE-20255:
-----------------------------------
[~belugabehr]: Thanks very much for all your contributions and hard work you
put into Hive!
I consider the "Commit only on green run" policy a good one, and even if I
would not consider it good, I would adhere to it since this was the last
decision by the community. I think it is very important to work on cleaning up
the flaky/failing tests which are making life of all of us miserable, so if
there are so many randomly failing tests please consider helping in cleaning
them up. If you think otherwise feel free to bring it up on the dev list so we
can change the policy if the majority thinks it is a good decision.
Thanks again for all of your work! I really appreciate it!
Peter
> Review LevelOrderWalker.java
> ----------------------------
>
> Key: HIVE-20255
> URL: https://issues.apache.org/jira/browse/HIVE-20255
> Project: Hive
> Issue Type: Improvement
> Components: Query Planning
> Affects Versions: 3.0.0, 4.0.0
> Reporter: BELUGA BEHR
> Assignee: BELUGA BEHR
> Priority: Minor
> Attachments: HIVE-20255.1.patch, HIVE-20255.2.patch,
> HIVE-20255.3.patch, HIVE-20255.4.patch, HIVE-20255.5.patch,
> HIVE-20255.6.patch, HIVE-20255.7.patch, HIVE-20255.8.patch
>
>
> https://github.com/apache/hive/blob/6d890faf22fd1ede3658a5eed097476eab3c67e9/ql/src/java/org/apache/hadoop/hive/ql/lib/LevelOrderWalker.java
> * Make code more concise
> * Fix some check style issues
> {code}
> if (toWalk.get(index).getChildren() != null) {
> for(Node child : toWalk.get(index).getChildren()) {
> {code}
> Actually, the underlying implementation of {{getChildren()}} has to do some
> real work, so do not throw away the work after checking for null. Simply
> call once and store the results.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
