[ https://issues.apache.org/jira/browse/HIVE-20523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16725988#comment-16725988 ]
Hive QA commented on HIVE-20523: -------------------------------- Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12952530/HIVE-20523.7.patch {color:red}ERROR:{color} -1 due to build exiting with an error Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/15404/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/15404/console Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-15404/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Tests exited with: NonZeroExitCodeException Command 'bash /data/hiveptest/working/scratch/source-prep.sh' failed with exit status 1 and output '+ date '+%Y-%m-%d %T.%3N' 2018-12-20 16:14:40.671 + [[ -n /usr/lib/jvm/java-8-openjdk-amd64 ]] + export JAVA_HOME=/usr/lib/jvm/java-8-openjdk-amd64 + JAVA_HOME=/usr/lib/jvm/java-8-openjdk-amd64 + export PATH=/usr/lib/jvm/java-8-openjdk-amd64/bin/:/usr/local/bin:/usr/bin:/bin:/usr/local/games:/usr/games + PATH=/usr/lib/jvm/java-8-openjdk-amd64/bin/:/usr/local/bin:/usr/bin:/bin:/usr/local/games:/usr/games + export 'ANT_OPTS=-Xmx1g -XX:MaxPermSize=256m ' + ANT_OPTS='-Xmx1g -XX:MaxPermSize=256m ' + export 'MAVEN_OPTS=-Xmx1g ' + MAVEN_OPTS='-Xmx1g ' + cd /data/hiveptest/working/ + tee /data/hiveptest/logs/PreCommit-HIVE-Build-15404/source-prep.txt + [[ false == \t\r\u\e ]] + mkdir -p maven ivy + [[ git = \s\v\n ]] + [[ git = \g\i\t ]] + [[ -z master ]] + [[ -d apache-github-source-source ]] + [[ ! -d apache-github-source-source/.git ]] + [[ ! -d apache-github-source-source ]] + date '+%Y-%m-%d %T.%3N' 2018-12-20 16:14:40.674 + cd apache-github-source-source + git fetch origin + git reset --hard HEAD HEAD is now at 1020be0 HIVE-20943: Handle Compactor transaction abort properly (Eugene Koifman, reviewed by Vaibhav Gumashta) + git clean -f -d Removing standalone-metastore/metastore-server/src/gen/ Removing standalone-metastore/src/gen/ + git checkout master Already on 'master' Your branch is up-to-date with 'origin/master'. + git reset --hard origin/master HEAD is now at 1020be0 HIVE-20943: Handle Compactor transaction abort properly (Eugene Koifman, reviewed by Vaibhav Gumashta) + git merge --ff-only origin/master Already up-to-date. + date '+%Y-%m-%d %T.%3N' 2018-12-20 16:14:41.758 + rm -rf ../yetus_PreCommit-HIVE-Build-15404 + mkdir ../yetus_PreCommit-HIVE-Build-15404 + git gc + cp -R . ../yetus_PreCommit-HIVE-Build-15404 + mkdir /data/hiveptest/logs/PreCommit-HIVE-Build-15404/yetus + patchCommandPath=/data/hiveptest/working/scratch/smart-apply-patch.sh + patchFilePath=/data/hiveptest/working/scratch/build.patch + [[ -f /data/hiveptest/working/scratch/build.patch ]] + chmod +x /data/hiveptest/working/scratch/smart-apply-patch.sh + /data/hiveptest/working/scratch/smart-apply-patch.sh /data/hiveptest/working/scratch/build.patch error: a/ql/src/java/org/apache/hadoop/hive/ql/io/parquet/serde/ParquetHiveSerDe.java: does not exist in index error: a/ql/src/test/org/apache/hadoop/hive/ql/io/parquet/TestParquetSerDe.java: does not exist in index error: a/ql/src/test/results/clientpositive/llap/vector_partitioned_date_time.q.out: does not exist in index error: a/ql/src/test/results/clientpositive/nested_column_pruning.q.out: does not exist in index error: a/ql/src/test/results/clientpositive/parquet_analyze.q.out: does not exist in index error: a/ql/src/test/results/clientpositive/parquet_complex_types_vectorization.q.out: does not exist in index error: a/ql/src/test/results/clientpositive/parquet_join.q.out: does not exist in index error: a/ql/src/test/results/clientpositive/parquet_map_type_vectorization.q.out: does not exist in index error: a/ql/src/test/results/clientpositive/parquet_no_row_serde.q.out: does not exist in index error: a/ql/src/test/results/clientpositive/parquet_struct_type_vectorization.q.out: does not exist in index error: a/ql/src/test/results/clientpositive/parquet_types_non_dictionary_encoding_vectorization.q.out: does not exist in index error: a/ql/src/test/results/clientpositive/parquet_types_vectorization.q.out: does not exist in index error: a/ql/src/test/results/clientpositive/parquet_vectorization_decimal_date.q.out: does not exist in index error: a/ql/src/test/results/clientpositive/parquet_vectorization_part_project.q.out: does not exist in index error: a/ql/src/test/results/clientpositive/spark/spark_dynamic_partition_pruning.q.out: does not exist in index error: a/ql/src/test/results/clientpositive/spark/vectorization_input_format_excludes.q.out: does not exist in index error: a/ql/src/test/results/clientpositive/vectorization_numeric_overflows.q.out: does not exist in index error: a/ql/src/test/results/clientpositive/vectorization_parquet_projection.q.out: does not exist in index error: a/ql/src/test/results/clientpositive/vectorized_parquet_types.q.out: does not exist in index error: patch failed: ql/src/test/results/clientpositive/llap/vector_partitioned_date_time.q.out:4323 Falling back to three-way merge... Applied patch to 'ql/src/test/results/clientpositive/llap/vector_partitioned_date_time.q.out' with conflicts. error: patch failed: ql/src/test/results/clientpositive/nested_column_pruning.q.out:393 Falling back to three-way merge... Applied patch to 'ql/src/test/results/clientpositive/nested_column_pruning.q.out' with conflicts. error: patch failed: ql/src/test/results/clientpositive/parquet_analyze.q.out:93 Falling back to three-way merge... Applied patch to 'ql/src/test/results/clientpositive/parquet_analyze.q.out' with conflicts. error: patch failed: ql/src/test/results/clientpositive/parquet_complex_types_vectorization.q.out:184 Falling back to three-way merge... Applied patch to 'ql/src/test/results/clientpositive/parquet_complex_types_vectorization.q.out' with conflicts. error: patch failed: ql/src/test/results/clientpositive/parquet_join.q.out:75 Falling back to three-way merge... Applied patch to 'ql/src/test/results/clientpositive/parquet_join.q.out' with conflicts. error: patch failed: ql/src/test/results/clientpositive/parquet_map_type_vectorization.q.out:125 Falling back to three-way merge... Applied patch to 'ql/src/test/results/clientpositive/parquet_map_type_vectorization.q.out' with conflicts. error: patch failed: ql/src/test/results/clientpositive/parquet_struct_type_vectorization.q.out:208 Falling back to three-way merge... Applied patch to 'ql/src/test/results/clientpositive/parquet_struct_type_vectorization.q.out' with conflicts. error: patch failed: ql/src/test/results/clientpositive/parquet_vectorization_decimal_date.q.out:30 Falling back to three-way merge... Applied patch to 'ql/src/test/results/clientpositive/parquet_vectorization_decimal_date.q.out' with conflicts. error: patch failed: ql/src/test/results/clientpositive/spark/spark_dynamic_partition_pruning.q.out:6408 Falling back to three-way merge... Applied patch to 'ql/src/test/results/clientpositive/spark/spark_dynamic_partition_pruning.q.out' cleanly. error: patch failed: ql/src/test/results/clientpositive/spark/vectorization_input_format_excludes.q.out:73 Falling back to three-way merge... Applied patch to 'ql/src/test/results/clientpositive/spark/vectorization_input_format_excludes.q.out' with conflicts. error: patch failed: ql/src/test/results/clientpositive/vectorization_numeric_overflows.q.out:123 Falling back to three-way merge... Applied patch to 'ql/src/test/results/clientpositive/vectorization_numeric_overflows.q.out' with conflicts. error: patch failed: ql/src/test/results/clientpositive/vectorization_parquet_projection.q.out:466 Falling back to three-way merge... Applied patch to 'ql/src/test/results/clientpositive/vectorization_parquet_projection.q.out' with conflicts. Going to apply patch with: git apply -p1 /data/hiveptest/working/scratch/build.patch:1578: trailing whitespace. rawDataSize 52765 /data/hiveptest/working/scratch/build.patch:278: new blank line at EOF. + /data/hiveptest/working/scratch/build.patch:452: new blank line at EOF. + error: patch failed: ql/src/test/results/clientpositive/llap/vector_partitioned_date_time.q.out:4323 Falling back to three-way merge... Applied patch to 'ql/src/test/results/clientpositive/llap/vector_partitioned_date_time.q.out' with conflicts. error: patch failed: ql/src/test/results/clientpositive/nested_column_pruning.q.out:393 Falling back to three-way merge... Applied patch to 'ql/src/test/results/clientpositive/nested_column_pruning.q.out' with conflicts. error: patch failed: ql/src/test/results/clientpositive/parquet_analyze.q.out:93 Falling back to three-way merge... Applied patch to 'ql/src/test/results/clientpositive/parquet_analyze.q.out' with conflicts. error: patch failed: ql/src/test/results/clientpositive/parquet_complex_types_vectorization.q.out:184 Falling back to three-way merge... Applied patch to 'ql/src/test/results/clientpositive/parquet_complex_types_vectorization.q.out' with conflicts. error: patch failed: ql/src/test/results/clientpositive/parquet_join.q.out:75 Falling back to three-way merge... Applied patch to 'ql/src/test/results/clientpositive/parquet_join.q.out' with conflicts. error: patch failed: ql/src/test/results/clientpositive/parquet_map_type_vectorization.q.out:125 Falling back to three-way merge... Applied patch to 'ql/src/test/results/clientpositive/parquet_map_type_vectorization.q.out' with conflicts. error: patch failed: ql/src/test/results/clientpositive/parquet_struct_type_vectorization.q.out:208 Falling back to three-way merge... Applied patch to 'ql/src/test/results/clientpositive/parquet_struct_type_vectorization.q.out' with conflicts. error: patch failed: ql/src/test/results/clientpositive/parquet_vectorization_decimal_date.q.out:30 Falling back to three-way merge... Applied patch to 'ql/src/test/results/clientpositive/parquet_vectorization_decimal_date.q.out' with conflicts. error: patch failed: ql/src/test/results/clientpositive/spark/spark_dynamic_partition_pruning.q.out:6408 Falling back to three-way merge... Applied patch to 'ql/src/test/results/clientpositive/spark/spark_dynamic_partition_pruning.q.out' cleanly. error: patch failed: ql/src/test/results/clientpositive/spark/vectorization_input_format_excludes.q.out:73 Falling back to three-way merge... Applied patch to 'ql/src/test/results/clientpositive/spark/vectorization_input_format_excludes.q.out' with conflicts. error: patch failed: ql/src/test/results/clientpositive/vectorization_numeric_overflows.q.out:123 Falling back to three-way merge... Applied patch to 'ql/src/test/results/clientpositive/vectorization_numeric_overflows.q.out' with conflicts. error: patch failed: ql/src/test/results/clientpositive/vectorization_parquet_projection.q.out:466 Falling back to three-way merge... Applied patch to 'ql/src/test/results/clientpositive/vectorization_parquet_projection.q.out' with conflicts. U ql/src/test/results/clientpositive/llap/vector_partitioned_date_time.q.out U ql/src/test/results/clientpositive/nested_column_pruning.q.out U ql/src/test/results/clientpositive/parquet_analyze.q.out U ql/src/test/results/clientpositive/parquet_complex_types_vectorization.q.out U ql/src/test/results/clientpositive/parquet_join.q.out U ql/src/test/results/clientpositive/parquet_map_type_vectorization.q.out U ql/src/test/results/clientpositive/parquet_struct_type_vectorization.q.out U ql/src/test/results/clientpositive/parquet_vectorization_decimal_date.q.out U ql/src/test/results/clientpositive/spark/vectorization_input_format_excludes.q.out U ql/src/test/results/clientpositive/vectorization_numeric_overflows.q.out U ql/src/test/results/clientpositive/vectorization_parquet_projection.q.out warning: 3 lines add whitespace errors. + result=1 + '[' 1 -ne 0 ']' + rm -rf yetus_PreCommit-HIVE-Build-15404 + exit 1 ' {noformat} This message is automatically generated. ATTACHMENT ID: 12952530 - PreCommit-HIVE-Build > Improve table statistics for Parquet format > ------------------------------------------- > > Key: HIVE-20523 > URL: https://issues.apache.org/jira/browse/HIVE-20523 > Project: Hive > Issue Type: Improvement > Components: Physical Optimizer > Reporter: George Pachitariu > Assignee: George Pachitariu > Priority: Minor > Attachments: HIVE-20523.1.patch, HIVE-20523.2.patch, > HIVE-20523.3.patch, HIVE-20523.4.patch, HIVE-20523.5.patch, > HIVE-20523.6.patch, HIVE-20523.7.patch, HIVE-20523.patch > > > Right now, in the table basic statistics, the *raw data size* for a row with > any data type in the Parquet format is 1. This is an underestimated value > when columns are complex data structures, like arrays. > Having tables with underestimated raw data size makes Hive assign less > containers (mappers/reducers) to it, making the overall query slower. > Heavy underestimation also makes Hive choose MapJoin instead of the > ShuffleJoin that can fail with OOM errors. > In this patch, I compute the columns data size better, taking into account > complex structures. I followed the Writer implementation for the ORC format. -- This message was sent by Atlassian JIRA (v7.6.3#76005)