[
https://issues.apache.org/jira/browse/HIVE-17935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16718413#comment-16718413
]
Hive QA commented on HIVE-17935:
--------------------------------
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12908851/HIVE-17935.8.patch
{color:red}ERROR:{color} -1 due to build exiting with an error
Test results:
https://builds.apache.org/job/PreCommit-HIVE-Build/15270/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/15270/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-15270/
Messages:
{noformat}
**** This message was trimmed, see log for full details ****
+ JAVA_HOME=/usr/lib/jvm/java-8-openjdk-amd64
+ export
PATH=/usr/lib/jvm/java-8-openjdk-amd64/bin/:/usr/local/bin:/usr/bin:/bin:/usr/local/games:/usr/games
+
PATH=/usr/lib/jvm/java-8-openjdk-amd64/bin/:/usr/local/bin:/usr/bin:/bin:/usr/local/games:/usr/games
+ export 'ANT_OPTS=-Xmx1g -XX:MaxPermSize=256m '
+ ANT_OPTS='-Xmx1g -XX:MaxPermSize=256m '
+ export 'MAVEN_OPTS=-Xmx1g '
+ MAVEN_OPTS='-Xmx1g '
+ cd /data/hiveptest/working/
+ tee /data/hiveptest/logs/PreCommit-HIVE-Build-15270/source-prep.txt
+ [[ false == \t\r\u\e ]]
+ mkdir -p maven ivy
+ [[ git = \s\v\n ]]
+ [[ git = \g\i\t ]]
+ [[ -z master ]]
+ [[ -d apache-github-source-source ]]
+ [[ ! -d apache-github-source-source/.git ]]
+ [[ ! -d apache-github-source-source ]]
+ date '+%Y-%m-%d %T.%3N'
2018-12-12 02:54:29.157
+ cd apache-github-source-source
+ git fetch origin
+ git reset --hard HEAD
HEAD is now at b650083 HIVE-16100: Dynamic Sorted Partition optimizer loses
sibling operators (Vineet Garg, Gopal V reviewed by Ashutosh Chauhan)
+ git clean -f -d
+ git checkout master
Already on 'master'
Your branch is up-to-date with 'origin/master'.
+ git reset --hard origin/master
HEAD is now at b650083 HIVE-16100: Dynamic Sorted Partition optimizer loses
sibling operators (Vineet Garg, Gopal V reviewed by Ashutosh Chauhan)
+ git merge --ff-only origin/master
Already up-to-date.
+ date '+%Y-%m-%d %T.%3N'
2018-12-12 02:54:29.717
+ rm -rf ../yetus_PreCommit-HIVE-Build-15270
+ mkdir ../yetus_PreCommit-HIVE-Build-15270
+ git gc
+ cp -R . ../yetus_PreCommit-HIVE-Build-15270
+ mkdir /data/hiveptest/logs/PreCommit-HIVE-Build-15270/yetus
+ patchCommandPath=/data/hiveptest/working/scratch/smart-apply-patch.sh
+ patchFilePath=/data/hiveptest/working/scratch/build.patch
+ [[ -f /data/hiveptest/working/scratch/build.patch ]]
+ chmod +x /data/hiveptest/working/scratch/smart-apply-patch.sh
+ /data/hiveptest/working/scratch/smart-apply-patch.sh
/data/hiveptest/working/scratch/build.patch
error: patch failed:
ql/src/test/results/clientpositive/spark/load_dyn_part1.q.out:61
Falling back to three-way merge...
Applied patch to
'ql/src/test/results/clientpositive/spark/load_dyn_part1.q.out' with conflicts.
error: patch failed:
ql/src/test/results/clientpositive/spark/load_dyn_part10.q.out:49
Falling back to three-way merge...
Applied patch to
'ql/src/test/results/clientpositive/spark/load_dyn_part10.q.out' with conflicts.
error: patch failed:
ql/src/test/results/clientpositive/spark/load_dyn_part14.q.out:79
Falling back to three-way merge...
Applied patch to
'ql/src/test/results/clientpositive/spark/load_dyn_part14.q.out' with conflicts.
error: patch failed:
ql/src/test/results/clientpositive/spark/load_dyn_part3.q.out:47
Falling back to three-way merge...
Applied patch to
'ql/src/test/results/clientpositive/spark/load_dyn_part3.q.out' with conflicts.
error: patch failed:
ql/src/test/results/clientpositive/spark/load_dyn_part4.q.out:57
Falling back to three-way merge...
Applied patch to
'ql/src/test/results/clientpositive/spark/load_dyn_part4.q.out' with conflicts.
error: patch failed:
ql/src/test/results/clientpositive/spark/load_dyn_part5.q.out:34
Falling back to three-way merge...
Applied patch to
'ql/src/test/results/clientpositive/spark/load_dyn_part5.q.out' with conflicts.
error: patch failed:
ql/src/test/results/clientpositive/spark/load_dyn_part8.q.out:53
Falling back to three-way merge...
Applied patch to
'ql/src/test/results/clientpositive/spark/load_dyn_part8.q.out' with conflicts.
error: patch failed:
ql/src/test/results/clientpositive/spark/load_dyn_part9.q.out:49
Falling back to three-way merge...
Applied patch to
'ql/src/test/results/clientpositive/spark/load_dyn_part9.q.out' with conflicts.
error: patch failed:
ql/src/test/results/clientpositive/spark/orc_merge2.q.out:37
Falling back to three-way merge...
Applied patch to 'ql/src/test/results/clientpositive/spark/orc_merge2.q.out'
with conflicts.
error: patch failed: ql/src/test/results/clientpositive/spark/stats2.q.out:19
Falling back to three-way merge...
Applied patch to 'ql/src/test/results/clientpositive/spark/stats2.q.out' with
conflicts.
error: patch failed: ql/src/test/results/clientpositive/spark/union14.q.out:122
Falling back to three-way merge...
Applied patch to 'ql/src/test/results/clientpositive/spark/union14.q.out' with
conflicts.
error: patch failed: ql/src/test/results/clientpositive/spark/union15.q.out:147
Falling back to three-way merge...
Applied patch to 'ql/src/test/results/clientpositive/spark/union15.q.out' with
conflicts.
error: patch failed: ql/src/test/results/clientpositive/spark/union7.q.out:118
Falling back to three-way merge...
Applied patch to 'ql/src/test/results/clientpositive/spark/union7.q.out' with
conflicts.
error: patch failed: ql/src/test/results/clientpositive/spark/union_null.q.out:6
Falling back to three-way merge...
Applied patch to 'ql/src/test/results/clientpositive/spark/union_null.q.out'
cleanly.
error: patch failed:
ql/src/test/results/clientpositive/spark/union_remove_15.q.out:85
Falling back to three-way merge...
Applied patch to
'ql/src/test/results/clientpositive/spark/union_remove_15.q.out' with conflicts.
error: patch failed:
ql/src/test/results/clientpositive/spark/union_remove_16.q.out:90
Falling back to three-way merge...
Applied patch to
'ql/src/test/results/clientpositive/spark/union_remove_16.q.out' with conflicts.
error: patch failed:
ql/src/test/results/clientpositive/spark/union_remove_17.q.out:47
Falling back to three-way merge...
Applied patch to
'ql/src/test/results/clientpositive/spark/union_remove_17.q.out' with conflicts.
error: patch failed:
ql/src/test/results/clientpositive/spark/union_remove_18.q.out:85
Falling back to three-way merge...
Applied patch to
'ql/src/test/results/clientpositive/spark/union_remove_18.q.out' with conflicts.
error: patch failed:
ql/src/test/results/clientpositive/spark/union_remove_25.q.out:437
Falling back to three-way merge...
Applied patch to
'ql/src/test/results/clientpositive/spark/union_remove_25.q.out' with conflicts.
error: patch failed:
ql/src/test/results/clientpositive/spark/union_view.q.out:492
Falling back to three-way merge...
Applied patch to 'ql/src/test/results/clientpositive/spark/union_view.q.out'
with conflicts.
Going to apply patch with: git apply -p0
/data/hiveptest/working/scratch/build.patch:86: trailing whitespace.
Map 4
/data/hiveptest/working/scratch/build.patch:107: trailing whitespace.
Map 5
/data/hiveptest/working/scratch/build.patch:132: trailing whitespace.
Reducer 2
/data/hiveptest/working/scratch/build.patch:147: trailing whitespace.
Reducer 3
/data/hiveptest/working/scratch/build.patch:195: trailing whitespace.
Reducer 2
error: patch failed:
ql/src/test/results/clientpositive/spark/load_dyn_part1.q.out:61
Falling back to three-way merge...
Applied patch to
'ql/src/test/results/clientpositive/spark/load_dyn_part1.q.out' with conflicts.
error: patch failed:
ql/src/test/results/clientpositive/spark/load_dyn_part10.q.out:49
Falling back to three-way merge...
Applied patch to
'ql/src/test/results/clientpositive/spark/load_dyn_part10.q.out' with conflicts.
error: patch failed:
ql/src/test/results/clientpositive/spark/load_dyn_part14.q.out:79
Falling back to three-way merge...
Applied patch to
'ql/src/test/results/clientpositive/spark/load_dyn_part14.q.out' with conflicts.
error: patch failed:
ql/src/test/results/clientpositive/spark/load_dyn_part3.q.out:47
Falling back to three-way merge...
Applied patch to
'ql/src/test/results/clientpositive/spark/load_dyn_part3.q.out' with conflicts.
error: patch failed:
ql/src/test/results/clientpositive/spark/load_dyn_part4.q.out:57
Falling back to three-way merge...
Applied patch to
'ql/src/test/results/clientpositive/spark/load_dyn_part4.q.out' with conflicts.
error: patch failed:
ql/src/test/results/clientpositive/spark/load_dyn_part5.q.out:34
Falling back to three-way merge...
Applied patch to
'ql/src/test/results/clientpositive/spark/load_dyn_part5.q.out' with conflicts.
error: patch failed:
ql/src/test/results/clientpositive/spark/load_dyn_part8.q.out:53
Falling back to three-way merge...
Applied patch to
'ql/src/test/results/clientpositive/spark/load_dyn_part8.q.out' with conflicts.
error: patch failed:
ql/src/test/results/clientpositive/spark/load_dyn_part9.q.out:49
Falling back to three-way merge...
Applied patch to
'ql/src/test/results/clientpositive/spark/load_dyn_part9.q.out' with conflicts.
error: patch failed:
ql/src/test/results/clientpositive/spark/orc_merge2.q.out:37
Falling back to three-way merge...
Applied patch to 'ql/src/test/results/clientpositive/spark/orc_merge2.q.out'
with conflicts.
error: patch failed: ql/src/test/results/clientpositive/spark/stats2.q.out:19
Falling back to three-way merge...
Applied patch to 'ql/src/test/results/clientpositive/spark/stats2.q.out' with
conflicts.
error: patch failed: ql/src/test/results/clientpositive/spark/union14.q.out:122
Falling back to three-way merge...
Applied patch to 'ql/src/test/results/clientpositive/spark/union14.q.out' with
conflicts.
error: patch failed: ql/src/test/results/clientpositive/spark/union15.q.out:147
Falling back to three-way merge...
Applied patch to 'ql/src/test/results/clientpositive/spark/union15.q.out' with
conflicts.
error: patch failed: ql/src/test/results/clientpositive/spark/union7.q.out:118
Falling back to three-way merge...
Applied patch to 'ql/src/test/results/clientpositive/spark/union7.q.out' with
conflicts.
error: patch failed: ql/src/test/results/clientpositive/spark/union_null.q.out:6
Falling back to three-way merge...
Applied patch to 'ql/src/test/results/clientpositive/spark/union_null.q.out'
cleanly.
error: patch failed:
ql/src/test/results/clientpositive/spark/union_remove_15.q.out:85
Falling back to three-way merge...
Applied patch to
'ql/src/test/results/clientpositive/spark/union_remove_15.q.out' with conflicts.
error: patch failed:
ql/src/test/results/clientpositive/spark/union_remove_16.q.out:90
Falling back to three-way merge...
Applied patch to
'ql/src/test/results/clientpositive/spark/union_remove_16.q.out' with conflicts.
error: patch failed:
ql/src/test/results/clientpositive/spark/union_remove_17.q.out:47
Falling back to three-way merge...
Applied patch to
'ql/src/test/results/clientpositive/spark/union_remove_17.q.out' with conflicts.
error: patch failed:
ql/src/test/results/clientpositive/spark/union_remove_18.q.out:85
Falling back to three-way merge...
Applied patch to
'ql/src/test/results/clientpositive/spark/union_remove_18.q.out' with conflicts.
error: patch failed:
ql/src/test/results/clientpositive/spark/union_remove_25.q.out:437
Falling back to three-way merge...
Applied patch to
'ql/src/test/results/clientpositive/spark/union_remove_25.q.out' with conflicts.
error: patch failed:
ql/src/test/results/clientpositive/spark/union_view.q.out:492
Falling back to three-way merge...
Applied patch to 'ql/src/test/results/clientpositive/spark/union_view.q.out'
with conflicts.
U ql/src/test/results/clientpositive/spark/load_dyn_part1.q.out
U ql/src/test/results/clientpositive/spark/load_dyn_part10.q.out
U ql/src/test/results/clientpositive/spark/load_dyn_part14.q.out
U ql/src/test/results/clientpositive/spark/load_dyn_part3.q.out
U ql/src/test/results/clientpositive/spark/load_dyn_part4.q.out
U ql/src/test/results/clientpositive/spark/load_dyn_part5.q.out
U ql/src/test/results/clientpositive/spark/load_dyn_part8.q.out
U ql/src/test/results/clientpositive/spark/load_dyn_part9.q.out
U ql/src/test/results/clientpositive/spark/orc_merge2.q.out
U ql/src/test/results/clientpositive/spark/stats2.q.out
U ql/src/test/results/clientpositive/spark/union14.q.out
U ql/src/test/results/clientpositive/spark/union15.q.out
U ql/src/test/results/clientpositive/spark/union7.q.out
U ql/src/test/results/clientpositive/spark/union_remove_15.q.out
U ql/src/test/results/clientpositive/spark/union_remove_16.q.out
U ql/src/test/results/clientpositive/spark/union_remove_17.q.out
U ql/src/test/results/clientpositive/spark/union_remove_18.q.out
U ql/src/test/results/clientpositive/spark/union_remove_25.q.out
U ql/src/test/results/clientpositive/spark/union_view.q.out
warning: squelched 31 whitespace errors
warning: 36 lines add whitespace errors.
+ result=1
+ '[' 1 -ne 0 ']'
+ rm -rf yetus_PreCommit-HIVE-Build-15270
+ exit 1
'
{noformat}
This message is automatically generated.
ATTACHMENT ID: 12908851 - PreCommit-HIVE-Build
> Turn on hive.optimize.sort.dynamic.partition by default
> -------------------------------------------------------
>
> Key: HIVE-17935
> URL: https://issues.apache.org/jira/browse/HIVE-17935
> Project: Hive
> Issue Type: Bug
> Reporter: Andrew Sherman
> Priority: Major
> Attachments: HIVE-17935.1.patch, HIVE-17935.2.patch,
> HIVE-17935.3.patch, HIVE-17935.4.patch, HIVE-17935.5.patch,
> HIVE-17935.6.patch, HIVE-17935.7.patch, HIVE-17935.8.patch
>
>
> The config option hive.optimize.sort.dynamic.partition is an optimization for
> Hive’s dynamic partitioning feature. It was originally implemented in
> [HIVE-6455|https://issues.apache.org/jira/browse/HIVE-6455]. With this
> optimization, the dynamic partition columns and bucketing columns (in case of
> bucketed tables) are sorted before being fed to the reducers. Since the
> partitioning and bucketing columns are sorted, each reducer can keep only one
> record writer open at any time thereby reducing the memory pressure on the
> reducers. There were some early problems with this optimization and it was
> disabled by default in HiveConf in
> [HIVE-8151|https://issues.apache.org/jira/browse/HIVE-8151]. Since then
> setting hive.optimize.sort.dynamic.partition=true has been used to solve
> problems where dynamic partitioning produces with (1) too many small files on
> HDFS, which is bad for the cluster and can increase overhead for future Hive
> queries over those partitions, and (2) OOM issues in the map tasks because it
> trying to simultaneously write to 100 different files.
> It now seems that the feature is probably mature enough that it can be
> enabled by default.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
