[ https://issues.apache.org/jira/browse/HIVE-20896?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16692604#comment-16692604 ]
Hive QA commented on HIVE-20896: -------------------------------- Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12948781/HIVE-20896.2.patch {color:red}ERROR:{color} -1 due to no test(s) being added or modified. {color:red}ERROR:{color} -1 due to 12 failed/errored test(s), 15544 tests executed *Failed tests:* {noformat} org.apache.hadoop.hive.metastore.TestObjectStore.catalogs (batchId=232) org.apache.hadoop.hive.metastore.TestObjectStore.testConcurrentDropPartitions (batchId=232) org.apache.hadoop.hive.metastore.TestObjectStore.testDatabaseOps (batchId=232) org.apache.hadoop.hive.metastore.TestObjectStore.testDirectSQLDropParitionsCleanup (batchId=232) org.apache.hadoop.hive.metastore.TestObjectStore.testDirectSQLDropPartitionsCacheCrossSession (batchId=232) org.apache.hadoop.hive.metastore.TestObjectStore.testDirectSqlErrorMetrics (batchId=232) org.apache.hadoop.hive.metastore.TestObjectStore.testMasterKeyOps (batchId=232) org.apache.hadoop.hive.metastore.TestObjectStore.testMaxEventResponse (batchId=232) org.apache.hadoop.hive.metastore.TestObjectStore.testPartitionOps (batchId=232) org.apache.hadoop.hive.metastore.TestObjectStore.testQueryCloseOnError (batchId=232) org.apache.hadoop.hive.metastore.TestObjectStore.testRoleOps (batchId=232) org.apache.hadoop.hive.metastore.TestObjectStore.testTableOps (batchId=232) {noformat} Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/14999/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/14999/console Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-14999/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.YetusPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase Tests exited with: TestsFailedException: 12 tests failed {noformat} This message is automatically generated. ATTACHMENT ID: 12948781 - PreCommit-HIVE-Build > CachedStore fail to cache stats in multiple code paths > ------------------------------------------------------ > > Key: HIVE-20896 > URL: https://issues.apache.org/jira/browse/HIVE-20896 > Project: Hive > Issue Type: Bug > Components: Standalone Metastore > Reporter: Daniel Dai > Assignee: Daniel Dai > Priority: Major > Attachments: HIVE-20896.0.patch, HIVE-20896.1.patch, > HIVE-20896.2.patch > > > Bunch of issues discovered in CachedStore to keep up column statistics: > 1. The criteria for partition/non-partition is wrong > (table.isSetPartitionKeys() is always true) > 2. In update(), partition column stats are removed when populate table basic > stats > 3. Dirty flags are true right after prewarm(), so the first update() does not > do anything > 4. Could invoke cacheLock without holding the lock, which results a freeze in > update() -- This message was sent by Atlassian JIRA (v7.6.3#76005)