[ https://issues.apache.org/jira/browse/HIVE-20850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16683101#comment-16683101 ]
Hive QA commented on HIVE-20850: -------------------------------- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | || || || || {color:brown} master Compile Tests {color} || | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 49s{color} | {color:blue} Maven dependency ordering for branch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 6m 31s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m 14s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m 17s{color} | {color:green} master passed {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m 29s{color} | {color:blue} accumulo-handler in master has 21 extant Findbugs warnings. {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m 27s{color} | {color:blue} hbase-handler in master has 15 extant Findbugs warnings. {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m 37s{color} | {color:blue} itests/hive-unit in master has 2 extant Findbugs warnings. {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 3m 40s{color} | {color:blue} ql in master has 2316 extant Findbugs warnings. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 39s{color} | {color:green} master passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 8s{color} | {color:blue} Maven dependency ordering for patch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 2m 33s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m 14s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 2m 14s{color} | {color:green} the patch passed {color} | | {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m 17s{color} | {color:red} itests/hive-unit: The patch generated 2 new + 51 unchanged - 0 fixed = 53 total (was 51) {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 5m 43s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 39s{color} | {color:green} the patch passed {color} | || || || || {color:brown} Other Tests {color} || | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 13s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 34m 36s{color} | {color:black} {color} | \\ \\ || Subsystem || Report/Notes || | Optional Tests | asflicense javac javadoc findbugs checkstyle compile | | uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 3.16.36-1+deb8u1 (2016-09-03) x86_64 GNU/Linux | | Build tool | maven | | Personality | /data/hiveptest/working/yetus_PreCommit-HIVE-Build-14878/dev-support/hive-personality.sh | | git revision | master / d22fc5b | | Default Java | 1.8.0_111 | | findbugs | v3.0.0 | | checkstyle | http://104.198.109.242/logs//PreCommit-HIVE-Build-14878/yetus/diff-checkstyle-itests_hive-unit.txt | | modules | C: accumulo-handler hbase-handler itests/hive-unit ql U: . | | Console output | http://104.198.109.242/logs//PreCommit-HIVE-Build-14878/yetus.txt | | Powered by | Apache Yetus http://yetus.apache.org | This message was automatically generated. > Push case conditional from projections to dimension tables if possible > ---------------------------------------------------------------------- > > Key: HIVE-20850 > URL: https://issues.apache.org/jira/browse/HIVE-20850 > Project: Hive > Issue Type: Improvement > Reporter: Zoltan Haindrich > Assignee: Zoltan Haindrich > Priority: Major > Attachments: HIVE-20850.01.patch, HIVE-20850.01.patch, > HIVE-20850.01.patch, HIVE-20850.02.patch, HIVE-20850.03.patch, > HIVE-20850.04.patch, HIVE-20850.05.patch, HIVE-20850.06.patch, > HIVE-20850.07.patch, HIVE-20850.07.patch > > > noticed by [~gopalv]: If there is a project which could be only evaluated > after the join; but the condition references only a single column from a > small dimension table; hive will end up evaluating the same thing over and > over again... > {code} > explain > select s_store_name, s_store_id, > sum(case when (d_day_name='Sunday') then ss_sales_price else null > end) sun_sales, > sum(case when (d_day_name='Monday') then ss_sales_price else null > end) mon_sales, > sum(case when (d_day_name='Tuesday') then ss_sales_price else null > end) tue_sales, > sum(case when (d_day_name='Wednesday') then ss_sales_price else null > end) wed_sales, > sum(case when (d_day_name='Thursday') then ss_sales_price else null > end) thu_sales, > sum(case when (d_day_name='Friday') then ss_sales_price else null > end) fri_sales, > sum(case when (d_day_name='Saturday') then ss_sales_price else null > end) sat_sales > from date_dim, store_sales, store > where d_date_sk = ss_sold_date_sk and > s_store_sk = ss_store_sk and > s_gmt_offset = -6 and > d_year = 1998 > group by s_store_name, s_store_id > order by s_store_name, > s_store_id,sun_sales,mon_sales,tue_sales,wed_sales,thu_sales,fri_sales,sat_sales > limit 100; > {code} -- This message was sent by Atlassian JIRA (v7.6.3#76005)