[ https://issues.apache.org/jira/browse/HIVE-20842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16676716#comment-16676716 ]
Hive QA commented on HIVE-20842: -------------------------------- Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12947004/HIVE-20842.5.patch {color:red}ERROR:{color} -1 due to no test(s) being added or modified. {color:red}ERROR:{color} -1 due to 34 failed/errored test(s), 15525 tests executed *Failed tests:* {noformat} org.apache.hadoop.hive.cli.TestMiniLlapCliDriver.testCliDriver[except_distinct] (batchId=155) org.apache.hadoop.hive.cli.TestMiniLlapCliDriver.testCliDriver[explainuser_2] (batchId=156) org.apache.hadoop.hive.cli.TestMiniLlapCliDriver.testCliDriver[intersect_all] (batchId=154) org.apache.hadoop.hive.cli.TestMiniLlapCliDriver.testCliDriver[intersect_distinct] (batchId=156) org.apache.hadoop.hive.cli.TestMiniLlapCliDriver.testCliDriver[intersect_merge] (batchId=154) org.apache.hadoop.hive.cli.TestMiniLlapCliDriver.testCliDriver[unionDistinct_1] (batchId=154) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[correlationoptimizer2] (batchId=171) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[explainanalyze_2] (batchId=177) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[explainuser_1] (batchId=167) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[subquery_in_having] (batchId=174) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[subquery_notin] (batchId=177) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[subquery_scalar] (batchId=169) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[tez_union_multiinsert] (batchId=167) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[unionDistinct_3] (batchId=171) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[vector_groupby_grouping_sets2] (batchId=167) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[vector_groupby_reduce] (batchId=173) org.apache.hadoop.hive.cli.TestMiniSparkOnYarnCliDriver.testCliDriver[spark_explainuser_1] (batchId=190) org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[query14] (batchId=272) org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[query49] (batchId=272) org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[query58] (batchId=272) org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[query5] (batchId=272) org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[query66] (batchId=272) org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[query70] (batchId=272) org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[query75] (batchId=272) org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[query83] (batchId=272) org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[query87] (batchId=272) org.apache.hadoop.hive.cli.TestTezPerfConstraintsCliDriver.testCliDriver[query14] (batchId=272) org.apache.hadoop.hive.cli.TestTezPerfConstraintsCliDriver.testCliDriver[query23] (batchId=272) org.apache.hadoop.hive.cli.TestTezPerfConstraintsCliDriver.testCliDriver[query38] (batchId=272) org.apache.hadoop.hive.cli.TestTezPerfConstraintsCliDriver.testCliDriver[query58] (batchId=272) org.apache.hadoop.hive.cli.TestTezPerfConstraintsCliDriver.testCliDriver[query64] (batchId=272) org.apache.hadoop.hive.cli.TestTezPerfConstraintsCliDriver.testCliDriver[query66] (batchId=272) org.apache.hadoop.hive.cli.TestTezPerfConstraintsCliDriver.testCliDriver[query83] (batchId=272) org.apache.hadoop.hive.cli.TestTezPerfConstraintsCliDriver.testCliDriver[query87] (batchId=272) {noformat} Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/14767/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/14767/console Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-14767/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.YetusPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase Tests exited with: TestsFailedException: 34 tests failed {noformat} This message is automatically generated. ATTACHMENT ID: 12947004 - PreCommit-HIVE-Build > Fix logic introduced in HIVE-20660 to estimate statistics for group by > ---------------------------------------------------------------------- > > Key: HIVE-20842 > URL: https://issues.apache.org/jira/browse/HIVE-20842 > Project: Hive > Issue Type: Bug > Components: Statistics > Affects Versions: 4.0.0 > Reporter: Vineet Garg > Assignee: Vineet Garg > Priority: Major > Attachments: HIVE-20842.1.patch, HIVE-20842.2.patch, > HIVE-20842.3.patch, HIVE-20842.4.patch, HIVE-20842.5.patch > > > HIVE-20660 introduced better estimation for group by operator. But the logic > did not account for Partial and Full group by separately. > For partial group by parallelism (i.e. number of tasks) should be taken into > account. -- This message was sent by Atlassian JIRA (v7.6.3#76005)