[ 
https://issues.apache.org/jira/browse/HIVE-20823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16674260#comment-16674260
 ] 

Hive QA commented on HIVE-20823:
--------------------------------



Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12946771/HIVE-20823.03.patch

{color:green}SUCCESS:{color} +1 due to 6 test(s) being added or modified.

{color:red}ERROR:{color} -1 due to 95 failed/errored test(s), 15513 tests 
executed
*Failed tests:*
{noformat}
TestMiniDruidCliDriver - did not produce a TEST-*.xml file (likely timed out) 
(batchId=195)
        
[druidmini_dynamic_partition.q,druidmini_test_ts.q,druidmini_expressions.q,druidmini_test_alter.q,druidmini_test_insert.q]
org.apache.hadoop.hive.ql.TestTxnCommands2.testCleanerForTxnToWriteId 
(batchId=307)
org.apache.hadoop.hive.ql.TestTxnCommands2.writeBetweenWorkerAndCleaner 
(batchId=307)
org.apache.hadoop.hive.ql.TestTxnCommands2WithSplitUpdateAndVectorization.testCleanerForTxnToWriteId
 (batchId=319)
org.apache.hadoop.hive.ql.TestTxnCommands2WithSplitUpdateAndVectorization.writeBetweenWorkerAndCleaner
 (batchId=319)
org.apache.hadoop.hive.ql.TestTxnCommands3.testCleaner2 (batchId=320)
org.apache.hadoop.hive.ql.TestTxnCommandsForMmTable.testSnapshotIsolationWithAbortedTxnOnMmTable
 (batchId=283)
org.apache.hadoop.hive.ql.TestTxnCommandsForOrcMmTable.testSnapshotIsolationWithAbortedTxnOnMmTable
 (batchId=305)
org.apache.hadoop.hive.ql.io.TestAcidUtils.deleteDeltasWithOpenTxnInRead 
(batchId=294)
org.apache.hadoop.hive.ql.io.TestAcidUtils.deltasAndDeleteDeltasWithOpenTxnsNotInCompact
 (batchId=294)
org.apache.hadoop.hive.ql.io.TestAcidUtils.deltasWithOpenTxnInRead (batchId=294)
org.apache.hadoop.hive.ql.io.TestAcidUtils.deltasWithOpenTxnInRead2 
(batchId=294)
org.apache.hadoop.hive.ql.io.TestAcidUtils.deltasWithOpenTxnsNotInCompact 
(batchId=294)
org.apache.hadoop.hive.ql.io.TestAcidUtils.deltasWithOpenTxnsNotInCompact2 
(batchId=294)
org.apache.hadoop.hive.ql.io.TestAcidUtils.testBaseDeltas (batchId=294)
org.apache.hadoop.hive.ql.io.TestAcidUtils.testBaseWithDeleteDeltas 
(batchId=294)
org.apache.hadoop.hive.ql.io.TestAcidUtils.testMinorCompactedDeltaMakesInBetweenDelteDeltaObsolete
 (batchId=294)
org.apache.hadoop.hive.ql.io.TestAcidUtils.testObsoleteOriginals (batchId=294)
org.apache.hadoop.hive.ql.io.TestAcidUtils.testOriginalDeltas (batchId=294)
org.apache.hadoop.hive.ql.io.TestAcidUtils.testOverlapingDelta (batchId=294)
org.apache.hadoop.hive.ql.io.TestAcidUtils.testOverlapingDelta2 (batchId=294)
org.apache.hadoop.hive.ql.io.TestAcidUtils.testOverlapingDeltaAndDeleteDelta 
(batchId=294)
org.apache.hadoop.hive.ql.io.orc.TestInputOutputFormat.testACIDReaderFooterSerializeWithDeltas
 (batchId=297)
org.apache.hadoop.hive.ql.io.orc.TestInputOutputFormat.testACIDReaderNoFooterSerializeWithDeltas
 (batchId=297)
org.apache.hadoop.hive.ql.io.orc.TestInputOutputFormat.testACIDSplitStrategy 
(batchId=297)
org.apache.hadoop.hive.ql.io.orc.TestInputOutputFormat.testACIDSplitStrategyForSplitUpdate
 (batchId=297)
org.apache.hadoop.hive.ql.io.orc.TestInputOutputFormat.testCombinationInputFormatWithAcid
 (batchId=297)
org.apache.hadoop.hive.ql.io.orc.TestInputOutputFormat.testEtlCombinedStrategy 
(batchId=297)
org.apache.hadoop.hive.ql.io.orc.TestInputOutputFormat.testFSCallsVectorizedOrcAcidRowBatchReader
 (batchId=297)
org.apache.hadoop.hive.ql.io.orc.TestInputOutputFormat.testVectorizationWithAcid
 (batchId=297)
org.apache.hadoop.hive.ql.io.orc.TestOrcRawRecordMerger.testEmpty (batchId=298)
org.apache.hadoop.hive.ql.io.orc.TestOrcRawRecordMerger.testNewBaseAndDelta 
(batchId=298)
org.apache.hadoop.hive.ql.io.orc.TestOrcRawRecordMerger.testRecordReaderDelta 
(batchId=298)
org.apache.hadoop.hive.ql.io.orc.TestOrcRawRecordMerger.testRecordReaderIncompleteDelta
 (batchId=298)
org.apache.hadoop.hive.ql.io.orc.TestOrcRawRecordMerger.testRecordReaderNewBaseAndDelta
 (batchId=298)
org.apache.hadoop.hive.ql.io.orc.TestOrcRawRecordMerger.testRecordReaderOldBaseAndDelta
 (batchId=298)
org.apache.hadoop.hive.ql.io.orc.TestVectorizedOrcAcidRowBatchReader.testDeleteEventFilteringOff
 (batchId=297)
org.apache.hadoop.hive.ql.io.orc.TestVectorizedOrcAcidRowBatchReader.testDeleteEventFilteringOff2
 (batchId=297)
org.apache.hadoop.hive.ql.io.orc.TestVectorizedOrcAcidRowBatchReader.testDeleteEventFilteringOn
 (batchId=297)
org.apache.hadoop.hive.ql.io.orc.TestVectorizedOrcAcidRowBatchReader.testDeleteEventFilteringOn2
 (batchId=297)
org.apache.hadoop.hive.ql.io.orc.TestVectorizedOrcAcidRowBatchReader.testDeleteEventOriginalFilteringOff
 (batchId=297)
org.apache.hadoop.hive.ql.io.orc.TestVectorizedOrcAcidRowBatchReader.testDeleteEventOriginalFilteringOn
 (batchId=297)
org.apache.hadoop.hive.ql.io.orc.TestVectorizedOrcAcidRowBatchReader.testVectorizedOrcAcidRowBatchReader
 (batchId=297)
org.apache.hadoop.hive.ql.parse.TestReplAcidTablesWithJsonMessage.testAcidBootstrapReplLoadRetryAfterFailure
 (batchId=250)
org.apache.hadoop.hive.ql.parse.TestReplAcidTablesWithJsonMessage.testAcidTablesBootstrap
 (batchId=250)
org.apache.hadoop.hive.ql.parse.TestReplAcidTablesWithJsonMessage.testAcidTablesBootstrapWithConcurrentWrites
 (batchId=250)
org.apache.hadoop.hive.ql.parse.TestReplAcidTablesWithJsonMessage.testAcidTablesBootstrapWithOpenTxnsTimeout
 (batchId=250)
org.apache.hadoop.hive.ql.parse.TestReplAcidTablesWithJsonMessage.testAcidTablesMoveOptimizationBootStrap
 (batchId=250)
org.apache.hadoop.hive.ql.parse.TestReplicationScenariosAcidTables.testAcidBootstrapReplLoadRetryAfterFailure
 (batchId=247)
org.apache.hadoop.hive.ql.parse.TestReplicationScenariosAcidTables.testAcidTablesBootstrap
 (batchId=247)
org.apache.hadoop.hive.ql.parse.TestReplicationScenariosAcidTables.testAcidTablesBootstrapWithConcurrentWrites
 (batchId=247)
org.apache.hadoop.hive.ql.parse.TestReplicationScenariosAcidTables.testAcidTablesBootstrapWithOpenTxnsTimeout
 (batchId=247)
org.apache.hadoop.hive.ql.parse.TestReplicationScenariosAcidTables.testAcidTablesMoveOptimizationBootStrap
 (batchId=247)
org.apache.hadoop.hive.ql.txn.compactor.TestCompactor.dynamicPartitioningDelete[0]
 (batchId=243)
org.apache.hadoop.hive.ql.txn.compactor.TestCompactor.dynamicPartitioningDelete[1]
 (batchId=243)
org.apache.hadoop.hive.ql.txn.compactor.TestCompactor.dynamicPartitioningInsert[0]
 (batchId=243)
org.apache.hadoop.hive.ql.txn.compactor.TestCompactor.dynamicPartitioningInsert[1]
 (batchId=243)
org.apache.hadoop.hive.ql.txn.compactor.TestCompactor.dynamicPartitioningUpdate[0]
 (batchId=243)
org.apache.hadoop.hive.ql.txn.compactor.TestCompactor.dynamicPartitioningUpdate[1]
 (batchId=243)
org.apache.hadoop.hive.ql.txn.compactor.TestCompactor.schemaEvolutionAddColDynamicPartitioningInsert[0]
 (batchId=243)
org.apache.hadoop.hive.ql.txn.compactor.TestCompactor.schemaEvolutionAddColDynamicPartitioningInsert[1]
 (batchId=243)
org.apache.hadoop.hive.ql.txn.compactor.TestCompactor.schemaEvolutionAddColDynamicPartitioningUpdate[0]
 (batchId=243)
org.apache.hadoop.hive.ql.txn.compactor.TestCompactor.schemaEvolutionAddColDynamicPartitioningUpdate[1]
 (batchId=243)
org.apache.hadoop.hive.ql.txn.compactor.TestCompactor.testTableProperties[0] 
(batchId=243)
org.apache.hadoop.hive.ql.txn.compactor.TestCompactor.testTableProperties[1] 
(batchId=243)
org.apache.hadoop.hive.ql.txn.compactor.TestInitiator.chooseMajorOverMinorWhenBothValid
 (batchId=293)
org.apache.hadoop.hive.ql.txn.compactor.TestInitiator.compactPartitionHighDeltaPct
 (batchId=293)
org.apache.hadoop.hive.ql.txn.compactor.TestInitiator.compactPartitionTooManyDeltas
 (batchId=293)
org.apache.hadoop.hive.ql.txn.compactor.TestInitiator.compactTableHighDeltaPct 
(batchId=293)
org.apache.hadoop.hive.ql.txn.compactor.TestInitiator.compactTableTooManyDeltas 
(batchId=293)
org.apache.hadoop.hive.ql.txn.compactor.TestInitiator.enoughDeltasNoBase 
(batchId=293)
org.apache.hadoop.hive.ql.txn.compactor.TestInitiator.noCompactTableDeltaPctNotHighEnough
 (batchId=293)
org.apache.hadoop.hive.ql.txn.compactor.TestInitiator.noCompactTableNotEnoughDeltas
 (batchId=293)
org.apache.hadoop.hive.ql.txn.compactor.TestInitiator.twoTxnsOnSamePartitionGenerateOneCompactionRequest
 (batchId=293)
org.apache.hive.hcatalog.streaming.TestStreaming.testInterleavedTransactionBatchCommits
 (batchId=217)
org.apache.hive.hcatalog.streaming.TestStreaming.testMultipleTransactionBatchCommits
 (batchId=217)
org.apache.hive.hcatalog.streaming.TestStreaming.testTransactionBatchAbort 
(batchId=217)
org.apache.hive.hcatalog.streaming.TestStreaming.testTransactionBatchAbortAndCommit
 (batchId=217)
org.apache.hive.hcatalog.streaming.TestStreaming.testTransactionBatchCommit_Delimited
 (batchId=217)
org.apache.hive.hcatalog.streaming.TestStreaming.testTransactionBatchCommit_DelimitedUGI
 (batchId=217)
org.apache.hive.hcatalog.streaming.TestStreaming.testTransactionBatchCommit_Json
 (batchId=217)
org.apache.hive.hcatalog.streaming.TestStreaming.testTransactionBatchCommit_Regex
 (batchId=217)
org.apache.hive.hcatalog.streaming.TestStreaming.testTransactionBatchCommit_RegexUGI
 (batchId=217)
org.apache.hive.hcatalog.streaming.mutate.TestMutations.testMulti (batchId=217)
org.apache.hive.hcatalog.streaming.mutate.TestMutations.testTransactionBatchAbort
 (batchId=217)
org.apache.hive.hcatalog.streaming.mutate.TestMutations.testTransactionBatchCommitPartitioned
 (batchId=217)
org.apache.hive.hcatalog.streaming.mutate.TestMutations.testTransactionBatchCommitUnpartitioned
 (batchId=217)
org.apache.hive.hcatalog.streaming.mutate.TestMutations.testUpdatesAndDeletes 
(batchId=217)
org.apache.hive.streaming.TestStreaming.testInterleavedTransactionBatchCommits 
(batchId=330)
org.apache.hive.streaming.TestStreaming.testMultipleTransactionBatchCommits 
(batchId=330)
org.apache.hive.streaming.TestStreaming.testTransactionBatchAbort (batchId=330)
org.apache.hive.streaming.TestStreaming.testTransactionBatchAbortAndCommit 
(batchId=330)
org.apache.hive.streaming.TestStreaming.testTransactionBatchCommitDelimited 
(batchId=330)
org.apache.hive.streaming.TestStreaming.testTransactionBatchCommitJson 
(batchId=330)
org.apache.hive.streaming.TestStreaming.testTransactionBatchCommitRegex 
(batchId=330)
{noformat}

Test results: 
https://builds.apache.org/job/PreCommit-HIVE-Build/14737/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/14737/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-14737/

Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.YetusPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 95 tests failed
{noformat}

This message is automatically generated.

ATTACHMENT ID: 12946771 - PreCommit-HIVE-Build

> Make Compactor run in a transaction
> -----------------------------------
>
>                 Key: HIVE-20823
>                 URL: https://issues.apache.org/jira/browse/HIVE-20823
>             Project: Hive
>          Issue Type: Improvement
>          Components: Transactions
>    Affects Versions: 3.0.0
>            Reporter: Eugene Koifman
>            Assignee: Eugene Koifman
>            Priority: Major
>         Attachments: HIVE-20823.01.patch, HIVE-20823.03.patch
>
>
> Have compactor open a transaction and run the job in that transaction.
> # make compactor produced base/delta include this txn id in the folder name, 
> e.g. base_7_c17 where 17 is the txnid.
> # add {{CQ_TXN_ID bigint}} to COMPACTION_QUEUE and COMPLETED_COMPACTIONS to 
> record this txn id
> # make sure {{AcidUtils.getAcidState()}} pays attention to this transaction 
> on read and ignores this dir if this txn id is not committed in the current 
> snapshot
> ## this means not only validWriteIdList but ValidTxnIdList should be passed 
> along in config (if it isn't yet)
> # once this is done, {{CompactorMR.createCompactorMarker()}} can be 
> eliminated and {{AcidUtils.isValidBase}} modified accordingly
> # modify Cleaner so that it doesn't clean old files until new file is visible 
> to all readers
> # 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to