[ https://issues.apache.org/jira/browse/HIVE-20855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16674181#comment-16674181 ]
Hive QA commented on HIVE-20855: -------------------------------- Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12946721/HIVE-20855.2.patch {color:green}SUCCESS:{color} +1 due to 2 test(s) being added or modified. {color:red}ERROR:{color} -1 due to 1 failed/errored test(s), 15523 tests executed *Failed tests:* {noformat} org.apache.hadoop.hive.llap.security.TestLlapSignerImpl.testSigning (batchId=332) {noformat} Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/14728/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/14728/console Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-14728/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.YetusPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase Tests exited with: TestsFailedException: 1 tests failed {noformat} This message is automatically generated. ATTACHMENT ID: 12946721 - PreCommit-HIVE-Build > Clean up checkstyle & other warnings for CachedStore > ---------------------------------------------------- > > Key: HIVE-20855 > URL: https://issues.apache.org/jira/browse/HIVE-20855 > Project: Hive > Issue Type: Improvement > Reporter: Lars Francke > Assignee: Lars Francke > Priority: Minor > Attachments: HIVE-20855.1.patch, HIVE-20855.2.patch > > > While documenting the CachedStore in the Wiki I found a bunch of warnings, > inconsistencies etc. in CachedStore, RawStore and a few other related classes. > This is a patch that cleans them up. It's almost whitespace-only. > It does not contain semantic code changes, it does contain two or three > deprecations in favor of renamed methods or fields. > This is going to be boring to review so according to the bylaws I'll ask for > feedback on the mailing list and will commit after a week or so. -- This message was sent by Atlassian JIRA (v7.6.3#76005)