[ https://issues.apache.org/jira/browse/HIVE-20707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16667209#comment-16667209 ]
Hive QA commented on HIVE-20707: -------------------------------- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | || || || || {color:brown} master Compile Tests {color} || | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 26s{color} | {color:blue} Maven dependency ordering for branch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 7m 41s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 3m 1s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m 37s{color} | {color:green} master passed {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m 30s{color} | {color:blue} common in master has 65 extant Findbugs warnings. {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 2m 19s{color} | {color:blue} standalone-metastore/metastore-common in master has 28 extant Findbugs warnings. {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m 29s{color} | {color:blue} hbase-handler in master has 15 extant Findbugs warnings. {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m 37s{color} | {color:blue} itests/hive-unit in master has 2 extant Findbugs warnings. {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 3m 46s{color} | {color:blue} ql in master has 2317 extant Findbugs warnings. {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m 59s{color} | {color:blue} standalone-metastore/metastore-server in master has 181 extant Findbugs warnings. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 2m 50s{color} | {color:green} master passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 9s{color} | {color:blue} Maven dependency ordering for patch {color} | | {color:red}-1{color} | {color:red} mvninstall {color} | {color:red} 0m 29s{color} | {color:red} ql in the patch failed. {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 3m 7s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 3m 7s{color} | {color:green} the patch passed {color} | | {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m 42s{color} | {color:red} ql: The patch generated 40 new + 515 unchanged - 6 fixed = 555 total (was 521) {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 0m 38s{color} | {color:green} common in the patch passed. {color} | | {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 2m 27s{color} | {color:red} standalone-metastore/metastore-common generated 1 new + 28 unchanged - 0 fixed = 29 total (was 28) {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 0m 35s{color} | {color:green} hbase-handler in the patch passed. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 0m 43s{color} | {color:green} hive-unit in the patch passed. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 3m 57s{color} | {color:green} ql generated 0 new + 2315 unchanged - 2 fixed = 2315 total (was 2317) {color} | | {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 1m 14s{color} | {color:red} standalone-metastore/metastore-server generated 4 new + 181 unchanged - 0 fixed = 185 total (was 181) {color} | | {color:red}-1{color} | {color:red} javadoc {color} | {color:red} 0m 19s{color} | {color:red} standalone-metastore_metastore-server generated 1 new + 47 unchanged - 0 fixed = 48 total (was 47) {color} | || || || || {color:brown} Other Tests {color} || | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 13s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 45m 51s{color} | {color:black} {color} | \\ \\ || Reason || Tests || | FindBugs | module:standalone-metastore/metastore-common | | | org.apache.hadoop.hive.metastore.CheckResult$PartitionResult defines compareTo(CheckResult$PartitionResult) and uses Object.equals() At CheckResult.java:Object.equals() At CheckResult.java:[lines 148-149] | | FindBugs | module:standalone-metastore/metastore-server | | | Found reliance on default encoding in org.apache.hadoop.hive.metastore.Msck.repair(MsckInfo):in org.apache.hadoop.hive.metastore.Msck.repair(MsckInfo): new java.io.OutputStreamWriter(OutputStream) At Msck.java:[line 243] | | | Write to static field org.apache.hadoop.hive.metastore.PartitionManagementTask.completedAttempts from instance method org.apache.hadoop.hive.metastore.PartitionManagementTask.run() At PartitionManagementTask.java:from instance method org.apache.hadoop.hive.metastore.PartitionManagementTask.run() At PartitionManagementTask.java:[line 159] | | | Write to static field org.apache.hadoop.hive.metastore.PartitionManagementTask.skippedAttempts from instance method org.apache.hadoop.hive.metastore.PartitionManagementTask.run() At PartitionManagementTask.java:from instance method org.apache.hadoop.hive.metastore.PartitionManagementTask.run() At PartitionManagementTask.java:[line 86] | | | Redundant nullcheck of org.apache.hadoop.hive.metastore.utils.MetaStoreServerUtils.getPartCols(Table), which is known to be non-null in org.apache.hadoop.hive.metastore.utils.MetaStoreServerUtils.isPartitioned(Table) Redundant null check at MetaStoreServerUtils.java:is known to be non-null in org.apache.hadoop.hive.metastore.utils.MetaStoreServerUtils.isPartitioned(Table) Redundant null check at MetaStoreServerUtils.java:[line 1323] | \\ \\ || Subsystem || Report/Notes || | Optional Tests | asflicense javac javadoc findbugs checkstyle compile | | uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 3.16.36-1+deb8u1 (2016-09-03) x86_64 GNU/Linux | | Build tool | maven | | Personality | /data/hiveptest/working/yetus_PreCommit-HIVE-Build-14680/dev-support/hive-personality.sh | | git revision | master / 54bba9c | | Default Java | 1.8.0_111 | | findbugs | v3.0.0 | | mvninstall | http://104.198.109.242/logs//PreCommit-HIVE-Build-14680/yetus/patch-mvninstall-ql.txt | | checkstyle | http://104.198.109.242/logs//PreCommit-HIVE-Build-14680/yetus/diff-checkstyle-ql.txt | | findbugs | http://104.198.109.242/logs//PreCommit-HIVE-Build-14680/yetus/new-findbugs-standalone-metastore_metastore-common.html | | findbugs | http://104.198.109.242/logs//PreCommit-HIVE-Build-14680/yetus/new-findbugs-standalone-metastore_metastore-server.html | | javadoc | http://104.198.109.242/logs//PreCommit-HIVE-Build-14680/yetus/diff-javadoc-javadoc-standalone-metastore_metastore-server.txt | | modules | C: common standalone-metastore/metastore-common hbase-handler itests/hive-unit ql standalone-metastore/metastore-server U: . | | Console output | http://104.198.109.242/logs//PreCommit-HIVE-Build-14680/yetus.txt | | Powered by | Apache Yetus http://yetus.apache.org | This message was automatically generated. > Automatic partition management > ------------------------------ > > Key: HIVE-20707 > URL: https://issues.apache.org/jira/browse/HIVE-20707 > Project: Hive > Issue Type: New Feature > Affects Versions: 4.0.0 > Reporter: Prasanth Jayachandran > Assignee: Prasanth Jayachandran > Priority: Major > Attachments: HIVE-20702.3.patch, HIVE-20707.1.patch, > HIVE-20707.2.patch, HIVE-20707.4.patch, HIVE-20707.5.patch, > HIVE-20707.6.patch, HIVE-20707.6.patch, HIVE-20707.7.patch > > > In current scenario, to add partitions for external tables to metastore, MSCK > REPAIR command has to be executed manually. To avoid this manual step, > external tables can be specified a table property based on which a background > metastore thread can sync partitions periodically. Tables can also be > specified with partition retention period. Any partition whose age exceeds > the retention period will be dropped automatically. -- This message was sent by Atlassian JIRA (v7.6.3#76005)