[ https://issues.apache.org/jira/browse/HIVE-20742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16651736#comment-16651736 ]
Sahil Takiar commented on HIVE-20742: ------------------------------------- Nice catch. Overall, LGTM. I think it would be good to add some tests that regular Hive session timeouts cause the Spark session to be closed in this scenario. Adding some testing to {{SparkSessionManagerImpl}} {{#shutdown}} {{#closeSession}} would be good too. > SparkSessionManagerImpl maintenance thread only cleans up session once > ---------------------------------------------------------------------- > > Key: HIVE-20742 > URL: https://issues.apache.org/jira/browse/HIVE-20742 > Project: Hive > Issue Type: Bug > Affects Versions: 4.0.0 > Reporter: Antal Sinkovits > Assignee: Antal Sinkovits > Priority: Major > Attachments: HIVE-20742.1.patch, HIVE-20742.2.patch > > > If there is a reconnect at the client session, the SparkSessionManagerImpl > doesn't puts it back in the created sessions, so it will not time out the > second time. -- This message was sent by Atlassian JIRA (v7.6.3#76005)