[ 
https://issues.apache.org/jira/browse/HIVE-20713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16649368#comment-16649368
 ] 

Hive QA commented on HIVE-20713:
--------------------------------



Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12943729/HIVE-20713.1.patch

{color:green}SUCCESS:{color} +1 due to 133 test(s) being added or modified.

{color:red}ERROR:{color} -1 due to 99 failed/errored test(s), 15078 tests 
executed
*Failed tests:*
{noformat}
TestMiniDruidCliDriver - did not produce a TEST-*.xml file (likely timed out) 
(batchId=195)
        
[druidmini_masking.q,druidmini_test1.q,druidkafkamini_basic.q,druidmini_joins.q,druid_timestamptz.q]
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[auto_join25] (batchId=78)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[correlationoptimizer5] 
(batchId=75)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[cross_join] (batchId=30)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[infer_bucket_sort_convert_join]
 (batchId=58)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[mapjoin_hook] 
(batchId=13)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[cross_join] 
(batchId=165)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[multiMapJoin1]
 (batchId=170)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[multiMapJoin2]
 (batchId=178)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[partialdhj] 
(batchId=168)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[tez_smb_main]
 (batchId=165)
org.apache.hadoop.hive.cli.TestMiniSparkOnYarnCliDriver.testCliDriver[spark_dynamic_partition_pruning_3]
 (batchId=190)
org.apache.hadoop.hive.cli.TestMiniSparkOnYarnCliDriver.testCliDriver[spark_dynamic_partition_pruning_mapjoin_only]
 (batchId=189)
org.apache.hadoop.hive.cli.TestMiniTezCliDriver.testCliDriver[explainanalyze_3] 
(batchId=108)
org.apache.hadoop.hive.cli.TestMiniTezCliDriver.testCliDriver[explainanalyze_4] 
(batchId=109)
org.apache.hadoop.hive.cli.TestMiniTezCliDriver.testCliDriver[explainuser_3] 
(batchId=108)
org.apache.hadoop.hive.cli.TestMiniTezCliDriver.testCliDriver[hybridgrace_hashjoin_1]
 (batchId=108)
org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[cross_join] 
(batchId=123)
org.apache.hadoop.hive.cli.TestSparkPerfCliDriver.testCliDriver[query10] 
(batchId=268)
org.apache.hadoop.hive.cli.TestSparkPerfCliDriver.testCliDriver[query11] 
(batchId=268)
org.apache.hadoop.hive.cli.TestSparkPerfCliDriver.testCliDriver[query13] 
(batchId=268)
org.apache.hadoop.hive.cli.TestSparkPerfCliDriver.testCliDriver[query15] 
(batchId=268)
org.apache.hadoop.hive.cli.TestSparkPerfCliDriver.testCliDriver[query17] 
(batchId=268)
org.apache.hadoop.hive.cli.TestSparkPerfCliDriver.testCliDriver[query18] 
(batchId=268)
org.apache.hadoop.hive.cli.TestSparkPerfCliDriver.testCliDriver[query19] 
(batchId=268)
org.apache.hadoop.hive.cli.TestSparkPerfCliDriver.testCliDriver[query1] 
(batchId=268)
org.apache.hadoop.hive.cli.TestSparkPerfCliDriver.testCliDriver[query21] 
(batchId=268)
org.apache.hadoop.hive.cli.TestSparkPerfCliDriver.testCliDriver[query22] 
(batchId=268)
org.apache.hadoop.hive.cli.TestSparkPerfCliDriver.testCliDriver[query23] 
(batchId=268)
org.apache.hadoop.hive.cli.TestSparkPerfCliDriver.testCliDriver[query25] 
(batchId=268)
org.apache.hadoop.hive.cli.TestSparkPerfCliDriver.testCliDriver[query26] 
(batchId=268)
org.apache.hadoop.hive.cli.TestSparkPerfCliDriver.testCliDriver[query27] 
(batchId=268)
org.apache.hadoop.hive.cli.TestSparkPerfCliDriver.testCliDriver[query29] 
(batchId=268)
org.apache.hadoop.hive.cli.TestSparkPerfCliDriver.testCliDriver[query2] 
(batchId=268)
org.apache.hadoop.hive.cli.TestSparkPerfCliDriver.testCliDriver[query30] 
(batchId=268)
org.apache.hadoop.hive.cli.TestSparkPerfCliDriver.testCliDriver[query31] 
(batchId=268)
org.apache.hadoop.hive.cli.TestSparkPerfCliDriver.testCliDriver[query33] 
(batchId=268)
org.apache.hadoop.hive.cli.TestSparkPerfCliDriver.testCliDriver[query34] 
(batchId=268)
org.apache.hadoop.hive.cli.TestSparkPerfCliDriver.testCliDriver[query35] 
(batchId=268)
org.apache.hadoop.hive.cli.TestSparkPerfCliDriver.testCliDriver[query36] 
(batchId=268)
org.apache.hadoop.hive.cli.TestSparkPerfCliDriver.testCliDriver[query37] 
(batchId=268)
org.apache.hadoop.hive.cli.TestSparkPerfCliDriver.testCliDriver[query38] 
(batchId=268)
org.apache.hadoop.hive.cli.TestSparkPerfCliDriver.testCliDriver[query39] 
(batchId=268)
org.apache.hadoop.hive.cli.TestSparkPerfCliDriver.testCliDriver[query3] 
(batchId=268)
org.apache.hadoop.hive.cli.TestSparkPerfCliDriver.testCliDriver[query40] 
(batchId=268)
org.apache.hadoop.hive.cli.TestSparkPerfCliDriver.testCliDriver[query42] 
(batchId=268)
org.apache.hadoop.hive.cli.TestSparkPerfCliDriver.testCliDriver[query43] 
(batchId=268)
org.apache.hadoop.hive.cli.TestSparkPerfCliDriver.testCliDriver[query45] 
(batchId=268)
org.apache.hadoop.hive.cli.TestSparkPerfCliDriver.testCliDriver[query46] 
(batchId=268)
org.apache.hadoop.hive.cli.TestSparkPerfCliDriver.testCliDriver[query47] 
(batchId=268)
org.apache.hadoop.hive.cli.TestSparkPerfCliDriver.testCliDriver[query48] 
(batchId=268)
org.apache.hadoop.hive.cli.TestSparkPerfCliDriver.testCliDriver[query49] 
(batchId=268)
org.apache.hadoop.hive.cli.TestSparkPerfCliDriver.testCliDriver[query4] 
(batchId=268)
org.apache.hadoop.hive.cli.TestSparkPerfCliDriver.testCliDriver[query50] 
(batchId=268)
org.apache.hadoop.hive.cli.TestSparkPerfCliDriver.testCliDriver[query51] 
(batchId=268)
org.apache.hadoop.hive.cli.TestSparkPerfCliDriver.testCliDriver[query52] 
(batchId=268)
org.apache.hadoop.hive.cli.TestSparkPerfCliDriver.testCliDriver[query53] 
(batchId=268)
org.apache.hadoop.hive.cli.TestSparkPerfCliDriver.testCliDriver[query54] 
(batchId=268)
org.apache.hadoop.hive.cli.TestSparkPerfCliDriver.testCliDriver[query55] 
(batchId=268)
org.apache.hadoop.hive.cli.TestSparkPerfCliDriver.testCliDriver[query56] 
(batchId=268)
org.apache.hadoop.hive.cli.TestSparkPerfCliDriver.testCliDriver[query57] 
(batchId=268)
org.apache.hadoop.hive.cli.TestSparkPerfCliDriver.testCliDriver[query58] 
(batchId=268)
org.apache.hadoop.hive.cli.TestSparkPerfCliDriver.testCliDriver[query59] 
(batchId=268)
org.apache.hadoop.hive.cli.TestSparkPerfCliDriver.testCliDriver[query5] 
(batchId=268)
org.apache.hadoop.hive.cli.TestSparkPerfCliDriver.testCliDriver[query60] 
(batchId=268)
org.apache.hadoop.hive.cli.TestSparkPerfCliDriver.testCliDriver[query61] 
(batchId=268)
org.apache.hadoop.hive.cli.TestSparkPerfCliDriver.testCliDriver[query63] 
(batchId=268)
org.apache.hadoop.hive.cli.TestSparkPerfCliDriver.testCliDriver[query65] 
(batchId=268)
org.apache.hadoop.hive.cli.TestSparkPerfCliDriver.testCliDriver[query66] 
(batchId=268)
org.apache.hadoop.hive.cli.TestSparkPerfCliDriver.testCliDriver[query67] 
(batchId=268)
org.apache.hadoop.hive.cli.TestSparkPerfCliDriver.testCliDriver[query68] 
(batchId=268)
org.apache.hadoop.hive.cli.TestSparkPerfCliDriver.testCliDriver[query69] 
(batchId=268)
org.apache.hadoop.hive.cli.TestSparkPerfCliDriver.testCliDriver[query6] 
(batchId=268)
org.apache.hadoop.hive.cli.TestSparkPerfCliDriver.testCliDriver[query70] 
(batchId=268)
org.apache.hadoop.hive.cli.TestSparkPerfCliDriver.testCliDriver[query71] 
(batchId=268)
org.apache.hadoop.hive.cli.TestSparkPerfCliDriver.testCliDriver[query72] 
(batchId=268)
org.apache.hadoop.hive.cli.TestSparkPerfCliDriver.testCliDriver[query73] 
(batchId=268)
org.apache.hadoop.hive.cli.TestSparkPerfCliDriver.testCliDriver[query74] 
(batchId=268)
org.apache.hadoop.hive.cli.TestSparkPerfCliDriver.testCliDriver[query75] 
(batchId=268)
org.apache.hadoop.hive.cli.TestSparkPerfCliDriver.testCliDriver[query76] 
(batchId=268)
org.apache.hadoop.hive.cli.TestSparkPerfCliDriver.testCliDriver[query77] 
(batchId=268)
org.apache.hadoop.hive.cli.TestSparkPerfCliDriver.testCliDriver[query78] 
(batchId=268)
org.apache.hadoop.hive.cli.TestSparkPerfCliDriver.testCliDriver[query79] 
(batchId=268)
org.apache.hadoop.hive.cli.TestSparkPerfCliDriver.testCliDriver[query7] 
(batchId=268)
org.apache.hadoop.hive.cli.TestSparkPerfCliDriver.testCliDriver[query80] 
(batchId=268)
org.apache.hadoop.hive.cli.TestSparkPerfCliDriver.testCliDriver[query81] 
(batchId=268)
org.apache.hadoop.hive.cli.TestSparkPerfCliDriver.testCliDriver[query82] 
(batchId=268)
org.apache.hadoop.hive.cli.TestSparkPerfCliDriver.testCliDriver[query83] 
(batchId=268)
org.apache.hadoop.hive.cli.TestSparkPerfCliDriver.testCliDriver[query85] 
(batchId=268)
org.apache.hadoop.hive.cli.TestSparkPerfCliDriver.testCliDriver[query86] 
(batchId=268)
org.apache.hadoop.hive.cli.TestSparkPerfCliDriver.testCliDriver[query87] 
(batchId=268)
org.apache.hadoop.hive.cli.TestSparkPerfCliDriver.testCliDriver[query89] 
(batchId=268)
org.apache.hadoop.hive.cli.TestSparkPerfCliDriver.testCliDriver[query8] 
(batchId=268)
org.apache.hadoop.hive.cli.TestSparkPerfCliDriver.testCliDriver[query90] 
(batchId=268)
org.apache.hadoop.hive.cli.TestSparkPerfCliDriver.testCliDriver[query91] 
(batchId=268)
org.apache.hadoop.hive.cli.TestSparkPerfCliDriver.testCliDriver[query97] 
(batchId=268)
org.apache.hadoop.hive.cli.TestSparkPerfCliDriver.testCliDriver[query99] 
(batchId=268)
org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[query6] 
(batchId=266)
org.apache.hadoop.hive.ql.exec.TestOperators.testNoConditionalTaskSizeForLlap 
(batchId=301)
{noformat}

Test results: 
https://builds.apache.org/job/PreCommit-HIVE-Build/14439/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/14439/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-14439/

Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.YetusPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 99 tests failed
{noformat}

This message is automatically generated.

ATTACHMENT ID: 12943729 - PreCommit-HIVE-Build

> Use percentage for join conversion size thresholds
> --------------------------------------------------
>
>                 Key: HIVE-20713
>                 URL: https://issues.apache.org/jira/browse/HIVE-20713
>             Project: Hive
>          Issue Type: Improvement
>    Affects Versions: 4.0.0
>            Reporter: Prasanth Jayachandran
>            Assignee: Prasanth Jayachandran
>            Priority: Major
>         Attachments: HIVE-20713.1.patch
>
>
> There are many places in join conversion that rely on absolute byte sizes for 
> join conversions (mapjoin, dynamic hashjoin etc.). When container sizes 
> change, these join conversion thresholds have to be tuned accordingly 
> according to the new container size. Instead, make the join conversions byte 
> sizes a percentage/fraction of  container size. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to