[ https://issues.apache.org/jira/browse/HIVE-20639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16641385#comment-16641385 ]
Hive QA commented on HIVE-20639: -------------------------------- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | || || || || {color:brown} master Compile Tests {color} || | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 32s{color} | {color:blue} Maven dependency ordering for branch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 7m 45s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 32s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 58s{color} | {color:green} master passed {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m 20s{color} | {color:blue} itests/qtest-druid in master has 6 extant Findbugs warnings. {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m 22s{color} | {color:blue} kafka-handler in master has 1 extant Findbugs warnings. {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 4m 0s{color} | {color:blue} ql in master has 2320 extant Findbugs warnings. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 18s{color} | {color:green} master passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 9s{color} | {color:blue} Maven dependency ordering for patch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 2m 12s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 32s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m 32s{color} | {color:green} the patch passed {color} | | {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m 10s{color} | {color:red} kafka-handler: The patch generated 95 new + 12 unchanged - 11 fixed = 107 total (was 23) {color} | | {color:red}-1{color} | {color:red} whitespace {color} | {color:red} 0m 0s{color} | {color:red} The patch has 38 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply {color} | | {color:red}-1{color} | {color:red} whitespace {color} | {color:red} 0m 0s{color} | {color:red} The patch 10 line(s) with tabs. {color} | | {color:green}+1{color} | {color:green} xml {color} | {color:green} 0m 3s{color} | {color:green} The patch has no ill-formed XML file. {color} | | {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 0m 33s{color} | {color:red} kafka-handler generated 2 new + 0 unchanged - 1 fixed = 2 total (was 1) {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 17s{color} | {color:green} the patch passed {color} | || || || || {color:brown} Other Tests {color} || | {color:red}-1{color} | {color:red} asflicense {color} | {color:red} 0m 13s{color} | {color:red} The patch generated 1 ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 29m 20s{color} | {color:black} {color} | \\ \\ || Reason || Tests || | FindBugs | module:kafka-handler | | | Found reliance on default encoding in org.apache.hadoop.hive.kafka.KafkaSerDe$TextBytesConverter.getBytes(Text):in org.apache.hadoop.hive.kafka.KafkaSerDe$TextBytesConverter.getBytes(Text): String.getBytes() At KafkaSerDe.java:[line 360] | | | Boxing/unboxing to parse a primitive org.apache.hadoop.hive.kafka.KafkaStorageHandler.commitInsertTable(Table, boolean) At KafkaStorageHandler.java:org.apache.hadoop.hive.kafka.KafkaStorageHandler.commitInsertTable(Table, boolean) At KafkaStorageHandler.java:[line 237] | \\ \\ || Subsystem || Report/Notes || | Optional Tests | asflicense javac javadoc xml compile findbugs checkstyle | | uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 3.16.36-1+deb8u1 (2016-09-03) x86_64 GNU/Linux | | Build tool | maven | | Personality | /data/hiveptest/working/yetus_PreCommit-HIVE-Build-14306/dev-support/hive-personality.sh | | git revision | master / 61a027a | | Default Java | 1.8.0_111 | | findbugs | v3.0.0 | | checkstyle | http://104.198.109.242/logs//PreCommit-HIVE-Build-14306/yetus/diff-checkstyle-kafka-handler.txt | | whitespace | http://104.198.109.242/logs//PreCommit-HIVE-Build-14306/yetus/whitespace-eol.txt | | whitespace | http://104.198.109.242/logs//PreCommit-HIVE-Build-14306/yetus/whitespace-tabs.txt | | findbugs | http://104.198.109.242/logs//PreCommit-HIVE-Build-14306/yetus/new-findbugs-kafka-handler.html | | asflicense | http://104.198.109.242/logs//PreCommit-HIVE-Build-14306/yetus/patch-asflicense-problems.txt | | modules | C: itests/qtest-druid kafka-handler ql U: . | | Console output | http://104.198.109.242/logs//PreCommit-HIVE-Build-14306/yetus.txt | | Powered by | Apache Yetus http://yetus.apache.org | This message was automatically generated. > Add ability to Write Data from Hive Table/Query to Kafka Topic > -------------------------------------------------------------- > > Key: HIVE-20639 > URL: https://issues.apache.org/jira/browse/HIVE-20639 > Project: Hive > Issue Type: New Feature > Components: kafka integration > Reporter: slim bouguerra > Assignee: slim bouguerra > Priority: Major > Attachments: HIVE-20639.2.patch, HIVE-20639.3.patch, > HIVE-20639.4.patch, HIVE-20639.4.patch, HIVE-20639.patch > > > This patch adds multiple record writers to allow Hive user writing data > directly to a Kafka Topic. > The end goal is have a writer that provides multiple write semantics modes. > * A BEST_EFFORT where all the records will be delivered with no guarantee or > reties eg best effort mode. (Done) > * B At_least_once, each record will be delivered with retries from the Kafka > Producer and Hive Write Task. (Done) > * C Exactly_once , Writer will be using Kafka Transaction API to ensure that > each record is delivered once. (not so, still need more discussions) > In addition to the new feature i have refactored the existing code to make it > more readable. -- This message was sent by Atlassian JIRA (v7.6.3#76005)