[ https://issues.apache.org/jira/browse/HIVE-20651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16641126#comment-16641126 ]
Hive QA commented on HIVE-20651: -------------------------------- Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12942708/HIVE-20651.7.patch {color:green}SUCCESS:{color} +1 due to 2 test(s) being added or modified. {color:green}SUCCESS:{color} +1 due to 15030 tests passed Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/14294/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/14294/console Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-14294/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.YetusPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase {noformat} This message is automatically generated. ATTACHMENT ID: 12942708 - PreCommit-HIVE-Build > JdbcStorageHandler password should be encrypted > ----------------------------------------------- > > Key: HIVE-20651 > URL: https://issues.apache.org/jira/browse/HIVE-20651 > Project: Hive > Issue Type: Improvement > Components: StorageHandler > Reporter: Daniel Dai > Assignee: Daniel Dai > Priority: Major > Attachments: HIVE-20651.1.patch, HIVE-20651.2.patch, > HIVE-20651.3.patch, HIVE-20651.4.patch, HIVE-20651.5.patch, > HIVE-20651.6.patch, HIVE-20651.7.patch > > > Currently, external jdbc table with JdbcStorageHandler store password as > "hive.sql.dbcp.password" table property in clear text. We should put it in a > keystore file. Here is the proposed change: > {code:java} > …. > STORED BY 'org.apache.hive.storage.jdbc.JdbcStorageHandler' > TBLPROPERTIES ( > "hive.sql.dbcp.password.keystore" = > "hdfs:///user/hive/credential/postgres.jceks", > "hive.sql.dbcp.password.key" = "mydb.password" > ); > {code} > > The jceks file is created with: > {code} > hadoop credential create mydb.password -provider > hdfs:///user/hive/credential/postgres.jceks -v secretpassword > {code} > User can choose to put all db password in one jceks, or a separate jceks for > each db. -- This message was sent by Atlassian JIRA (v7.6.3#76005)