[ https://issues.apache.org/jira/browse/HIVE-20651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16631977#comment-16631977 ]
Janaki Lahorani commented on HIVE-20651: ---------------------------------------- Thanks [~daijy]. I took a brief look. Please evaluate if we need to do the same at https://github.com/apache/hive/blob/master/ql/src/java/org/apache/hadoop/hive/ql/exec/spark/SparkMapRecordHandler.java#L72 It will be great you could make sure that your test runs clean with TestMiniSparkOnYarnCliDriver or TestSparkCliDriver. Also we need to check if jdbc_handler.q runs clean with TestMiniSparkOnYarnCliDriver or TestSparkCliDriver. > JdbcStorageHandler password should be encrypted > ----------------------------------------------- > > Key: HIVE-20651 > URL: https://issues.apache.org/jira/browse/HIVE-20651 > Project: Hive > Issue Type: Improvement > Components: StorageHandler > Reporter: Daniel Dai > Assignee: Daniel Dai > Priority: Major > Attachments: HIVE-20651.1.patch > > > Currently, external jdbc table with JdbcStorageHandler store password as > "hive.sql.dbcp.password" table property in clear text. We should put it in a > keystore file. Here is the proposed change: > {code:java} > …. > STORED BY 'org.apache.hive.storage.jdbc.JdbcStorageHandler' > TBLPROPERTIES ( > "hive.sql.dbcp.password.keystore" = > "hdfs:///user/hive/credential/postgres.jceks", > "hive.sql.dbcp.password.key" = "mydb.password" > ); > {code} > > The jceks file is created with: > {code} > hadoop credential create mydb.password -provider > hdfs:///user/hive/credential/postgres.jceks -v secretpassword > {code} > User can choose to put all db password in one jceks, or a separate jceks for > each db. -- This message was sent by Atlassian JIRA (v7.6.3#76005)