[ 
https://issues.apache.org/jira/browse/HIVE-17917?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Saurabh Seth updated HIVE-17917:
--------------------------------
    Attachment: HIVE-17917.2.patch
        Status: Patch Available  (was: In Progress)

 

Fixed the checkstyle and findbugs errors. These were pre-existing ones but 
because they were on lines where I made minor changes, they were reported as 
new ones. These were trivial ones, so I fixed them:

./ql/src/java/org/apache/hadoop/hive/ql/io/orc/VectorizedOrcAcidRowBatchReader.java:266:
 return new OrcSplit.OffsetAndBucketProperty(-1,-1, 
syntheticTxnInfo.syntheticWriteId);:56: warning: ',' is not followed by 
whitespace.

Redundant null check at VectorizedOrcAcidRowBatchReader.java:[line 495]

> VectorizedOrcAcidRowBatchReader.computeOffsetAndBucket optimization
> -------------------------------------------------------------------
>
>                 Key: HIVE-17917
>                 URL: https://issues.apache.org/jira/browse/HIVE-17917
>             Project: Hive
>          Issue Type: Sub-task
>          Components: Transactions
>    Affects Versions: 3.0.0
>            Reporter: Eugene Koifman
>            Assignee: Saurabh Seth
>            Priority: Minor
>         Attachments: HIVE-17917.2.patch, HIVE-17917.patch
>
>
> VectorizedOrcAcidRowBatchReader.computeOffsetAndBucket optimization() 
> computation is currently (after HIVE-17458) is done once per split.  It could 
> instead be done once per file (since the result is the same for each split of 
> the same file) and passed along in OrcSplit



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to