[ 
https://issues.apache.org/jira/browse/HIVE-18876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16619384#comment-16619384
 ] 

Hive QA commented on HIVE-18876:
--------------------------------



Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12940090/HIVE-18876.2.patch

{color:red}ERROR:{color} -1 due to no test(s) being added or modified.

{color:green}SUCCESS:{color} +1 due to 14976 tests passed

Test results: 
https://builds.apache.org/job/PreCommit-HIVE-Build/13883/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/13883/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-13883/

Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.YetusPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
{noformat}

This message is automatically generated.

ATTACHMENT ID: 12940090 - PreCommit-HIVE-Build

> Remove Superfluous Logging in Driver
> ------------------------------------
>
>                 Key: HIVE-18876
>                 URL: https://issues.apache.org/jira/browse/HIVE-18876
>             Project: Hive
>          Issue Type: Sub-task
>          Components: HiveServer2
>    Affects Versions: 3.0.0
>            Reporter: BELUGA BEHR
>            Assignee: Alice Fan
>            Priority: Trivial
>              Labels: noob
>         Attachments: HIVE-18876.1.patch, HIVE-18876.2.patch
>
>
> [https://github.com/apache/hive/blob/a4198f584aa0792a16d1e1eeb2ef3147403b8acb/ql/src/java/org/apache/hadoop/hive/ql/Driver.java#L2188-L2190]
> {code:java}
>     if (console != null) {
>       console.printInfo("OK");
>     }
> {code}
>  # Console can never be 'null'
>  # OK is not an informative logging message, and in the HiveServer2 logs, it 
> is often interwoven into the logging and is pretty much useless on its own, 
> without having to trace back through the logs to see what happened before it. 
>  This is also printed out, even if an error occurred
> Please remove this block of code.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to