[ https://issues.apache.org/jira/browse/HIVE-20296?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16609505#comment-16609505 ]
Hive QA commented on HIVE-20296: -------------------------------- Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12939058/HIVE-20296.03.patch {color:green}SUCCESS:{color} +1 due to 1 test(s) being added or modified. {color:green}SUCCESS:{color} +1 due to 14933 tests passed Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/13699/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/13699/console Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-13699/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.YetusPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase {noformat} This message is automatically generated. ATTACHMENT ID: 12939058 - PreCommit-HIVE-Build > Improve HivePointLookupOptimizerRule to be able to extract from more > sophisticated contexts > ------------------------------------------------------------------------------------------- > > Key: HIVE-20296 > URL: https://issues.apache.org/jira/browse/HIVE-20296 > Project: Hive > Issue Type: Improvement > Components: Logical Optimizer > Reporter: Zoltan Haindrich > Assignee: Zoltan Haindrich > Priority: Major > Attachments: HIVE-20296.01.patch, HIVE-20296.01wip01.patch, > HIVE-20296.01wip02.patch, HIVE-20296.01wip03.patch, HIVE-20296.02.patch, > HIVE-20296.02.patch, HIVE-20296.03.patch > > > Currently it could handle conditions in the form: > {code} > ( ( a=1 && b=1 && ... ) || (a=2 && b=2 && ...) || ... ) > {code} > If there is some noise somewhere in the or like: > {code} > ( x=18 || ( a=1 && b=1 && ... ) || (a=2 && b=2 && ...) || ... ) > {code} > it stops processing. > https://github.com/apache/hive/blob/2cabb8da150b8fb980223fbd6c2c93b842ca3ee5/ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HivePointLookupOptimizerRule.java#L238 > HIVE-19097 right now unwinds some ors which can't be packed back; like query15 > https://github.com/apache/hive/blob/2cabb8da150b8fb980223fbd6c2c93b842ca3ee5/ql/src/test/queries/clientpositive/perf/query15.q#L14 -- This message was sent by Atlassian JIRA (v7.6.3#76005)