[ https://issues.apache.org/jira/browse/HIVE-20202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16609395#comment-16609395 ]
Hive QA commented on HIVE-20202: -------------------------------- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | || || || || {color:brown} master Compile Tests {color} || | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 38s{color} | {color:blue} Maven dependency ordering for branch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 8m 2s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 6m 31s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 36s{color} | {color:green} master passed {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m 32s{color} | {color:blue} common in master has 64 extant Findbugs warnings. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 7m 12s{color} | {color:green} master passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 7s{color} | {color:blue} Maven dependency ordering for patch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 7m 8s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 6m 39s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 6m 39s{color} | {color:green} the patch passed {color} | | {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m 12s{color} | {color:red} common: The patch generated 12 new + 19 unchanged - 0 fixed = 31 total (was 19) {color} | | {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m 22s{color} | {color:red} root: The patch generated 12 new + 19 unchanged - 0 fixed = 31 total (was 19) {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 0m 44s{color} | {color:red} common generated 1 new + 64 unchanged - 0 fixed = 65 total (was 64) {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 7m 12s{color} | {color:green} the patch passed {color} | || || || || {color:brown} Other Tests {color} || | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 12s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 46m 43s{color} | {color:black} {color} | \\ \\ || Reason || Tests || | FindBugs | module:common | | | Class org.apache.hive.http.ProfileServlet defines non-transient non-serializable instance field process In ProfileServlet.java:instance field process In ProfileServlet.java | \\ \\ || Subsystem || Report/Notes || | Optional Tests | asflicense javac javadoc findbugs checkstyle compile | | uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 3.16.36-1+deb8u1 (2016-09-03) x86_64 GNU/Linux | | Build tool | maven | | Personality | /data/hiveptest/working/yetus_PreCommit-HIVE-Build-13698/dev-support/hive-personality.sh | | git revision | master / c30dcbb | | Default Java | 1.8.0_111 | | findbugs | v3.0.0 | | checkstyle | http://104.198.109.242/logs//PreCommit-HIVE-Build-13698/yetus/diff-checkstyle-common.txt | | checkstyle | http://104.198.109.242/logs//PreCommit-HIVE-Build-13698/yetus/diff-checkstyle-root.txt | | findbugs | http://104.198.109.242/logs//PreCommit-HIVE-Build-13698/yetus/new-findbugs-common.html | | modules | C: common . U: . | | Console output | http://104.198.109.242/logs//PreCommit-HIVE-Build-13698/yetus.txt | | Powered by | Apache Yetus http://yetus.apache.org | This message was automatically generated. > Add profiler endpoint to HS2 and LLAP > ------------------------------------- > > Key: HIVE-20202 > URL: https://issues.apache.org/jira/browse/HIVE-20202 > Project: Hive > Issue Type: New Feature > Affects Versions: 4.0.0, 3.2.0 > Reporter: Prasanth Jayachandran > Assignee: Prasanth Jayachandran > Priority: Major > Attachments: HIVE-20202.1.patch, HIVE-20202.2.patch, > HIVE-20202.3.patch, HIVE-20202.4.patch, HIVE-20202.5.patch, > HIVE-20202.6.patch, HIVE-20202.7.patch, HIVE-20202.8.patch > > > Add a web endpoint for profiling based on async-profiler. This servlet should > be added to httpserver so that HS2 and LLAP daemons can output flamegraphs > when their /prof endpoint is hit. Since this will be based on > [https://github.com/jvm-profiling-tools/async-profiler] heap allocation, lock > contentions, HW counters etc. will also be supported in addition to cpu > profiling. In most cases the profiling overhead is pretty low and is safe to > run on production. More analysis on CPU and memory overhead here > [https://github.com/jvm-profiling-tools/async-profiler/issues/14] and > [https://github.com/jvm-profiling-tools/async-profiler/issues/131] > > For the impatient, here is the usage doc and the sample output > [https://github.com/prasanthj/nightswatch/blob/master/README.md] -- This message was sent by Atlassian JIRA (v7.6.3#76005)