[ https://issues.apache.org/jira/browse/HIVE-20520?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16608070#comment-16608070 ]
Hive QA commented on HIVE-20520: -------------------------------- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | || || || || {color:brown} master Compile Tests {color} || | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 40s{color} | {color:blue} Maven dependency ordering for branch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 7m 50s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 6s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 41s{color} | {color:green} master passed {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 3m 59s{color} | {color:blue} ql in master has 2310 extant Findbugs warnings. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 59s{color} | {color:green} master passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 9s{color} | {color:blue} Maven dependency ordering for patch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m 23s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 6s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m 6s{color} | {color:green} the patch passed {color} | | {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m 39s{color} | {color:red} ql: The patch generated 6 new + 35 unchanged - 0 fixed = 41 total (was 35) {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 4m 12s{color} | {color:red} ql generated 3 new + 2310 unchanged - 0 fixed = 2313 total (was 2310) {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 2s{color} | {color:green} the patch passed {color} | || || || || {color:brown} Other Tests {color} || | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 14s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 24m 33s{color} | {color:black} {color} | \\ \\ || Reason || Tests || | FindBugs | module:ql | | | Switch statement found in org.apache.hadoop.hive.ql.udf.generic.GenericUDFCharacterLength.initialize(ObjectInspector[]) where one case falls through to the next case At GenericUDFCharacterLength.java:where one case falls through to the next case At GenericUDFCharacterLength.java:[lines 65-68] | | | Switch statement found in org.apache.hadoop.hive.ql.udf.generic.GenericUDFLength.initialize(ObjectInspector[]) where one case falls through to the next case At GenericUDFLength.java:where one case falls through to the next case At GenericUDFLength.java:[lines 70-73] | | | Switch statement found in org.apache.hadoop.hive.ql.udf.generic.GenericUDFOctetLength.initialize(ObjectInspector[]) where one case falls through to the next case At GenericUDFOctetLength.java:where one case falls through to the next case At GenericUDFOctetLength.java:[lines 65-68] | \\ \\ || Subsystem || Report/Notes || | Optional Tests | asflicense javac javadoc findbugs checkstyle compile | | uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 3.16.36-1+deb8u1 (2016-09-03) x86_64 GNU/Linux | | Build tool | maven | | Personality | /data/hiveptest/working/yetus_PreCommit-HIVE-Build-13666/dev-support/hive-personality.sh | | git revision | master / b1a917c | | Default Java | 1.8.0_111 | | findbugs | v3.0.0 | | checkstyle | http://104.198.109.242/logs//PreCommit-HIVE-Build-13666/yetus/diff-checkstyle-ql.txt | | findbugs | http://104.198.109.242/logs//PreCommit-HIVE-Build-13666/yetus/new-findbugs-ql.html | | modules | C: itests ql U: . | | Console output | http://104.198.109.242/logs//PreCommit-HIVE-Build-13666/yetus.txt | | Powered by | Apache Yetus http://yetus.apache.org | This message was automatically generated. > length(CHAR) doesn't consider trailing space > -------------------------------------------- > > Key: HIVE-20520 > URL: https://issues.apache.org/jira/browse/HIVE-20520 > Project: Hive > Issue Type: Bug > Components: UDF > Reporter: Naresh P R > Assignee: Jesus Camacho Rodriguez > Priority: Major > Attachments: HIVE-20520.patch > > > Reproduce steps: > {code:java} > create table test(a char(2), b varchar(2)); > insert into test values('L ', 'L '); > select length(a),length(b) from test; > +------+------+ > | _c0 | _c1 | > +------+------+ > | 1 | 2 | > +------+------+ > 1 row selected (0.185 seconds) > {code} > Here char with trailing spaces are trimmed, whereas leading spaces are not > trimmed. -- This message was sent by Atlassian JIRA (v7.6.3#76005)