[ https://issues.apache.org/jira/browse/HIVE-20513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16606764#comment-16606764 ]
Hive QA commented on HIVE-20513: -------------------------------- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | || || || || {color:brown} master Compile Tests {color} || | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 38s{color} | {color:blue} Maven dependency ordering for branch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 7m 59s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 28s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 57s{color} | {color:green} master passed {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m 41s{color} | {color:blue} serde in master has 195 extant Findbugs warnings. {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 3m 57s{color} | {color:blue} ql in master has 2310 extant Findbugs warnings. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 17s{color} | {color:green} master passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 9s{color} | {color:blue} Maven dependency ordering for patch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m 51s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 30s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m 30s{color} | {color:green} the patch passed {color} | | {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m 43s{color} | {color:red} ql: The patch generated 74 new + 18 unchanged - 13 fixed = 92 total (was 31) {color} | | {color:red}-1{color} | {color:red} whitespace {color} | {color:red} 0m 0s{color} | {color:red} The patch 3 line(s) with tabs. {color} | | {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 4m 27s{color} | {color:red} ql generated 8 new + 2310 unchanged - 0 fixed = 2318 total (was 2310) {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 15s{color} | {color:green} the patch passed {color} | || || || || {color:brown} Other Tests {color} || | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 13s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 28m 59s{color} | {color:black} {color} | \\ \\ || Reason || Tests || | FindBugs | module:ql | | | Should org.apache.hadoop.hive.ql.exec.vector.mapjoin.fast.VectorMapJoinFastBytesHashKeyRef$KeyRef$AbsoluteOffset be a _static_ inner class? At VectorMapJoinFastBytesHashKeyRef.java:inner class? At VectorMapJoinFastBytesHashKeyRef.java:[line 96] | | | Should org.apache.hadoop.hive.ql.exec.vector.mapjoin.fast.VectorMapJoinFastBytesHashKeyRef$KeyRef$IsInvalidFlag be a _static_ inner class? At VectorMapJoinFastBytesHashKeyRef.java:inner class? At VectorMapJoinFastBytesHashKeyRef.java:[line 137] | | | Should org.apache.hadoop.hive.ql.exec.vector.mapjoin.fast.VectorMapJoinFastBytesHashKeyRef$KeyRef$IsSingleFlag be a _static_ inner class? At VectorMapJoinFastBytesHashKeyRef.java:inner class? At VectorMapJoinFastBytesHashKeyRef.java:[line 126] | | | Should org.apache.hadoop.hive.ql.exec.vector.mapjoin.fast.VectorMapJoinFastBytesHashKeyRef$KeyRef$PartialHashCode be a _static_ inner class? At VectorMapJoinFastBytesHashKeyRef.java:inner class? At VectorMapJoinFastBytesHashKeyRef.java:[line 84] | | | Should org.apache.hadoop.hive.ql.exec.vector.mapjoin.fast.VectorMapJoinFastBytesHashKeyRef$KeyRef$SmallKeyLength be a _static_ inner class? At VectorMapJoinFastBytesHashKeyRef.java:inner class? At VectorMapJoinFastBytesHashKeyRef.java:[line 113] | | | Unread field:VectorMapJoinFastBytesHashMultiSetStore.java:[line 139] | | | Unread field:VectorMapJoinFastBytesHashSetStore.java:[line 134] | | | Unread field:VectorMapJoinFastBytesHashSetStore.java:[line 108] | \\ \\ || Subsystem || Report/Notes || | Optional Tests | asflicense javac javadoc findbugs checkstyle compile | | uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 3.16.36-1+deb8u1 (2016-09-03) x86_64 GNU/Linux | | Build tool | maven | | Personality | /data/hiveptest/working/yetus_PreCommit-HIVE-Build-13638/dev-support/hive-personality.sh | | git revision | master / 2072004 | | Default Java | 1.8.0_111 | | findbugs | v3.0.0 | | checkstyle | http://104.198.109.242/logs//PreCommit-HIVE-Build-13638/yetus/diff-checkstyle-ql.txt | | whitespace | http://104.198.109.242/logs//PreCommit-HIVE-Build-13638/yetus/whitespace-tabs.txt | | findbugs | http://104.198.109.242/logs//PreCommit-HIVE-Build-13638/yetus/new-findbugs-ql.html | | modules | C: serde ql U: . | | Console output | http://104.198.109.242/logs//PreCommit-HIVE-Build-13638/yetus.txt | | Powered by | Apache Yetus http://yetus.apache.org | This message was automatically generated. > Vectorization: Improve Fast Vector MapJoin Bytes Hash Tables > ------------------------------------------------------------ > > Key: HIVE-20513 > URL: https://issues.apache.org/jira/browse/HIVE-20513 > Project: Hive > Issue Type: Bug > Components: Hive > Reporter: Matt McCline > Assignee: Matt McCline > Priority: Critical > Attachments: HIVE-20513.01.patch > > > Based on HIVE-20491 discussions, improve Fast Vector MapJoin Bytes Hash > Tables by only storing a one word slot entry. -- This message was sent by Atlassian JIRA (v7.6.3#76005)