[ https://issues.apache.org/jira/browse/HIVE-20246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16581733#comment-16581733 ]
Aihua Xu commented on HIVE-20246: --------------------------------- The change looks good. Minor change. Probably add comment to the function. The test can just throw Exception rather than throwing many individual ones. The location in the test can be a little real: part.getSd().setLocation(tbl.getSd().getLocation() + "/parCol=3"); > Configurable collecting stats by using DO_NOT_UPDATE_STATS table property > ------------------------------------------------------------------------- > > Key: HIVE-20246 > URL: https://issues.apache.org/jira/browse/HIVE-20246 > Project: Hive > Issue Type: Improvement > Components: Metastore > Reporter: Alice Fan > Assignee: Alice Fan > Priority: Minor > Fix For: 4.0.0 > > Attachments: HIVE-20246.5.patch, HIVE-20246.6.patch > > > By default, Hive collects stats when running operations like alter table > partition(s), create table, and create external table. However, collecting > stats requires Metastore lists all files under the table directory and the > file listing operation can be very expensive particularly on filesystems like > S3. > HIVE-18743 made DO_NOT_UPDATE_STATS table property could be selectively > prevent stats collection. > This Jira aims at introducing DO_NOT_UPDATE_STATS table property into the > MetaStoreUtils.updatePartitionStatsFast. By adding this, user can be > selectively prevent stats collection when doing alter table partition(s) > operation at table level. For example, set 'Alter Table S3_Table set > tblproperties('DO_NOT_UPDATE_STATS'='TRUE');' MetaStore will not collect > stats for the specified S3_Table when alter table add partition(key1=val1, > key2=val2); -- This message was sent by Atlassian JIRA (v7.6.3#76005)