[ https://issues.apache.org/jira/browse/HIVE-20387?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16580759#comment-16580759 ]
Hive QA commented on HIVE-20387: -------------------------------- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | || || || || {color:brown} master Compile Tests {color} || | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 29s{color} | {color:blue} Maven dependency ordering for branch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 8m 4s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 6m 2s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 3m 53s{color} | {color:green} master passed {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m 29s{color} | {color:blue} cli in master has 13 extant Findbugs warnings. {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m 29s{color} | {color:blue} druid-handler in master has 13 extant Findbugs warnings. {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m 38s{color} | {color:blue} hcatalog/core in master has 31 extant Findbugs warnings. {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m 30s{color} | {color:blue} hcatalog/hcatalog-pig-adapter in master has 2 extant Findbugs warnings. {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m 29s{color} | {color:blue} hcatalog/server-extensions in master has 3 extant Findbugs warnings. {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m 30s{color} | {color:blue} hcatalog/streaming in master has 11 extant Findbugs warnings. {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m 28s{color} | {color:blue} hcatalog/webhcat/java-client in master has 3 extant Findbugs warnings. {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m 43s{color} | {color:blue} itests/hive-unit in master has 2 extant Findbugs warnings. {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m 46s{color} | {color:blue} itests/util in master has 52 extant Findbugs warnings. {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 4m 15s{color} | {color:blue} ql in master has 2305 extant Findbugs warnings. {color} | | {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 0m 15s{color} | {color:red} metastore-server in master failed. {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m 27s{color} | {color:blue} streaming in master has 2 extant Findbugs warnings. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 4m 16s{color} | {color:green} master passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 8s{color} | {color:blue} Maven dependency ordering for patch {color} | | {color:red}-1{color} | {color:red} mvninstall {color} | {color:red} 0m 19s{color} | {color:red} cli in the patch failed. {color} | | {color:red}-1{color} | {color:red} mvninstall {color} | {color:red} 0m 17s{color} | {color:red} druid-handler in the patch failed. {color} | | {color:red}-1{color} | {color:red} mvninstall {color} | {color:red} 0m 20s{color} | {color:red} core in the patch failed. {color} | | {color:red}-1{color} | {color:red} mvninstall {color} | {color:red} 0m 18s{color} | {color:red} hcatalog-pig-adapter in the patch failed. {color} | | {color:red}-1{color} | {color:red} mvninstall {color} | {color:red} 0m 18s{color} | {color:red} server-extensions in the patch failed. {color} | | {color:red}-1{color} | {color:red} mvninstall {color} | {color:red} 0m 19s{color} | {color:red} streaming in the patch failed. {color} | | {color:red}-1{color} | {color:red} mvninstall {color} | {color:red} 0m 20s{color} | {color:red} java-client in the patch failed. {color} | | {color:red}-1{color} | {color:red} mvninstall {color} | {color:red} 0m 20s{color} | {color:red} hcatalog-unit in the patch failed. {color} | | {color:red}-1{color} | {color:red} mvninstall {color} | {color:red} 0m 41s{color} | {color:red} hive-unit in the patch failed. {color} | | {color:red}-1{color} | {color:red} mvninstall {color} | {color:red} 0m 28s{color} | {color:red} util in the patch failed. {color} | | {color:red}-1{color} | {color:red} mvninstall {color} | {color:red} 0m 48s{color} | {color:red} ql in the patch failed. {color} | | {color:red}-1{color} | {color:red} compile {color} | {color:red} 0m 17s{color} | {color:red} druid-handler in the patch failed. {color} | | {color:red}-1{color} | {color:red} javac {color} | {color:red} 0m 17s{color} | {color:red} druid-handler in the patch failed. {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 11s{color} | {color:green} The patch cli passed checkstyle {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 13s{color} | {color:green} The patch druid-handler passed checkstyle {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 16s{color} | {color:green} hcatalog/core: The patch generated 0 new + 206 unchanged - 1 fixed = 206 total (was 207) {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 11s{color} | {color:green} The patch hcatalog-pig-adapter passed checkstyle {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 12s{color} | {color:green} The patch server-extensions passed checkstyle {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 15s{color} | {color:green} hcatalog/streaming: The patch generated 0 new + 104 unchanged - 4 fixed = 104 total (was 108) {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 15s{color} | {color:green} hcatalog/webhcat/java-client: The patch generated 0 new + 201 unchanged - 1 fixed = 201 total (was 202) {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 13s{color} | {color:green} itests/hcatalog-unit: The patch generated 0 new + 8 unchanged - 1 fixed = 8 total (was 9) {color} | | {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m 24s{color} | {color:red} itests/hive-unit: The patch generated 2 new + 546 unchanged - 2 fixed = 548 total (was 548) {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 16s{color} | {color:green} The patch util passed checkstyle {color} | | {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 1m 12s{color} | {color:red} ql: The patch generated 2 new + 2148 unchanged - 13 fixed = 2150 total (was 2161) {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 9s{color} | {color:green} The patch metastore-server passed checkstyle {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 12s{color} | {color:green} The patch streaming passed checkstyle {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 0m 16s{color} | {color:red} druid-handler in the patch failed. {color} | | {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 0m 43s{color} | {color:red} itests/hive-unit cannot run computeBugHistory from findbugs {color} | | {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 0m 48s{color} | {color:red} itests/util cannot run computeBugHistory from findbugs {color} | | {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 4m 12s{color} | {color:red} ql cannot run computeBugHistory from findbugs {color} | | {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 0m 15s{color} | {color:red} metastore-server in the patch failed. {color} | | {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 0m 26s{color} | {color:red} streaming cannot run computeBugHistory from findbugs {color} | | {color:red}-1{color} | {color:red} javadoc {color} | {color:red} 0m 32s{color} | {color:red} hcatalog_server-extensions generated 1 new + 1 unchanged - 0 fixed = 2 total (was 1) {color} | | {color:red}-1{color} | {color:red} javadoc {color} | {color:red} 0m 38s{color} | {color:red} itests_util generated 1 new + 9 unchanged - 0 fixed = 10 total (was 9) {color} | || || || || {color:brown} Other Tests {color} || | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 37s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 69m 53s{color} | {color:black} {color} | \\ \\ || Subsystem || Report/Notes || | Optional Tests | asflicense javac javadoc findbugs checkstyle compile | | uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 3.16.36-1+deb8u1 (2016-09-03) x86_64 GNU/Linux | | Build tool | maven | | Personality | /data/hiveptest/working/yetus_PreCommit-HIVE-Build-13229/dev-support/hive-personality.sh | | git revision | master / 691e654 | | Default Java | 1.8.0_111 | | findbugs | v3.0.0 | | findbugs | http://104.198.109.242/logs//PreCommit-HIVE-Build-13229/yetus/branch-findbugs-standalone-metastore_metastore-server.txt | | mvninstall | http://104.198.109.242/logs//PreCommit-HIVE-Build-13229/yetus/patch-mvninstall-cli.txt | | mvninstall | http://104.198.109.242/logs//PreCommit-HIVE-Build-13229/yetus/patch-mvninstall-druid-handler.txt | | mvninstall | http://104.198.109.242/logs//PreCommit-HIVE-Build-13229/yetus/patch-mvninstall-hcatalog_core.txt | | mvninstall | http://104.198.109.242/logs//PreCommit-HIVE-Build-13229/yetus/patch-mvninstall-hcatalog_hcatalog-pig-adapter.txt | | mvninstall | http://104.198.109.242/logs//PreCommit-HIVE-Build-13229/yetus/patch-mvninstall-hcatalog_server-extensions.txt | | mvninstall | http://104.198.109.242/logs//PreCommit-HIVE-Build-13229/yetus/patch-mvninstall-hcatalog_streaming.txt | | mvninstall | http://104.198.109.242/logs//PreCommit-HIVE-Build-13229/yetus/patch-mvninstall-hcatalog_webhcat_java-client.txt | | mvninstall | http://104.198.109.242/logs//PreCommit-HIVE-Build-13229/yetus/patch-mvninstall-itests_hcatalog-unit.txt | | mvninstall | http://104.198.109.242/logs//PreCommit-HIVE-Build-13229/yetus/patch-mvninstall-itests_hive-unit.txt | | mvninstall | http://104.198.109.242/logs//PreCommit-HIVE-Build-13229/yetus/patch-mvninstall-itests_util.txt | | mvninstall | http://104.198.109.242/logs//PreCommit-HIVE-Build-13229/yetus/patch-mvninstall-ql.txt | | compile | http://104.198.109.242/logs//PreCommit-HIVE-Build-13229/yetus/patch-compile-druid-handler.txt | | javac | http://104.198.109.242/logs//PreCommit-HIVE-Build-13229/yetus/patch-compile-druid-handler.txt | | checkstyle | http://104.198.109.242/logs//PreCommit-HIVE-Build-13229/yetus/diff-checkstyle-itests_hive-unit.txt | | checkstyle | http://104.198.109.242/logs//PreCommit-HIVE-Build-13229/yetus/diff-checkstyle-ql.txt | | findbugs | http://104.198.109.242/logs//PreCommit-HIVE-Build-13229/yetus/patch-findbugs-druid-handler.txt | | findbugs | http://104.198.109.242/logs//PreCommit-HIVE-Build-13229/yetus/patch-findbugs-itests_hive-unit.txt | | findbugs | http://104.198.109.242/logs//PreCommit-HIVE-Build-13229/yetus/patch-findbugs-itests_util.txt | | findbugs | http://104.198.109.242/logs//PreCommit-HIVE-Build-13229/yetus/patch-findbugs-ql.txt | | findbugs | http://104.198.109.242/logs//PreCommit-HIVE-Build-13229/yetus/patch-findbugs-standalone-metastore_metastore-server.txt | | findbugs | http://104.198.109.242/logs//PreCommit-HIVE-Build-13229/yetus/patch-findbugs-streaming.txt | | javadoc | http://104.198.109.242/logs//PreCommit-HIVE-Build-13229/yetus/diff-javadoc-javadoc-hcatalog_server-extensions.txt | | javadoc | http://104.198.109.242/logs//PreCommit-HIVE-Build-13229/yetus/diff-javadoc-javadoc-itests_util.txt | | modules | C: cli druid-handler hcatalog/core hcatalog/hcatalog-pig-adapter hcatalog/server-extensions hcatalog/streaming hcatalog/webhcat/java-client itests/hcatalog-unit itests/hive-unit itests/util ql standalone-metastore/metastore-server streaming U: . | | Console output | http://104.198.109.242/logs//PreCommit-HIVE-Build-13229/yetus.txt | | Powered by | Apache Yetus http://yetus.apache.org | This message was automatically generated. > Move non-server related methods from Warehouse to MetastoreUtils > ---------------------------------------------------------------- > > Key: HIVE-20387 > URL: https://issues.apache.org/jira/browse/HIVE-20387 > Project: Hive > Issue Type: Sub-task > Components: Standalone Metastore > Affects Versions: 3.0.1, 4.0.0 > Reporter: Alexander Kolbasov > Assignee: Alexander Kolbasov > Priority: Major > Attachments: HIVE-20387.01.patch > > > Most of the functions in Warehouse class are only relevant for the server. > There are some utility methods that are there that we can move to > MetastoreUtils - these are used outside of the server. -- This message was sent by Atlassian JIRA (v7.6.3#76005)