[
https://issues.apache.org/jira/browse/HIVE-20191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16580422#comment-16580422
]
Hive QA commented on HIVE-20191:
--------------------------------
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12935551/HIVE-20191.1.patch
{color:red}ERROR:{color} -1 due to no test(s) being added or modified.
{color:green}SUCCESS:{color} +1 due to 14878 tests passed
Test results:
https://builds.apache.org/job/PreCommit-HIVE-Build/13219/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/13219/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-13219/
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.YetusPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
{noformat}
This message is automatically generated.
ATTACHMENT ID: 12935551 - PreCommit-HIVE-Build
> PreCommit patch application doesn't fail if patch is empty
> ----------------------------------------------------------
>
> Key: HIVE-20191
> URL: https://issues.apache.org/jira/browse/HIVE-20191
> Project: Hive
> Issue Type: Bug
> Components: Testing Infrastructure
> Reporter: Daniel Voros
> Assignee: Daniel Voros
> Priority: Major
> Attachments: HIVE-20191.1.patch
>
>
> I've created some backport tickets to branch-3 (e.g. HIVE-20181) and made the
> mistake of uploading the patch files with wrong filename ({{.}} instead of
> {{-}} between version and branch).
> These get applied on master, where they're already present, since {{git
> apply}} with {{-3}} won't fail if patch is already there. Tests are run on
> master instead of failing.
> I think the patch application should fail if the patch is empty and branch
> selection logic should probably fail too if the patch name is malformed.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
