[ https://issues.apache.org/jira/browse/HIVE-19767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16578843#comment-16578843 ]
Hive QA commented on HIVE-19767: -------------------------------- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | || || || || {color:brown} master Compile Tests {color} || | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 21s{color} | {color:blue} Maven dependency ordering for branch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 7m 44s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 43s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 31s{color} | {color:green} master passed {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m 35s{color} | {color:blue} common in master has 64 extant Findbugs warnings. {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m 40s{color} | {color:blue} service in master has 48 extant Findbugs warnings. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 33s{color} | {color:green} master passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 11s{color} | {color:blue} Maven dependency ordering for patch {color} | | {color:red}-1{color} | {color:red} mvninstall {color} | {color:red} 0m 24s{color} | {color:red} service in the patch failed. {color} | | {color:red}-1{color} | {color:red} compile {color} | {color:red} 0m 23s{color} | {color:red} service in the patch failed. {color} | | {color:red}-1{color} | {color:red} javac {color} | {color:red} 0m 23s{color} | {color:red} service in the patch failed. {color} | | {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m 17s{color} | {color:red} common: The patch generated 1 new + 424 unchanged - 0 fixed = 425 total (was 424) {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 0m 25s{color} | {color:red} service in the patch failed. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 33s{color} | {color:green} the patch passed {color} | || || || || {color:brown} Other Tests {color} || | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 15s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 15m 33s{color} | {color:black} {color} | \\ \\ || Subsystem || Report/Notes || | Optional Tests | asflicense javac javadoc findbugs checkstyle compile | | uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 3.16.36-1+deb8u1 (2016-09-03) x86_64 GNU/Linux | | Build tool | maven | | Personality | /data/hiveptest/working/yetus_PreCommit-HIVE-Build-13194/dev-support/hive-personality.sh | | git revision | master / 681051f | | Default Java | 1.8.0_111 | | findbugs | v3.0.0 | | mvninstall | http://104.198.109.242/logs//PreCommit-HIVE-Build-13194/yetus/patch-mvninstall-service.txt | | compile | http://104.198.109.242/logs//PreCommit-HIVE-Build-13194/yetus/patch-compile-service.txt | | javac | http://104.198.109.242/logs//PreCommit-HIVE-Build-13194/yetus/patch-compile-service.txt | | checkstyle | http://104.198.109.242/logs//PreCommit-HIVE-Build-13194/yetus/diff-checkstyle-common.txt | | findbugs | http://104.198.109.242/logs//PreCommit-HIVE-Build-13194/yetus/patch-findbugs-service.txt | | modules | C: common service U: . | | Console output | http://104.198.109.242/logs//PreCommit-HIVE-Build-13194/yetus.txt | | Powered by | Apache Yetus http://yetus.apache.org | This message was automatically generated. > HiveServer2 should take hiveconf for non Hive properties > -------------------------------------------------------- > > Key: HIVE-19767 > URL: https://issues.apache.org/jira/browse/HIVE-19767 > Project: Hive > Issue Type: Improvement > Affects Versions: 1.2.2, 3.0.0, 2.3.2 > Reporter: Szehon Ho > Assignee: Szehon Ho > Priority: Major > Attachments: HIVE-19767.2.patch, HIVE-19767.3.patch, > HIVE-19767.4.patch, HIVE-19767.5.patch, HIVE-19767.patch > > > The -hiveconf command line option works in HiveServer2 with properties in > HiveConf.java, but not so well with other properties (like mapred properties > or spark properties to control underlying execution engine, or custom > properties understood by custom listeners) > It is inconsistent with HiveCLI. > HiveCLI behavior: > {noformat} > ./bin/hive --hiveconf a=b > hive> set a; > a=b {noformat} > HiveServer2 behavior: > {noformat} > ./bin/hiveserver2 --hiveconf a=b > beeline> set a; > +-----------------+ > | set | > +-----------------+ > | a is undefined | > +-----------------+{noformat} > Although it is possible to set up hive-site.xml or even mapred-site.xml to > fill in the relevant properties, it is more convenient when testing HS2 with > different configuration to be able to use --hiveconf to change on the fly. -- This message was sent by Atlassian JIRA (v7.6.3#76005)