[ https://issues.apache.org/jira/browse/HIVE-20264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16576807#comment-16576807 ]
Hive QA commented on HIVE-20264: -------------------------------- Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12935159/HIVE-20264.01-branch-3.patch {color:green}SUCCESS:{color} +1 due to 2 test(s) being added or modified. {color:red}ERROR:{color} -1 due to 105 failed/errored test(s), 14424 tests executed *Failed tests:* {noformat} TestAddPartitions - did not produce a TEST-*.xml file (likely timed out) (batchId=228) TestAddPartitionsFromPartSpec - did not produce a TEST-*.xml file (likely timed out) (batchId=230) TestAdminUser - did not produce a TEST-*.xml file (likely timed out) (batchId=236) TestAggregateStatsCache - did not produce a TEST-*.xml file (likely timed out) (batchId=230) TestAlterPartitions - did not produce a TEST-*.xml file (likely timed out) (batchId=230) TestAppendPartitions - did not produce a TEST-*.xml file (likely timed out) (batchId=230) TestAutoPurgeTables - did not produce a TEST-*.xml file (likely timed out) (batchId=252) TestBeeLineDriver - did not produce a TEST-*.xml file (likely timed out) (batchId=273) TestCachedStore - did not produce a TEST-*.xml file (likely timed out) (batchId=236) TestCatalogCaching - did not produce a TEST-*.xml file (likely timed out) (batchId=236) TestCatalogNonDefaultClient - did not produce a TEST-*.xml file (likely timed out) (batchId=228) TestCatalogNonDefaultSvr - did not produce a TEST-*.xml file (likely timed out) (batchId=236) TestCatalogOldClient - did not produce a TEST-*.xml file (likely timed out) (batchId=228) TestCatalogs - did not produce a TEST-*.xml file (likely timed out) (batchId=230) TestCheckConstraint - did not produce a TEST-*.xml file (likely timed out) (batchId=228) TestDataSourceProviderFactory - did not produce a TEST-*.xml file (likely timed out) (batchId=238) TestDatabases - did not produce a TEST-*.xml file (likely timed out) (batchId=230) TestDeadline - did not produce a TEST-*.xml file (likely timed out) (batchId=236) TestDefaultConstraint - did not produce a TEST-*.xml file (likely timed out) (batchId=230) TestDropPartitions - did not produce a TEST-*.xml file (likely timed out) (batchId=228) TestDummy - did not produce a TEST-*.xml file (likely timed out) (batchId=273) TestEmbeddedHiveMetaStore - did not produce a TEST-*.xml file (likely timed out) (batchId=231) TestExchangePartitions - did not produce a TEST-*.xml file (likely timed out) (batchId=230) TestFMSketchSerialization - did not produce a TEST-*.xml file (likely timed out) (batchId=238) TestFilterHooks - did not produce a TEST-*.xml file (likely timed out) (batchId=228) TestForeignKey - did not produce a TEST-*.xml file (likely timed out) (batchId=230) TestFunctions - did not produce a TEST-*.xml file (likely timed out) (batchId=228) TestGetPartitions - did not produce a TEST-*.xml file (likely timed out) (batchId=228) TestGetTableMeta - did not produce a TEST-*.xml file (likely timed out) (batchId=228) TestHLLNoBias - did not produce a TEST-*.xml file (likely timed out) (batchId=238) TestHLLSerialization - did not produce a TEST-*.xml file (likely timed out) (batchId=238) TestHdfsUtils - did not produce a TEST-*.xml file (likely timed out) (batchId=236) TestHiveAlterHandler - did not produce a TEST-*.xml file (likely timed out) (batchId=228) TestHiveMetaStoreGetMetaConf - did not produce a TEST-*.xml file (likely timed out) (batchId=236) TestHiveMetaStorePartitionSpecs - did not produce a TEST-*.xml file (likely timed out) (batchId=230) TestHiveMetaStoreSchemaMethods - did not produce a TEST-*.xml file (likely timed out) (batchId=236) TestHiveMetaStoreTimeout - did not produce a TEST-*.xml file (likely timed out) (batchId=238) TestHiveMetaStoreTxns - did not produce a TEST-*.xml file (likely timed out) (batchId=238) TestHiveMetaStoreWithEnvironmentContext - did not produce a TEST-*.xml file (likely timed out) (batchId=233) TestHiveMetastoreCli - did not produce a TEST-*.xml file (likely timed out) (batchId=228) TestHyperLogLog - did not produce a TEST-*.xml file (likely timed out) (batchId=238) TestHyperLogLogDense - did not produce a TEST-*.xml file (likely timed out) (batchId=238) TestHyperLogLogMerge - did not produce a TEST-*.xml file (likely timed out) (batchId=238) TestHyperLogLogSparse - did not produce a TEST-*.xml file (likely timed out) (batchId=238) TestJSONMessageDeserializer - did not produce a TEST-*.xml file (likely timed out) (batchId=236) TestListPartitions - did not produce a TEST-*.xml file (likely timed out) (batchId=228) TestLocationQueries - did not produce a TEST-*.xml file (likely timed out) (batchId=252) TestLockRequestBuilder - did not produce a TEST-*.xml file (likely timed out) (batchId=228) TestMarkPartition - did not produce a TEST-*.xml file (likely timed out) (batchId=236) TestMarkPartitionRemote - did not produce a TEST-*.xml file (likely timed out) (batchId=238) TestMetaStoreConnectionUrlHook - did not produce a TEST-*.xml file (likely timed out) (batchId=230) TestMetaStoreEndFunctionListener - did not produce a TEST-*.xml file (likely timed out) (batchId=230) TestMetaStoreEventListener - did not produce a TEST-*.xml file (likely timed out) (batchId=234) TestMetaStoreEventListenerOnlyOnCommit - did not produce a TEST-*.xml file (likely timed out) (batchId=236) TestMetaStoreEventListenerWithOldConf - did not produce a TEST-*.xml file (likely timed out) (batchId=238) TestMetaStoreInitListener - did not produce a TEST-*.xml file (likely timed out) (batchId=236) TestMetaStoreListenersError - did not produce a TEST-*.xml file (likely timed out) (batchId=236) TestMetaStoreSchemaFactory - did not produce a TEST-*.xml file (likely timed out) (batchId=236) TestMetaStoreSchemaInfo - did not produce a TEST-*.xml file (likely timed out) (batchId=236) TestMetaStoreUtils - did not produce a TEST-*.xml file (likely timed out) (batchId=236) TestMetastoreConf - did not produce a TEST-*.xml file (likely timed out) (batchId=230) TestMetastoreSchemaTool - did not produce a TEST-*.xml file (likely timed out) (batchId=236) TestMetrics - did not produce a TEST-*.xml file (likely timed out) (batchId=230) TestMiniDruidCliDriver - did not produce a TEST-*.xml file (likely timed out) (batchId=273) TestMiniDruidKafkaCliDriver - did not produce a TEST-*.xml file (likely timed out) (batchId=273) TestNotNullConstraint - did not produce a TEST-*.xml file (likely timed out) (batchId=230) TestObjectStore - did not produce a TEST-*.xml file (likely timed out) (batchId=238) TestObjectStoreInitRetry - did not produce a TEST-*.xml file (likely timed out) (batchId=236) TestObjectStoreSchemaMethods - did not produce a TEST-*.xml file (likely timed out) (batchId=238) TestOldSchema - did not produce a TEST-*.xml file (likely timed out) (batchId=236) TestPartitionNameWhitelistValidation - did not produce a TEST-*.xml file (likely timed out) (batchId=230) TestPrimaryKey - did not produce a TEST-*.xml file (likely timed out) (batchId=230) TestRawStoreProxy - did not produce a TEST-*.xml file (likely timed out) (batchId=228) TestRemoteHiveMetaStore - did not produce a TEST-*.xml file (likely timed out) (batchId=232) TestRemoteHiveMetaStoreIpAddress - did not produce a TEST-*.xml file (likely timed out) (batchId=226) TestRemoteUGIHiveMetaStoreIpAddress - did not produce a TEST-*.xml file (likely timed out) (batchId=235) TestRetriesInRetryingHMSHandler - did not produce a TEST-*.xml file (likely timed out) (batchId=238) TestRetryingHMSHandler - did not produce a TEST-*.xml file (likely timed out) (batchId=236) TestRuntimeStats - did not produce a TEST-*.xml file (likely timed out) (batchId=228) TestSchemaToolForMetastore - did not produce a TEST-*.xml file (likely timed out) (batchId=230) TestSetUGIOnBothClientServer - did not produce a TEST-*.xml file (likely timed out) (batchId=229) TestSetUGIOnOnlyClient - did not produce a TEST-*.xml file (likely timed out) (batchId=227) TestSetUGIOnOnlyServer - did not produce a TEST-*.xml file (likely timed out) (batchId=237) TestSparkStatistics - did not produce a TEST-*.xml file (likely timed out) (batchId=252) TestSparseEncodeHash - did not produce a TEST-*.xml file (likely timed out) (batchId=238) TestStats - did not produce a TEST-*.xml file (likely timed out) (batchId=230) TestStatsSetupConst - did not produce a TEST-*.xml file (likely timed out) (batchId=238) TestTableIterable - did not produce a TEST-*.xml file (likely timed out) (batchId=238) TestTablesCreateDropAlterTruncate - did not produce a TEST-*.xml file (likely timed out) (batchId=228) TestTablesGetExists - did not produce a TEST-*.xml file (likely timed out) (batchId=230) TestTablesList - did not produce a TEST-*.xml file (likely timed out) (batchId=228) TestTezPerfCliDriver - did not produce a TEST-*.xml file (likely timed out) (batchId=273) TestTxnHandlerNegative - did not produce a TEST-*.xml file (likely timed out) (batchId=228) TestTxnUtils - did not produce a TEST-*.xml file (likely timed out) (batchId=228) TestUniqueConstraint - did not produce a TEST-*.xml file (likely timed out) (batchId=228) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[masking_mv] (batchId=85) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[mm_all] (batchId=71) org.apache.hadoop.hive.cli.TestMiniLlapCliDriver.testCliDriver[mm_all] (batchId=154) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[materialized_view_partitioned_2] (batchId=173) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[materialized_view_partitioned_3] (batchId=173) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[results_cache_with_masking] (batchId=175) org.apache.hadoop.hive.cli.TestMiniSparkOnYarnCliDriver.testCliDriver[constprog_semijoin] (batchId=189) org.apache.hadoop.hive.ql.TestWarehouseExternalDir.testManagedPaths (batchId=250) org.apache.hive.service.TestHS2ImpersonationWithRemoteMS.testImpersonation (batchId=258) org.apache.hive.spark.client.rpc.TestRpc.testServerPort (batchId=325) {noformat} Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/13153/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/13153/console Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-13153/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.YetusPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase Tests exited with: TestsFailedException: 105 tests failed {noformat} This message is automatically generated. ATTACHMENT ID: 12935159 - PreCommit-HIVE-Build > Bootstrap repl dump with concurrent write and drop of ACID table makes target > inconsistent. > ------------------------------------------------------------------------------------------- > > Key: HIVE-20264 > URL: https://issues.apache.org/jira/browse/HIVE-20264 > Project: Hive > Issue Type: Sub-task > Components: HiveServer2, repl > Affects Versions: 4.0.0, 3.2.0 > Reporter: Sankar Hariappan > Assignee: Sankar Hariappan > Priority: Major > Labels: DR, pull-request-available, replication > Fix For: 4.0.0 > > Attachments: HIVE-20264.01-branch-3.patch, HIVE-20264.01.patch, > HIVE-20264.02.patch > > > During bootstrap dump of ACID tables, let's consider the below sequence. > - Get lastReplId = last event ID logged. > - Current session (Thread-1), REPL DUMP -> Open txn (Txn1) - Event-10 > - Another session (Thread-2), Open txn (Txn2) - Event-11 > - Thread-2 -> Insert data (T1.D1) to ACID table. - Event-12 > - Thread-2 -> Commit Txn (Txn2) - Event-13 > - Thread-2 -> Drop table (T1) - Event-14 > - Thread-1 -> Dump ACID tables based on current list of tables. So, T1 will > be missing. > - Thread-1 -> Commit Txn (Txn1) > - REPL LOAD from bootstrap dump will skip T1. > - Incremental REPL DUMP will start from Event-10 and hence allocate write id > for table T1 and drop table(T1) is idempotent. So, at target, exist entries > in TXN_TO_WRITE_ID and NEXT_WRITE_ID metastore tables. > - Now, when we create another table at source with same name T1 and > replicate, then it may lead to incorrect data for readers at target on T1. > Couple of proposals: > 1. Make allocate write ID idempotent which is not possible as table doesn't > exist and MM table import may lead to allocate write id before creating > table. So, cannot differentiate these 2 cases. > 2. Make Drop table event to drop entries from TXN_TO_WRITE_ID and > NEXT_WRITE_ID tables irrespective of table exist or not at target. -- This message was sent by Atlassian JIRA (v7.6.3#76005)