[ 
https://issues.apache.org/jira/browse/HIVE-11190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14620901#comment-14620901
 ] 

Thejas M Nair commented on HIVE-11190:
--------------------------------------

[~dapengsun] Thanks for the patch, this makes it much better. Can you also make 
following changes while you are at it ? - 
 # replace  the use of the string  
"org.apache.hadoop.hive.ql.security.authorization.plugin.AuthorizationMetaStoreFilterHook"
 with AuthorizationMetaStoreFilterHook.class.getName() ? (less chances of typos 
happening).
 # update the description of ConfVars.METASTORE_FILTER_HOOK to say that it gets 
overridden when V2 auth is used ?



> No prompting info or warning provided when METASTORE_FILTER_HOOK in 
> authorization V2 is overridden
> --------------------------------------------------------------------------------------------------
>
>                 Key: HIVE-11190
>                 URL: https://issues.apache.org/jira/browse/HIVE-11190
>             Project: Hive
>          Issue Type: Bug
>            Reporter: Dapeng Sun
>            Assignee: Dapeng Sun
>         Attachments: HIVE-11190.001.patch, HIVE-11190.002.patch
>
>
> ConfVars.METASTORE_FILTER_HOOK in authorization V2 is will be override 
> without prompting info or warning.
> it will cause user failed to customize the METASTORE_FILTER_HOOK. We should 
> log information such as "this value is ignored" when override happens.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to