[
https://issues.apache.org/jira/browse/HIVE-11197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14620055#comment-14620055
]
Jesus Camacho Rodriguez commented on HIVE-11197:
------------------------------------------------
[~ashutoshc], thanks for adding that comment.
I'm been checking the patch again, and I'm wondering if it wouldn't be correct
to bail out from CBO when the Exception is thrown instead of catching it in
those classes, as we may end up hitting other issues if we don't.
For instance, we can bail out in case we hit the Exception when we are checking
the cost of a certain join, or in case some of the rules are not applied e.g.
HiveInsertExchange4JoinRule which needs to be applied in the return path.
What do you think?
> While extracting join conditions follow Hive rules for type conversion
> instead of Calcite
> -----------------------------------------------------------------------------------------
>
> Key: HIVE-11197
> URL: https://issues.apache.org/jira/browse/HIVE-11197
> Project: Hive
> Issue Type: Bug
> Components: CBO
> Reporter: Ashutosh Chauhan
> Assignee: Ashutosh Chauhan
> Attachments: HIVE-11197.2.patch, HIVE-11197.2.patch,
> HIVE-11197.3.patch, HIVE-11197.patch, HIVE-11197.patch
>
>
> Calcite strict type system throws exception in those cases, which are legal
> in Hive.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
