[ https://issues.apache.org/jira/browse/HIVE-20292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16567397#comment-16567397 ]
Hive QA commented on HIVE-20292: -------------------------------- Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12934161/HIVE-20292.3.patch {color:green}SUCCESS:{color} +1 due to 1 test(s) being added or modified. {color:red}ERROR:{color} -1 due to 38 failed/errored test(s), 14850 tests executed *Failed tests:* {noformat} TestMiniDruidCliDriver - did not produce a TEST-*.xml file (likely timed out) (batchId=192) [druidmini_dynamic_partition.q,druidmini_test_ts.q,druidmini_expressions.q,druidmini_test_alter.q,druidmini_test_insert.q] org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[correlationoptimizer5] (batchId=74) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[join28] (batchId=89) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[mapjoin_subquery2] (batchId=6) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[mapjoin_subquery] (batchId=54) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[ppd_repeated_alias] (batchId=11) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[q93_with_constraints] (batchId=48) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[runtime_skewjoin_mapjoin_spark] (batchId=58) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[smb_mapjoin_25] (batchId=8) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[vector_outer_join6] (batchId=44) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[column_access_stats] (batchId=171) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[correlationoptimizer2] (batchId=169) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[correlationoptimizer3] (batchId=178) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[dynamic_semijoin_reduction_sw] (batchId=157) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[join32_lessSize] (batchId=157) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[llap_smb_ptf] (batchId=162) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[multiMapJoin1] (batchId=168) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[subquery_scalar] (batchId=166) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[tez_self_join] (batchId=176) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[vectorized_nested_mapjoin] (batchId=160) org.apache.hadoop.hive.cli.TestMiniSparkOnYarnCliDriver.testCliDriver[spark_use_op_stats] (batchId=186) org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[bucket_map_join_tez1] (batchId=147) org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[column_access_stats] (batchId=134) org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[join28] (batchId=146) org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[join32_lessSize] (batchId=111) org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[mapjoin_subquery2] (batchId=111) org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[mapjoin_subquery] (batchId=131) org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[runtime_skewjoin_mapjoin_spark] (batchId=133) org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[smb_mapjoin_25] (batchId=112) org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[subquery_scalar] (batchId=126) org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[vectorized_nested_mapjoin] (batchId=116) org.apache.hadoop.hive.cli.TestSparkPerfCliDriver.testCliDriver[query2] (batchId=265) org.apache.hadoop.hive.cli.TestSparkPerfCliDriver.testCliDriver[query59] (batchId=265) org.apache.hadoop.hive.cli.TestSparkPerfCliDriver.testCliDriver[query95] (batchId=265) org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[query2] (batchId=263) org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[query59] (batchId=263) org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[query93] (batchId=263) org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[query95] (batchId=263) {noformat} Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/13009/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/13009/console Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-13009/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.YetusPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase Tests exited with: TestsFailedException: 38 tests failed {noformat} This message is automatically generated. ATTACHMENT ID: 12934161 - PreCommit-HIVE-Build > Bad join ordering in tpcds query93 with primary constraint defined > ------------------------------------------------------------------ > > Key: HIVE-20292 > URL: https://issues.apache.org/jira/browse/HIVE-20292 > Project: Hive > Issue Type: Improvement > Components: Query Planning > Reporter: Vineet Garg > Assignee: Vineet Garg > Priority: Major > Attachments: HIVE-20292.1.patch, HIVE-20292.2.patch, > HIVE-20292.3.patch > > > Query 93 has join (including outer) b/w store_sales, store_return and reason. > Without constraints store_return is joined with reason and then with > store_sales. > But if a primary key is added on store_return (alter table store_returns add > constraint tpcds_pk_sr primary key (sr_item_sk, sr_ticket_number) disable > novalidate rely) join order becomes ((store_sales, store_return), reason) > which is very inefficient. -- This message was sent by Atlassian JIRA (v7.6.3#76005)