[ https://issues.apache.org/jira/browse/HIVE-20258?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16560565#comment-16560565 ]
Hive QA commented on HIVE-20258: -------------------------------- Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12933422/HIVE-20258.1.patch {color:red}ERROR:{color} -1 due to no test(s) being added or modified. {color:green}SUCCESS:{color} +1 due to 14813 tests passed Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/12910/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/12910/console Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-12910/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.YetusPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase {noformat} This message is automatically generated. ATTACHMENT ID: 12933422 - PreCommit-HIVE-Build > Should Syncronize getInstance in ReplChangeManager > -------------------------------------------------- > > Key: HIVE-20258 > URL: https://issues.apache.org/jira/browse/HIVE-20258 > Project: Hive > Issue Type: Bug > Components: Metastore > Affects Versions: 3.0.0, 4.0.0 > Reporter: BELUGA BEHR > Assignee: BELUGA BEHR > Priority: Minor > Attachments: HIVE-20258.1.patch > > > {code:java} > public static ReplChangeManager getInstance(Configuration conf) throws > MetaException { > if (instance == null) { > instance = new ReplChangeManager(conf); > } > return instance; > } > {code} > This method needs to be synchronized or two different threads may see a > 'null' value and each create their own manager. -- This message was sent by Atlassian JIRA (v7.6.3#76005)