[
https://issues.apache.org/jira/browse/HIVE-20257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16560529#comment-16560529
]
Hive QA commented on HIVE-20257:
--------------------------------
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12933414/HIVE-20257.1.patch
{color:red}ERROR:{color} -1 due to no test(s) being added or modified.
{color:green}SUCCESS:{color} +1 due to 14813 tests passed
Test results:
https://builds.apache.org/job/PreCommit-HIVE-Build/12908/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/12908/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-12908/
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.YetusPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
{noformat}
This message is automatically generated.
ATTACHMENT ID: 12933414 - PreCommit-HIVE-Build
> Improvements to Hive.java
> -------------------------
>
> Key: HIVE-20257
> URL: https://issues.apache.org/jira/browse/HIVE-20257
> Project: Hive
> Issue Type: Improvement
> Affects Versions: 3.0.0, 4.0.0
> Reporter: BELUGA BEHR
> Assignee: BELUGA BEHR
> Priority: Minor
> Fix For: 4.0.0
>
> Attachments: HIVE-20257.1.patch
>
>
> Various fixes to {{Hive.java}}
> * Use Log4J parameters in logging statements
> * Fix check styles
> * Make code more concise
> * Remove "log and throw" code
> * Replaced calls to deprecated code
> * Removed superfluous calls to {{toString}}
>
> "log and throw" is considered and anti-pattern. Only the highest level catch
> should be providing detailed logging otherwise we print the same stack trace
> to the logs several times and with different context (for example when an
> exception is wrapped, we get two different logging events).
>
> https://community.oracle.com/docs/DOC-983543#logAndThrow
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
