[ https://issues.apache.org/jira/browse/HIVE-20233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16560433#comment-16560433 ]
Hive QA commented on HIVE-20233: -------------------------------- Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12933397/HIVE-20233.2.patch {color:red}ERROR:{color} -1 due to no test(s) being added or modified. {color:red}ERROR:{color} -1 due to 1 failed/errored test(s), 14783 tests executed *Failed tests:* {noformat} TestMiniLlapLocalCliDriver - did not produce a TEST-*.xml file (likely timed out) (batchId=160) [insert_values_non_partitioned.q,retry_failure_oom.q,colstats_date_min_max.q,vectorized_math_funcs.q,vectorization_4.q,vectorization_2.q,subquery_multi.q,check_constraint.q,cbo_simple_select.q,tez_union_decimal.q,vector_parquet_nested_two_level_complex.q,multi_column_in.q,groupby1.q,order_null.q,cbo_rp_udf_udaf.q,cbo_rp_views.q,vector_decimal_aggregate.q,vector_date_1.q,lvj_mapjoin.q,update_all_types.q,retry_failure_stat_changes.q,kill_query.q,vector_llap_text_1.q,vector_decimal_3.q,update_two_cols.q,update_where_no_match.q,vectorized_nested_mapjoin.q,authorization_2.q,schema_evol_text_nonvec_part.q,enforce_constraint_notnull.q] {noformat} Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/12906/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/12906/console Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-12906/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.YetusPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase Tests exited with: TestsFailedException: 1 tests failed {noformat} This message is automatically generated. ATTACHMENT ID: 12933397 - PreCommit-HIVE-Build > Review Operator.java > -------------------- > > Key: HIVE-20233 > URL: https://issues.apache.org/jira/browse/HIVE-20233 > Project: Hive > Issue Type: Improvement > Components: Query Planning > Affects Versions: 3.0.0, 4.0.0 > Reporter: BELUGA BEHR > Assignee: BELUGA BEHR > Priority: Minor > Attachments: HIVE-20233.1.patch, HIVE-20233.2.patch > > > Various improvements to {{Operator.java}} > > * Code formatting > * Remove superfluous logging guards > * Add logging message parameters > * Minor performance improvements -- This message was sent by Atlassian JIRA (v7.6.3#76005)